* [patch] ide: eliminate redundant case in start_request()
@ 2006-07-29 15:58 Jason Lunz
0 siblings, 0 replies; only message in thread
From: Jason Lunz @ 2006-07-29 15:58 UTC (permalink / raw)
To: B.Zolnierkiewicz; +Cc: Alan Cox, linux-kernel
Collapse two redundant calls to execute_drive_cmd() in start_request().
Signed-off-by: Jason Lunz <lunz@falooley.org>
---
I can't think of any reason to separate out the two callsites unless
there's some future expansion planned here or something.
drivers/ide/ide-io.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Index: linux-2.6.18-rc2-git6/drivers/ide/ide-io.c
===================================================================
--- linux-2.6.18-rc2-git6.orig/drivers/ide/ide-io.c
+++ linux-2.6.18-rc2-git6/drivers/ide/ide-io.c
@@ -1014,9 +1014,7 @@
if (!drive->special.all) {
ide_driver_t *drv;
- if (rq->flags & (REQ_DRIVE_CMD | REQ_DRIVE_TASK))
- return execute_drive_cmd(drive, rq);
- else if (rq->flags & REQ_DRIVE_TASKFILE)
+ if (rq->flags & (REQ_DRIVE_CMD | REQ_DRIVE_TASK | REQ_DRIVE_TASKFILE))
return execute_drive_cmd(drive, rq);
else if (blk_pm_request(rq)) {
struct request_pm_state *pm = rq->end_io_data;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-07-29 15:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-07-29 15:58 [patch] ide: eliminate redundant case in start_request() Jason Lunz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).