linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch 2.6.18-rc3] RTC class, Kconfig improvements
@ 2006-08-05  0:41 David Brownell
  2006-08-19 17:19 ` David Brownell
  2006-09-29  6:32 ` [patch 2.6.18-git] " David Brownell
  0 siblings, 2 replies; 4+ messages in thread
From: David Brownell @ 2006-08-05  0:41 UTC (permalink / raw)
  To: Alessandro Zummo; +Cc: Linux Kernel list

Small updates to make the RTC class Kconfig text be more informative.
This should help folk used to the drivers/char/rtc.c support, or a
single RTC, be slightly less surprised by the differences.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

Index: g26/drivers/rtc/Kconfig
===================================================================
--- g26.orig/drivers/rtc/Kconfig	2006-08-04 17:20:34.000000000 -0700
+++ g26/drivers/rtc/Kconfig	2006-08-04 17:38:51.000000000 -0700
@@ -45,8 +45,8 @@ config RTC_INTF_SYSFS
 	depends on RTC_CLASS && SYSFS
 	default RTC_CLASS
 	help
-	  Say yes here if you want to use your RTC using the sysfs
-	  interface, /sys/class/rtc/rtcX .
+	  Say yes here if you want to use your RTCs using sysfs interfaces,
+	  /sys/class/rtc/rtc0 through /sys/.../rtcN.
 
 	  This driver can also be built as a module. If so, the module
 	  will be called rtc-sysfs.
@@ -56,8 +56,9 @@ config RTC_INTF_PROC
 	depends on RTC_CLASS && PROC_FS
 	default RTC_CLASS
 	help
-	  Say yes here if you want to use your RTC using the proc
-	  interface, /proc/driver/rtc .
+	  Say yes here if you want to use your first RTC through the proc
+	  interface, /proc/driver/rtc.  Other RTCs will not be available
+	  through that API.
 
 	  This driver can also be built as a module. If so, the module
 	  will be called rtc-proc.
@@ -67,8 +68,11 @@ config RTC_INTF_DEV
 	depends on RTC_CLASS
 	default RTC_CLASS
 	help
-	  Say yes here if you want to use your RTC using the dev
-	  interface, /dev/rtc .
+	  Say yes here if you want to use your RTCs using the /dev
+	  interfaces, which "udev" sets up as /dev/rtc0 through
+	  /dev/rtcN.  You may want to set up a symbolic link so one
+	  of these can be accessed as /dev/rtc, which is the name
+	  expected by "hwclock" and some other programs.
 
 	  This driver can also be built as a module. If so, the module
 	  will be called rtc-dev.
@@ -78,7 +82,8 @@ config RTC_INTF_DEV_UIE_EMUL
 	depends on RTC_INTF_DEV
 	help
 	  Provides an emulation for RTC_UIE if the underlaying rtc chip
-	  driver did not provide RTC_UIE ioctls.
+	  driver does not expose RTC_UIE ioctls.  Those requests generate
+	  once-per-second update interrupts, used to synchronization.
 
 comment "RTC drivers"
 	depends on RTC_CLASS

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch 2.6.18-rc3] RTC class, Kconfig improvements
  2006-08-05  0:41 [patch 2.6.18-rc3] RTC class, Kconfig improvements David Brownell
@ 2006-08-19 17:19 ` David Brownell
  2006-09-29  6:32 ` [patch 2.6.18-git] " David Brownell
  1 sibling, 0 replies; 4+ messages in thread
From: David Brownell @ 2006-08-19 17:19 UTC (permalink / raw)
  To: Alessandro Zummo; +Cc: Linux Kernel list

[ RESEND against RC4, plus added RTC_DEBUG option ]

Small updates to make the RTC class Kconfig text be more informative.
This should help folk used to the drivers/char/rtc.c support, or a
single RTC, be slightly less surprised by the differences.

Also, adds a new RTC_DEBUG option to predefine DEBUG in the framework
and its drivers, while debugging.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

Index: g26/drivers/rtc/Kconfig
===================================================================
--- g26.orig/drivers/rtc/Kconfig	2006-08-19 02:02:45.000000000 -0700
+++ g26/drivers/rtc/Kconfig	2006-08-19 10:08:23.000000000 -0700
@@ -37,6 +37,13 @@ config RTC_HCTOSYS_DEVICE
 	  The RTC device that will be used as the source for
 	  the system time, usually rtc0.
 
+config RTC_DEBUG
+	bool "RTC debug support"
+	depends on RTC_CLASS = y
+	help
+	  Say yes here to enable debugging support in the RTC framework
+	  and individual RTC drivers.
+
 comment "RTC interfaces"
 	depends on RTC_CLASS
 
@@ -45,8 +52,8 @@ config RTC_INTF_SYSFS
 	depends on RTC_CLASS && SYSFS
 	default RTC_CLASS
 	help
-	  Say yes here if you want to use your RTC using the sysfs
-	  interface, /sys/class/rtc/rtcX .
+	  Say yes here if you want to use your RTCs using sysfs interfaces,
+	  /sys/class/rtc/rtc0 through /sys/.../rtcN.
 
 	  This driver can also be built as a module. If so, the module
 	  will be called rtc-sysfs.
@@ -56,8 +63,9 @@ config RTC_INTF_PROC
 	depends on RTC_CLASS && PROC_FS
 	default RTC_CLASS
 	help
-	  Say yes here if you want to use your RTC using the proc
-	  interface, /proc/driver/rtc .
+	  Say yes here if you want to use your first RTC through the proc
+	  interface, /proc/driver/rtc.  Other RTCs will not be available
+	  through that API.
 
 	  This driver can also be built as a module. If so, the module
 	  will be called rtc-proc.
@@ -67,8 +75,11 @@ config RTC_INTF_DEV
 	depends on RTC_CLASS
 	default RTC_CLASS
 	help
-	  Say yes here if you want to use your RTC using the dev
-	  interface, /dev/rtc .
+	  Say yes here if you want to use your RTCs using the /dev
+	  interfaces, which "udev" sets up as /dev/rtc0 through
+	  /dev/rtcN.  You may want to set up a symbolic link so one
+	  of these can be accessed as /dev/rtc, which is a name
+	  expected by "hwclock" and some other programs.
 
 	  This driver can also be built as a module. If so, the module
 	  will be called rtc-dev.
@@ -78,7 +89,8 @@ config RTC_INTF_DEV_UIE_EMUL
 	depends on RTC_INTF_DEV
 	help
 	  Provides an emulation for RTC_UIE if the underlaying rtc chip
-	  driver did not provide RTC_UIE ioctls.
+	  driver does not expose RTC_UIE ioctls.  Those requests generate
+	  once-per-second update interrupts, used for synchronization.
 
 comment "RTC drivers"
 	depends on RTC_CLASS
Index: g26/drivers/rtc/Makefile
===================================================================
--- g26.orig/drivers/rtc/Makefile	2006-08-19 10:08:09.000000000 -0700
+++ g26/drivers/rtc/Makefile	2006-08-19 10:09:07.000000000 -0700
@@ -2,6 +2,10 @@
 # Makefile for RTC class/drivers.
 #
 
+ifeq ($(CONFIG_RTC_DEBUG),y)
+	EXTRA_CFLAGS		+= -DDEBUG
+endif
+
 obj-$(CONFIG_RTC_LIB)		+= rtc-lib.o
 obj-$(CONFIG_RTC_HCTOSYS)	+= hctosys.o
 obj-$(CONFIG_RTC_CLASS)		+= rtc-core.o

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [patch 2.6.18-git] RTC class, Kconfig improvements
  2006-08-05  0:41 [patch 2.6.18-rc3] RTC class, Kconfig improvements David Brownell
  2006-08-19 17:19 ` David Brownell
@ 2006-09-29  6:32 ` David Brownell
  2006-09-30 15:50   ` Oleg Verych
  1 sibling, 1 reply; 4+ messages in thread
From: David Brownell @ 2006-09-29  6:32 UTC (permalink / raw)
  To: Alessandro Zummo; +Cc: Linux Kernel list, Andrew Morton

[ RESEND third time ]

Small updates to make the RTC class Kconfig text be more informative.
This should help folk used to the drivers/char/rtc.c support, or a
single RTC, be slightly less surprised by the differences.

Also, adds a new RTC_DEBUG option to predefine DEBUG in the framework
and its drivers, while debugging.  That's getting to be a standard
idiom, and it's pretty useful.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

Index: g26/drivers/rtc/Kconfig
===================================================================
--- g26.orig/drivers/rtc/Kconfig	2006-08-19 02:02:45.000000000 -0700
+++ g26/drivers/rtc/Kconfig	2006-08-19 10:08:23.000000000 -0700
@@ -37,6 +37,13 @@ config RTC_HCTOSYS_DEVICE
 	  The RTC device that will be used as the source for
 	  the system time, usually rtc0.
 
+config RTC_DEBUG
+	bool "RTC debug support"
+	depends on RTC_CLASS = y
+	help
+	  Say yes here to enable debugging support in the RTC framework
+	  and individual RTC drivers.
+
 comment "RTC interfaces"
 	depends on RTC_CLASS
 
@@ -45,8 +52,8 @@ config RTC_INTF_SYSFS
 	depends on RTC_CLASS && SYSFS
 	default RTC_CLASS
 	help
-	  Say yes here if you want to use your RTC using the sysfs
-	  interface, /sys/class/rtc/rtcX .
+	  Say yes here if you want to use your RTCs using sysfs interfaces,
+	  /sys/class/rtc/rtc0 through /sys/.../rtcN.
 
 	  This driver can also be built as a module. If so, the module
 	  will be called rtc-sysfs.
@@ -56,8 +63,9 @@ config RTC_INTF_PROC
 	depends on RTC_CLASS && PROC_FS
 	default RTC_CLASS
 	help
-	  Say yes here if you want to use your RTC using the proc
-	  interface, /proc/driver/rtc .
+	  Say yes here if you want to use your first RTC through the proc
+	  interface, /proc/driver/rtc.  Other RTCs will not be available
+	  through that API.
 
 	  This driver can also be built as a module. If so, the module
 	  will be called rtc-proc.
@@ -67,8 +75,11 @@ config RTC_INTF_DEV
 	depends on RTC_CLASS
 	default RTC_CLASS
 	help
-	  Say yes here if you want to use your RTC using the dev
-	  interface, /dev/rtc .
+	  Say yes here if you want to use your RTCs using the /dev
+	  interfaces, which "udev" sets up as /dev/rtc0 through
+	  /dev/rtcN.  You may want to set up a symbolic link so one
+	  of these can be accessed as /dev/rtc, which is a name
+	  expected by "hwclock" and some other programs.
 
 	  This driver can also be built as a module. If so, the module
 	  will be called rtc-dev.
@@ -78,7 +89,8 @@ config RTC_INTF_DEV_UIE_EMUL
 	depends on RTC_INTF_DEV
 	help
 	  Provides an emulation for RTC_UIE if the underlaying rtc chip
-	  driver did not provide RTC_UIE ioctls.
+	  driver does not expose RTC_UIE ioctls.  Those requests generate
+	  once-per-second update interrupts, used for synchronization.
 
 comment "RTC drivers"
 	depends on RTC_CLASS
Index: g26/drivers/rtc/Makefile
===================================================================
--- g26.orig/drivers/rtc/Makefile	2006-08-19 10:08:09.000000000 -0700
+++ g26/drivers/rtc/Makefile	2006-08-19 10:09:07.000000000 -0700
@@ -2,6 +2,10 @@
 # Makefile for RTC class/drivers.
 #
 
+ifeq ($(CONFIG_RTC_DEBUG),y)
+	EXTRA_CFLAGS		+= -DDEBUG
+endif
+
 obj-$(CONFIG_RTC_LIB)		+= rtc-lib.o
 obj-$(CONFIG_RTC_HCTOSYS)	+= hctosys.o
 obj-$(CONFIG_RTC_CLASS)		+= rtc-core.o

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch 2.6.18-git] RTC class, Kconfig improvements
  2006-09-29  6:32 ` [patch 2.6.18-git] " David Brownell
@ 2006-09-30 15:50   ` Oleg Verych
  0 siblings, 0 replies; 4+ messages in thread
From: Oleg Verych @ 2006-09-30 15:50 UTC (permalink / raw)
  To: linux-kernel

On 2006-09-29, David Brownell <david-b@pacbell.net> wrote:
>
> *[ RESEND third time ]*
>
> Small updates to make the RTC class Kconfig text be more informative.
> This should help folk used to the drivers/char/rtc.c support, or a
> single RTC, be slightly less surprised by the differences.
>
> Also, adds a new RTC_DEBUG option to predefine DEBUG in the framework
> and its drivers, while debugging.  That's getting to be a standard
> idiom, and it's pretty useful.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
>

ACK

> Index: g26/drivers/rtc/Kconfig
>===================================================================
> --- g26.orig/drivers/rtc/Kconfig	2006-08-19 02:02:45.000000000 -0700
> +++ g26/drivers/rtc/Kconfig	2006-08-19 10:08:23.000000000 -0700
> @@ -37,6 +37,13 @@ config RTC_HCTOSYS_DEVICE
>  	  The RTC device that will be used as the source for
>  	  the system time, usually rtc0.
>  
> +config RTC_DEBUG
> +	bool "RTC debug support"
> +	depends on RTC_CLASS = y
> +	help
> +	  Say yes here to enable debugging support in the RTC framework
> +	  and individual RTC drivers.
> +
>  comment "RTC interfaces"
>  	depends on RTC_CLASS
>  
> @@ -45,8 +52,8 @@ config RTC_INTF_SYSFS
>  	depends on RTC_CLASS && SYSFS
>  	default RTC_CLASS
>  	help
> -	  Say yes here if you want to use your RTC using the sysfs
> -	  interface, /sys/class/rtc/rtcX .
> +	  Say yes here if you want to use your RTCs using sysfs interfaces,
> +	  /sys/class/rtc/rtc0 through /sys/.../rtcN.
>  
>  	  This driver can also be built as a module. If so, the module
>  	  will be called rtc-sysfs.
> @@ -56,8 +63,9 @@ config RTC_INTF_PROC
>  	depends on RTC_CLASS && PROC_FS
>  	default RTC_CLASS
>  	help
> -	  Say yes here if you want to use your RTC using the proc
> -	  interface, /proc/driver/rtc .
> +	  Say yes here if you want to use your first RTC through the proc
> +	  interface, /proc/driver/rtc.  Other RTCs will not be available
> +	  through that API.
>  
>  	  This driver can also be built as a module. If so, the module
>  	  will be called rtc-proc.
> @@ -67,8 +75,11 @@ config RTC_INTF_DEV
>  	depends on RTC_CLASS
>  	default RTC_CLASS
>  	help
> -	  Say yes here if you want to use your RTC using the dev
> -	  interface, /dev/rtc .
> +	  Say yes here if you want to use your RTCs using the /dev
> +	  interfaces, which "udev" sets up as /dev/rtc0 through
> +	  /dev/rtcN.  You may want to set up a symbolic link so one
> +	  of these can be accessed as /dev/rtc, which is a name
> +	  expected by "hwclock" and some other programs.
>  
>  	  This driver can also be built as a module. If so, the module
>  	  will be called rtc-dev.
> @@ -78,7 +89,8 @@ config RTC_INTF_DEV_UIE_EMUL
>  	depends on RTC_INTF_DEV
>  	help
>  	  Provides an emulation for RTC_UIE if the underlaying rtc chip
> -	  driver did not provide RTC_UIE ioctls.
> +	  driver does not expose RTC_UIE ioctls.  Those requests generate
> +	  once-per-second update interrupts, used for synchronization.
>  
>  comment "RTC drivers"
>  	depends on RTC_CLASS
> Index: g26/drivers/rtc/Makefile
>===================================================================
> --- g26.orig/drivers/rtc/Makefile	2006-08-19 10:08:09.000000000 -0700
> +++ g26/drivers/rtc/Makefile	2006-08-19 10:09:07.000000000 -0700
> @@ -2,6 +2,10 @@
>  # Makefile for RTC class/drivers.
>  #
>  
> +ifeq ($(CONFIG_RTC_DEBUG),y)
> +	EXTRA_CFLAGS		+= -DDEBUG
> +endif
> +
>  obj-$(CONFIG_RTC_LIB)		+= rtc-lib.o
>  obj-$(CONFIG_RTC_HCTOSYS)	+= hctosys.o
>  obj-$(CONFIG_RTC_CLASS)		+= rtc-core.o


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2006-09-30 15:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-08-05  0:41 [patch 2.6.18-rc3] RTC class, Kconfig improvements David Brownell
2006-08-19 17:19 ` David Brownell
2006-09-29  6:32 ` [patch 2.6.18-git] " David Brownell
2006-09-30 15:50   ` Oleg Verych

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).