[PATCH 15/25] dm: add uevent change event on resume

[PATCH 15/25] dm: add uevent change event on resume

[Alasdair G Kergon]

From: Hannes Reinecke <hare@suse.de>

Device-mapper devices are not accessible until a 'resume' ioctl has been
issued.  For userspace to find out when this happens we need to generate an
uevent for udev to take appropriate action.

As discussed at OLS we should send 'change' events for 'resume'.
We can think of no useful purpose served by also having 'suspend' events.

Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>

Index: linux-2.6.18-rc7/drivers/md/dm.c
===================================================================
--- linux-2.6.18-rc7.orig/drivers/md/dm.c	2006-09-14 20:26:19.000000000 +0100
+++ linux-2.6.18-rc7/drivers/md/dm.c	2006-09-14 20:55:52.000000000 +0100
@@ -1378,6 +1378,8 @@ int dm_resume(struct mapped_device *md)
 
 	dm_table_unplug_all(map);
 
+	kobject_uevent(&md->disk->kobj, KOBJ_CHANGE);
+
 	r = 0;
 
 out:

Re: [PATCH 15/25] dm: add uevent change event on resume

[Greg KH]

On Thu, Sep 14, 2006 at 10:47:29PM +0100, Alasdair G Kergon wrote:
> From: Hannes Reinecke <hare@suse.de>
> 
> Device-mapper devices are not accessible until a 'resume' ioctl has been
> issued.  For userspace to find out when this happens we need to generate an
> uevent for udev to take appropriate action.
> 
> As discussed at OLS we should send 'change' events for 'resume'.
> We can think of no useful purpose served by also having 'suspend' events.
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Kay Sievers <kay.sievers@vrfy.org>
> Signed-off-by: Alasdair G Kergon <agk@redhat.com>

I was at that meeting for a bit (had to chase after my son...) so feel
free to add:
	Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

from me to this patch.

thanks,

greg k-h