* [PATCH] firmware/efivars: handle error
@ 2006-10-10 13:19 Jeff Garzik
2006-10-10 13:29 ` Matt Domsch
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Garzik @ 2006-10-10 13:19 UTC (permalink / raw)
To: Matt_Domsch, Andrew Morton, LKML
Signed-off-by: Jeff Garzik <jeff@garzik.org>
---
drivers/firmware/efivars.c | 7 ++++++-
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index 8ebce1c..5ab5e39 100644
--- a/drivers/firmware/efivars.c
+++ b/drivers/firmware/efivars.c
@@ -639,7 +639,12 @@ efivar_create_sysfs_entry(unsigned long
kobject_set_name(&new_efivar->kobj, "%s", short_name);
kobj_set_kset_s(new_efivar, vars_subsys);
- kobject_register(&new_efivar->kobj);
+ i = kobject_register(&new_efivar->kobj);
+ if (i) {
+ kfree(short_name);
+ kfree(new_efivar);
+ return 1;
+ }
kfree(short_name);
short_name = NULL;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] firmware/efivars: handle error
2006-10-10 13:19 [PATCH] firmware/efivars: handle error Jeff Garzik
@ 2006-10-10 13:29 ` Matt Domsch
0 siblings, 0 replies; 2+ messages in thread
From: Matt Domsch @ 2006-10-10 13:29 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Andrew Morton, LKML
On Tue, Oct 10, 2006 at 09:19:49AM -0400, Jeff Garzik wrote:
>
>
> Signed-off-by: Jeff Garzik <jeff@garzik.org>
>
> ---
>
> drivers/firmware/efivars.c | 7 ++++++-
>
> diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
> index 8ebce1c..5ab5e39 100644
> --- a/drivers/firmware/efivars.c
> +++ b/drivers/firmware/efivars.c
> @@ -639,7 +639,12 @@ efivar_create_sysfs_entry(unsigned long
>
> kobject_set_name(&new_efivar->kobj, "%s", short_name);
> kobj_set_kset_s(new_efivar, vars_subsys);
> - kobject_register(&new_efivar->kobj);
> + i = kobject_register(&new_efivar->kobj);
> + if (i) {
> + kfree(short_name);
> + kfree(new_efivar);
> + return 1;
> + }
>
> kfree(short_name);
> short_name = NULL;
Acked-by: Matt Domsch <Matt_Domsch@dell.com>
Thanks Jeff!
--
Matt Domsch
Software Architect
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-10 13:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-10-10 13:19 [PATCH] firmware/efivars: handle error Jeff Garzik
2006-10-10 13:29 ` Matt Domsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).