Re: [PATCH 2/2] fsstack: Fix up ecryptfs's fsstack usage

[Josef Sipek <jsipek@fsl.cs.sunysb.edu>]

On Tue, Dec 05, 2006 at 02:28:31PM -0800, Andrew Morton wrote:
> On Tue, 5 Dec 2006 14:22:32 -0500
> Josef Sipek <jsipek@fsl.cs.sunysb.edu> wrote:
> 
> > Fix up a stray ecryptfs_copy_attr_all call and remove prototypes for
> > ecryptfs_copy_* as they no longer exist.
> > 
> > Signed-off-by: Josef "Jeff" Sipek <jsipek@cs.sunysb.edu>
> > ---
> >  fs/ecryptfs/dentry.c          |    2 +-
> >  fs/ecryptfs/ecryptfs_kernel.h |    4 +---
> >  2 files changed, 2 insertions(+), 4 deletions(-)
> > 
> > diff --git a/fs/ecryptfs/dentry.c b/fs/ecryptfs/dentry.c
> > index 52d1e36..b0352d8 100644
> > --- a/fs/ecryptfs/dentry.c
> > +++ b/fs/ecryptfs/dentry.c
> > @@ -61,7 +61,7 @@ static int ecryptfs_d_revalidate(struct
> >  		struct inode *lower_inode =
> >  			ecryptfs_inode_to_lower(dentry->d_inode);
> >  
> > -		ecryptfs_copy_attr_all(dentry->d_inode, lower_inode);
> > +		fsstack_copy_attr_all(dentry->d_inode, lower_inode, NULL);
> 
> I fixed that two weeks ago.
> 
> When your patches are queued in -mm please do test them there, and review
> others' changes to them, and raise patches against them.  Raising patches
> against one's private tree and not testing the code which is planned to be
> merged can introduce errors.

Sorry about that. I noticed your fix, and the one by Adrian. And I did add
them to my fsstack queue.

I must have dropped it accidentally.

Josef "Jeff" Sipek.

-- 
If I have trouble installing Linux, something is wrong. Very wrong.
		- Linus Torvalds