From: Randy Dunlap <randy.dunlap@oracle.com>
To: conke.hu@gmail.com
Cc: Andrew Morton <akpm@osdl.org>, Jeff Garzik <jeff@garzik.org>,
linux-kernel@vger.kernel.org,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: -mm merge plans for 2.6.20
Date: Wed, 6 Dec 2006 11:26:03 -0800 [thread overview]
Message-ID: <20061206112603.a893e5d5.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1165432780.21881.20.camel@linux-qmhe.site>
On Thu, 07 Dec 2006 03:19:40 +0800 Conke Hu wrote:
> On Mon, 2006-12-04 at 21:41 -0800, Andrew Morton wrote:
> > On Mon, 04 Dec 2006 23:56:42 -0500
> > Jeff Garzik <jeff@garzik.org> wrote:
> >
> > > Andrew Morton wrote:
> > > > via-pata-controller-xfer-fixes.patch
> > > > via-pata-controller-xfer-fixes-fix.patch
> > >
> > > Tejun's 3d3cca37559e3ab2b574eda11ed5207ccdb8980a has been ack'd by the
> > > reporter as fixing things, so these two shouldn't be needed.
> >
> > OK thanks, I dropped it.
> >
> > >
> > > > libata_resume_fix.patch
> > >
> > > I thought this was resolved long ago? Are there still open reports that
> > > this solves, where upstream doesn't work?
> >
> > Heck, I don't know.
> >
> > >
> > > > ahci-ati-sb600-sata-support-for-various-modes.patch
> > >
> > > With the PCI quirk, I thought ATI was finally sorted?
> >
> > Was it? I don't know that either.
> >
> > I'll drop these too.
> > -
>
> Hi Jeff, Andrew
> The following patch is ATI's final solution. It was ACKed by Alan.
> Jeff, you're the maintainer of libata, but this patch is based on
> pci/quirks.c, so I don't know who will apply this patch? You or somebody
> else?
> Andrew, could you please drop ATI's previous patch and add this one
> in next -mm patch? The previous patch I sent
> (ahci-ati-sb600-sata-support-for-various-modes.patch) is not as good as
> this one :)
>
>
> Best regards,
> Conke @AMD/ATI
>
>
> [------------------PATCH------------------]
>
> --- linux-2.6.19-rc6-git4/drivers/pci/quirks.c.orig 2006-11-23
> 19:45:49.000000000 +0800
> +++ linux-2.6.19-rc6-git4/drivers/pci/quirks.c 2006-11-23
> 19:34:23.000000000 +0800
> @@ -795,6 +795,25 @@ static void __init quirk_mediagx_master(
> }
> }
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_CYRIX,
> PCI_DEVICE_ID_CYRIX_PCI_MASTER, quirk_mediagx_master );
> +
> +#if defined(CONFIG_SATA_AHCI) || defined(CONFIG_SATA_AHCI_MODULE)
> +static void __devinit quirk_sb600_sata(struct pci_dev *pdev)
> +{
> + /* set sb600 sata to ahci mode */
> + if ((pdev->class >> 8) == PCI_CLASS_STORAGE_IDE) {
> + u8 tmp;
> +
> + pci_read_config_byte(pdev, 0x40, &tmp);
> + pci_write_config_byte(pdev, 0x40, tmp|1);
> + pci_write_config_byte(pdev, 0x9, 1);
> + pci_write_config_byte(pdev, 0xa, 6);
> + pci_write_config_byte(pdev, 0x40, tmp);
> +
> + pdev->class = 0x010601;
> + }
> +}
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATI,
> PCI_DEVICE_ID_ATI_IXP600_SATA, quirk_sb600_sata);
> +#endif
>
> /*
> * As per PCI spec, ignore base address registers 0-3 of the IDE
> controllers
Can you use fewer magic numbers, please?
At least some of those are already #defined in
include/linux/pci_regs.h.
---
~Randy
next prev parent reply other threads:[~2006-12-06 19:25 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-05 4:40 -mm merge plans for 2.6.20 Andrew Morton
2006-12-05 4:56 ` Jeff Garzik
2006-12-05 5:41 ` Andrew Morton
2006-12-05 7:04 ` Jens Axboe
2006-12-05 15:00 ` Mark Lord
2006-12-06 19:19 ` Conke Hu
2006-12-06 19:26 ` Randy Dunlap [this message]
2006-12-06 19:40 ` Jeff Garzik
2006-12-06 22:36 ` Andrew Morton
2006-12-05 5:14 ` Paul Mackerras
2006-12-05 5:42 ` Andrew Morton
2006-12-05 5:53 ` Nick Piggin
2006-12-05 5:49 ` Nick Piggin
2006-12-05 8:36 ` Gautham R Shenoy
2006-12-05 8:47 ` Peter Zijlstra
2006-12-05 11:06 ` ext2 future [was Re: -mm merge plans for 2.6.20] Pavel Machek
2006-12-05 13:23 ` -mm merge plans for 2.6.20 John W. Linville
2006-12-05 14:27 ` Roman Zippel
2006-12-06 3:46 ` Horst Schirmeier
2006-12-05 16:02 ` Dave Jones
2006-12-12 17:49 ` Dave Jones
2006-12-19 5:20 ` Nick Piggin
2006-12-19 6:44 ` Dave Jones
2006-12-19 7:02 ` Nick Piggin
2007-01-07 17:36 ` page_mapcount(page) went negative Dave Jones
2007-01-10 23:53 ` Nick Piggin
2006-12-05 17:35 ` -mm merge plans for 2.6.20 James Simmons
2006-12-05 18:01 ` Andrew Morton
2006-12-05 18:25 ` James Simmons
2006-12-05 18:37 ` [PATCH] backlight sysfs change to the fbdev drivers James Simmons
2006-12-05 19:43 ` -mm merge plans for 2.6.20 Andrew Morton
2006-12-05 19:59 ` James Simmons
2006-12-05 20:20 ` Andrew Morton
2006-12-05 21:34 ` James Simmons
2006-12-06 23:40 ` Andrew Morton
2006-12-07 14:31 ` James Simmons
2006-12-05 20:40 ` Miguel Ojeda
2006-12-06 14:42 ` James Simmons
2006-12-05 19:18 ` Josef Sipek
2006-12-05 19:21 ` [PATCH 1/2] fsstack: Make fsstack_copy_attr_all copy inode size Josef Sipek
2006-12-05 19:22 ` [PATCH 2/2] fsstack: Fix up ecryptfs's fsstack usage Josef Sipek
2006-12-05 22:28 ` Andrew Morton
2006-12-05 22:38 ` Josef Sipek
2006-12-05 22:49 ` Andrew Morton
2006-12-05 23:16 ` Josef Sipek
2006-12-05 21:00 ` -mm merge plans for 2.6.20 Ingo Molnar
2006-12-05 21:17 ` -mm merge plans for 2.6.20, scheduler bits Ingo Molnar
2006-12-05 20:59 ` Siddha, Suresh B
2006-12-05 21:47 ` Ingo Molnar
2006-12-05 21:29 ` Miguel Ojeda
2006-12-06 2:59 ` -mm merge plans for 2.6.20 Roman Zippel
2006-12-06 4:30 ` Andrew Morton
2006-12-06 8:32 ` Thomas Gleixner
2006-12-06 12:54 ` Roman Zippel
2006-12-06 13:11 ` Ingo Molnar
2006-12-06 14:33 ` Roman Zippel
2006-12-06 15:22 ` Ingo Molnar
2006-12-06 16:42 ` Roman Zippel
2006-12-06 16:58 ` Ingo Molnar
2006-12-06 16:59 ` Ingo Molnar
2006-12-12 20:40 ` [RFC] HZ free ntp john stultz
2006-12-13 9:51 ` Ingo Molnar
2006-12-13 18:48 ` john stultz
2006-12-13 13:47 ` Roman Zippel
2006-12-13 19:19 ` john stultz
2006-12-13 20:40 ` Roman Zippel
2006-12-20 1:32 ` john stultz
2006-12-20 1:54 ` john stultz
2006-12-21 4:26 ` Andrew Morton
2007-01-01 18:29 ` Roman Zippel
2007-01-02 19:46 ` john stultz
2007-01-02 20:50 ` john stultz
2007-01-06 16:56 ` Roman Zippel
2007-01-22 19:27 ` [patch] HZ-free NTP Ingo Molnar
2007-01-22 19:39 ` Ingo Molnar
2007-01-01 16:27 ` [RFC] HZ free ntp Roman Zippel
2007-01-02 19:42 ` john stultz
2007-01-06 16:46 ` Roman Zippel
2006-12-06 12:33 ` -mm merge plans for 2.6.20 Roman Zippel
2006-12-08 14:09 ` Stephen Smalley
2006-12-08 20:58 ` Andrew Morton
2006-12-10 15:07 ` Mimi Zohar
2006-12-09 9:30 ` Randy Dunlap
2006-12-09 9:44 ` Andrew Morton
2006-12-10 20:12 ` Randy Dunlap
2006-12-05 23:55 Alessandro Guido
2006-12-06 0:13 ` Andrew Morton
2006-12-08 18:32 Steve French
2006-12-08 21:38 ` Andrew Morton
2006-12-10 3:18 Chuck Ebbert
2006-12-11 4:19 ` Steve French
2006-12-11 9:32 Chuck Ebbert
2006-12-13 1:09 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061206112603.a893e5d5.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=conke.hu@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).