linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm: Remove final traces of deprecated kmem_cache_t.
@ 2006-12-19 18:10 Robert P. J. Day
  2006-12-21  3:48 ` Andrew Morton
  0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2006-12-19 18:10 UTC (permalink / raw)
  To: Linux kernel mailing list


  Remove the last use of kmem_cache_t and the deprecated typedef.

Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>

---

  without looking too deeply into it, it looks like the last
references to kmem_cache_t can be removed, although there are still
going to be online web pages that refer to it, like

  http://old.kernelnewbies.org/documents/kdoc/kernel-api/r2382.html


 fs/dlm/lowcomms-tcp.c |    2 +-
 include/linux/slab.h  |    2 --
 2 files changed, 1 insertion(+), 3 deletions(-)


diff --git a/fs/dlm/lowcomms-tcp.c b/fs/dlm/lowcomms-tcp.c
index 8f2791f..9be3a44 100644
--- a/fs/dlm/lowcomms-tcp.c
+++ b/fs/dlm/lowcomms-tcp.c
@@ -143,7 +143,7 @@ static DECLARE_WAIT_QUEUE_HEAD(lowcomms_recv_waitq);
 /* An array of pointers to connections, indexed by NODEID */
 static struct connection **connections;
 static DECLARE_MUTEX(connections_lock);
-static kmem_cache_t *con_cache;
+static struct kmem_cache *con_cache;
 static int conn_array_size;

 /* List of sockets that have reads pending */
diff --git a/include/linux/slab.h b/include/linux/slab.h
index 1ef822e..b115541 100644
--- a/include/linux/slab.h
+++ b/include/linux/slab.h
@@ -14,8 +14,6 @@
 #include <linux/gfp.h>
 #include <linux/types.h>

-typedef struct kmem_cache kmem_cache_t __deprecated;
-
 /*
  * Flags to pass to kmem_cache_create().
  * The ones marked DEBUG are only valid if CONFIG_SLAB_DEBUG is set.

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mm: Remove final traces of deprecated kmem_cache_t.
  2006-12-19 18:10 [PATCH] mm: Remove final traces of deprecated kmem_cache_t Robert P. J. Day
@ 2006-12-21  3:48 ` Andrew Morton
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2006-12-21  3:48 UTC (permalink / raw)
  To: Robert P. J. Day; +Cc: Linux kernel mailing list

On Tue, 19 Dec 2006 13:10:11 -0500 (EST)
"Robert P. J. Day" <rpjday@mindspring.com> wrote:

> --- a/include/linux/slab.h
> +++ b/include/linux/slab.h
> @@ -14,8 +14,6 @@
>  #include <linux/gfp.h>
>  #include <linux/types.h>
> 
> -typedef struct kmem_cache kmem_cache_t __deprecated;
> -

Nope, let's leave that there for a couple of kernel cycles, give people  
to catch up.

It's fairly common for non-developers to download and build out-of-tree code from
random websites.  Let's not break their build unless we really need to.  In this
case there's little cost to us in giving the developers of that out-of-tree code
time to do an update.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-12-21  3:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-12-19 18:10 [PATCH] mm: Remove final traces of deprecated kmem_cache_t Robert P. J. Day
2006-12-21  3:48 ` Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).