* [PATCH] pc110pad: return proper error
@ 2006-12-19 8:44 Akinobu Mita
2006-12-21 5:44 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Akinobu Mita @ 2006-12-19 8:44 UTC (permalink / raw)
To: linux-kernel; +Cc: Dmitry Torokhov, Vojtech Pavlik
According to the comment, "if we find any PCI devices in the machine,
we don't have a PC110" in pc110pad.c, we should return -ENODEV
rather than -ENOENT in this case.
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Vojtech Pavlik <vojtech@suse.cz>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
drivers/input/mouse/pc110pad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: 2.6-mm/drivers/input/mouse/pc110pad.c
===================================================================
--- 2.6-mm.orig/drivers/input/mouse/pc110pad.c
+++ 2.6-mm/drivers/input/mouse/pc110pad.c
@@ -113,7 +113,7 @@ static int __init pc110pad_init(void)
dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, NULL);
if (dev) {
pci_dev_put(dev);
- return -ENOENT;
+ return -ENODEV;
}
if (!request_region(pc110pad_io, 4, "pc110pad")) {
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] pc110pad: return proper error
2006-12-19 8:44 [PATCH] pc110pad: return proper error Akinobu Mita
@ 2006-12-21 5:44 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2006-12-21 5:44 UTC (permalink / raw)
To: Akinobu Mita; +Cc: linux-kernel
On Tuesday 19 December 2006 03:44, Akinobu Mita wrote:
> According to the comment, "if we find any PCI devices in the machine,
> we don't have a PC110" in pc110pad.c, we should return -ENODEV
> rather than -ENOENT in this case.
>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-12-21 5:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-12-19 8:44 [PATCH] pc110pad: return proper error Akinobu Mita
2006-12-21 5:44 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).