* Re: Happy New Year (and v2.6.20-rc3 released)
2007-01-01 1:19 Happy New Year (and v2.6.20-rc3 released) Linus Torvalds
@ 2007-01-01 1:39 ` Gene Heskett
2007-01-01 2:40 ` Alexey Dobriyan
` (12 subsequent siblings)
13 siblings, 0 replies; 56+ messages in thread
From: Gene Heskett @ 2007-01-01 1:39 UTC (permalink / raw)
To: linux-kernel; +Cc: Linus Torvalds
On Sunday 31 December 2006 20:19, Linus Torvalds wrote:
>In order to not get in trouble with MADR ("Mothers Against Drunk
>Releases") I decided to cut the 2.6.20-rc3 release early rather than
> wait for midnight, because it's bound to be new years _somewhere_ out
> there. So here's to a happy 2007 for everybody.
>
>The big thing at least for me personally is that nasty shared mmap
>corruption fix, but there's a number of other changes in here, many of
>them just documentation (and some media and network drivers). Shortlog
> and diffstat appended..
>
>The git trees have been updated, and the tar-tree and patches seem to
> have finisged crawling out my poor DSL connection too.
>
>As usual, mirroring might take a while, although the delay has not been
>all that horrible lately, so it's probably going to be up-to-date by the
>time the hangovers are mostly gone.
>
>At which point the first thing on any self-respecting geek's mind should
>obviously be: "is there a new kernel release for me to try?"
>
>Right?
>
Right. Have a Happy New Year yourself, Linus.
> Linus
>
>----
>Adrian Bunk (2):
> V4L/DVB (4959): Usbvision: possible cleanups
> V4L/DVB (4991): Cafe_ccic.c: fix NULL dereference
>
>Akinobu Mita (5):
> V4L/DVB (4994): Vivi: fix use after free in list_for_each()
> V4L/DVB (4995): Vivi: fix kthread_run() error check
> V4L/DVB (4996): Msp3400: fix kthread_run error check
> V4L/DVB (4997): Bttv: delete duplicated ioremap()
> module: fix mod_sysfs_setup() return value
>
>Al Viro (1):
> page_mkclean_one(): fix call to set_pte_at()
>
>Alexey Dobriyan (2):
> V4L/DVB (5012): Usbvision fix: It was using "&&" instead "&"
> fuse: fix typo
>
>Amit Choudhary (1):
> V4L/DVB (4990): Cpia2/cpia2_usb.c: fix error-path leak
>
>Amit S. Kale (8):
> NetXen: Adding new device ids.
> NetXen: driver reload fix for newer firmware.
> NetXen: Using correct CHECKSUM flag.
> NetXen: Multiple adapter fix.
> NetXen: Link status message correction for quad port cards.
> NetXen: work queue fixes.
> NetXen: Fix for PPC machines.
> NetXen: Reducing ring sizes for IOMMU issue.
>
>Andreas Schwab (1):
> Fix compilation of via-pmu-backlight
>
>Andrew Morton (2):
> cpuset procfs warning fix
> lockdep: printk warning fix
>
>Ang Way Chuang (1):
> V4L/DVB (4972): Dvb-core: fix bug in CRC-32 checking on 64-bit
> systems
>
>Arnaud Patard (Rtp (1):
> spi_s3c24xx_gpio: use right header
>
>Avi Kivity (6):
> KVM: Use boot_cpu_data instead of current_cpu_data
> KVM: Simplify is_long_mode()
> KVM: Implement a few system configuration msrs
> KVM: Move common msr handling to arch independent code
> KVM: More msr misery
> KVM: Fix oops on oom
>
>Ayaz Abdulla (1):
> forcedeth: modified comment header
>
>Brice Goglin (5):
> myri10ge: match number of save_state and restore
> myri10ge: move request_irq to myri10ge_open
> myri10ge: make msi configurable at runtime through sysfs
> myri10ge: no need to save MSI and PCIe state in the driver
> myri10ge: handle failures in suspend and resume
>
>Bruce Allan (2):
> e1000: fix to set the new max frame size before resetting the
> adapter e1000: Fix PBA allocation calculations
>
>David Brownell (4):
> V4L/DVB (5014): Allyesconfig build fixes on some non x86 arch
> SPI: define null tx_buf to mean "shift out zeroes"
> m25p80 build fixes (with MTD debug)
> SPI/MTD: mtd_dataflash oops prevention
>
>David S. Miller (5):
> [SPARC64]: Fix "mem=xxx" handling.
> [SPARC64]: Fix of_iounmap() region release.
> [SPARC64]: Update defconfig.
> [SPARC64]: Handle ISA devices with no 'regs' property.
> [NET]: Add memory barrrier to netif_poll_enable()
>
>David Woodhouse (1):
> [NET]: Don't export linux/random.h outside __KERNEL__.
>
>Dimitri Gorokhovik (2):
> ramfs breaks without CONFIG_BLOCK
> MM: SLOB is broken by recent cleanup of slab.h
>
>Dwaine Garden (1):
> V4L/DVB (4979): Fixes compilation when CONFIG_V4L1_COMPAT is not
> selected
>
>Eric Moore (1):
> MAINTAINERS: email addr change for Eric Moore
>
>Francois Romieu (3):
> netpoll: drivers must not enable IRQ unconditionally in their NAPI
> handler r8169: use the broken_parity_status field in pci_dev
> r8169: extraneous Cmd{Tx/Rx}Enb write
>
>Hans Verkuil (6):
> V4L/DVB (4967): Add missing tuner module option pal=60 for PAL-60
> support. V4L/DVB (4968): Add PAL-60 support for cx2584x.
> V4L/DVB (4982): Fix broken audio mode handling for line-in in
> msp3400. V4L/DVB (4983): Force temporal filter to 0 when scaling to
> prevent ghosting. V4L/DVB (4984): LOG_STATUS should show the real
> temporal filter value. V4L/DVB (4988): Cx2341x audio_properties is an
> u16, not u8
>
>Herbert Xu (1):
> e1000: Do not truncate TSO TCP header with 82544 workaround
>
>Hynek Petrak (1):
> PHY probe not working properly for ibm_emac (PPC4xx)
>
>Ingo Molnar (4):
> change WARN_ON back to "BUG: at ..."
> rcu: rcutorture suspend fix
> sched: fix cond_resched_softirq() offset
> kvm: fix GFP_KERNEL allocation in atomic section in
> kvm_dev_ioctl_create_vcpu()
>
>Jan Andersson (1):
> sparc32: add offset in pci_map_sg()
>
>Jean Delvare (1):
> V4L/DVB (5010): Cx88: Fix leadtek_eeprom tagging
>
>Jeff Garzik (5):
> e1000: For sanity, reformat e1000_set_mac_type(), struct
> e1000_hw[_stats] e1000: omit stats for broken counter in 82543
> e1000: consolidate managability enabling/disabling
> e1000: workaround for the ESB2 NIC RX unit issue
> e1000: 3 new driver stats for managability testing
>
>Jeff Kirsher (1):
> e1000: fix ethtool reported bus type for older adapters
>
>Jesse Brandeburg (7):
> e1000: The user-supplied itr setting needs the lower 2 bits masked
> off e1000: dynamic itr: take TSO and jumbo into account
> e1000: Fix Wake-on-Lan with forced gigabit speed
> e1000: disable TSO on the 82544 with slab debugging
> e1000: narrow down the scope of the tipg timer tweak
> e1000: Make the copybreak value a module parameter
> e1000: No-delay link detection at interface up
>
>Jiri Slaby (2):
> Char: mxser, fix oops when removing opened
> Char: isicom, eliminate spinlock recursion
>
>Judith Lebzelter (1):
> powerpc iseries link error in allmodconfig
>
>KAMEZAWA Hiroyuki (1):
> fix oom killer kills current every time if there is
> memory-less-node take2
>
>Kyungmin Park (2):
> ARM: OMAP: fix GPMC compiler errors
> ARM: OMAP: fix missing header on apollon board
>
>Lennert Buytenhek (1):
> Update CREDITS and MAINTAINERS entries for Lennert Buytenhek
>
>Linus Torvalds (2):
> VM: Fix nasty and subtle race in shared mmap'ed page writeback
> Linux 2.6.20-rc3
>
>Mario Rossi (2):
> V4L/DVB (4955): Fix autosearch index
> V4L/DVB (4956): [NOVA-T-USB2] Put remote-debugging in the right
> place
>
>Mark Fasheh (4):
> ocfs2: don't print error in ocfs2_permission()
> ocfs2: Allow direct I/O read past end of file
> ocfs2: ignore NULL vfsmnt in ocfs2_should_update_atime()
> ocfs2: always unmap in ocfs2_data_convert_worker()
>
>Martin Willi (1):
> [XFRM]: Algorithm lookup using .compat name
>
>Mauro Carvalho Chehab (3):
> V4L/DVB (4960): Removal of unused code from usbvision-i2c.c
> V4L/DVB (4980): Fixes bug 7267: PAL/60 is not working
> V4L/DVB (5001): Add two required headers on kernel 2.6.20-rc1
>
>Melissa Howland (1):
> [S390] Change max. buffer size for monwriter device.
>
>Michael Holzheu (1):
> [S390] cio: fix stsch_reset.
>
>Michael Krufky (1):
> V4L/DVB (4973): Dvb-core: fix printk type warning
>
>Michael S. Tsirkin (1):
> IB/mthca: Fix FMR breakage caused by kmemdup() conversion
>
>Mikael Pettersson (1):
> fix mrproper incompleteness
>
>Mike Frysinger (1):
> respect srctree/objtree in Documentation/DocBook/Makefile
>
>Nguyen Anh Quynh (1):
> KVM: Rename some msrs
>
>Oleg Nesterov (1):
> restore ->pdeath_signal behaviour
>
>Ralf Baechle (1):
> V4L/DVB (4958): Fix namespace conflict between w9968cf.c on MIPS
>
>Randy Dunlap (3):
> via-velocity uses INET interfaces
> pci/probe: fix macro that confuses kernel-doc
> cciss: build with PROC_FS=n
>
>Sebastien Dugué (1):
> Fix IPMI watchdog set_param_str() using kstrdup
>
>Sergei Shtylyov (2):
> PIIX: remove check for broken MW DMA mode 0
> PIIX/SLC90E66: PIO mode fallback fix
>
>Shantanu Goel (1):
> Buglet in vmscan.c
>
>Soeren Sonnenburg (1):
> make fn_keys work again on power/macbooks
>
>Stefan Richter (2):
> ieee1394: sbp2: pass REQUEST_SENSE through to the target
> ieee1394: sbp2: fix bogus dma mapping
>
>Stephan Berberig (1):
> V4L/DVB (4992): Fix typo in saa7134-dvb.c
>
>Stephen Hemminger (4):
> netxen: remove private ioctl
> sky2: dual port NAPI problem
> sky2: power management/MSI workaround
> sky2: phy power down needs PCI config write enabled
>
>Thierry MERLE (1):
> V4L/DVB (4970): Usbvision memory fixes
>
>Thomas Meyer (1):
> Add .gitignore file for relocs in arch/i386
>
>Tilman Schmidt (1):
> Update to Documentation/tty.txt on line disciplines
>
>Ulrich Kunitz (3):
> zd1211rw: Call ieee80211_rx in tasklet
> ieee80211softmac: Fix errors related to the work_struct changes
> ieee80211softmac: Fix mutex_lock at exit of
> ieee80211_softmac_get_genie
>
>Yan Burman (1):
> ep93xx: some minor cleanups to the ep93xx eth driver
>
>Yoshimi Ichiyanagi (1):
> KVM: Initialize kvm_arch_ops on unload
>
>Zach Brown (1):
> Fix lock inversion aio_kick_handler()
>
>Zhen Wei (1):
> ocfs2: export heartbeat thread pid via configfs
>
>audetto@tiscali.it (1):
> V4L/DVB (4964): VIDEO_PALETTE_YUYV and VIDEO_PALETTE_YUV422 are
> the same palette
>
>---
> CREDITS | 7 +-
> Documentation/DocBook/Makefile | 4 +-
> Documentation/filesystems/fuse.txt | 4 +-
> Documentation/tty.txt | 111 +++++++-
> MAINTAINERS | 132 +++++++++-
> Makefile | 4 +-
> arch/arm/mach-omap2/board-apollon.c | 1 +
> arch/arm/mach-omap2/gpmc.c | 21 +-
> arch/i386/boot/compressed/.gitignore | 1 +
> arch/i386/defconfig | 2 +-
> arch/sparc/kernel/ioport.c | 5 +-
> arch/sparc64/defconfig | 36 ++-
> arch/sparc64/kernel/isa.c | 20 +-
> arch/sparc64/kernel/of_device.c | 7 +-
> arch/sparc64/mm/init.c | 147 ++++++++--
> arch/x86_64/defconfig | 2 +-
> drivers/block/cciss.c | 3 +-
> drivers/char/ipmi/ipmi_watchdog.c | 11 +-
> drivers/char/isicom.c | 103 ++++----
> drivers/char/mxser.c | 1 +
> drivers/char/mxser_new.c | 1 +
> drivers/ide/pci/piix.c | 66 ++----
> drivers/ide/pci/slc90e66.c | 20 +-
> drivers/ieee1394/sbp2.c | 83 +++---
> drivers/infiniband/hw/mthca/mthca_provider.c | 3 +-
> drivers/input/serio/i8042-sparcio.h | 6 +-
> drivers/kvm/kvm.h | 18 +-
> drivers/kvm/kvm_main.c | 98 ++++++-
> drivers/kvm/mmu.c | 26 +-
> drivers/kvm/paging_tmpl.h | 4 +-
> drivers/kvm/svm.c | 52 +----
> drivers/kvm/vmx.c | 75 ++----
> drivers/kvm/vmx.h | 10 +-
> drivers/macintosh/via-pmu-backlight.c | 2 +-
> drivers/media/common/ir-functions.c | 1 +
> drivers/media/dvb/dvb-core/dvb_net.c | 4 +-
> drivers/media/dvb/dvb-usb/nova-t-usb2.c | 4 +-
> drivers/media/dvb/frontends/dib3000mc.c | 2 +-
> drivers/media/video/Kconfig | 2 +-
> drivers/media/video/bt8xx/bttv-driver.c | 4 +-
> drivers/media/video/cafe_ccic.c | 2 +-
> drivers/media/video/cpia2/cpia2_usb.c | 4 +
> drivers/media/video/cx2341x.c | 21 +-
> drivers/media/video/cx25840/cx25840-vbi.c | 9 +-
> drivers/media/video/cx88/cx88-cards.c | 2 +-
> drivers/media/video/cx88/cx88-core.c | 35 ++-
> drivers/media/video/cx88/cx88.h | 2 +-
> drivers/media/video/em28xx/em28xx-video.c | 4 +-
> drivers/media/video/meye.c | 4 +-
> drivers/media/video/msp3400-driver.c | 8 +-
> drivers/media/video/msp3400-kthreads.c | 11 +-
> drivers/media/video/saa7134/saa7134-dvb.c | 8 +-
> drivers/media/video/tuner-core.c | 4 +
> drivers/media/video/usbvision/usbvision-cards.c | 11 +-
> drivers/media/video/usbvision/usbvision-core.c | 83 ++----
> drivers/media/video/usbvision/usbvision-i2c.c | 35 +--
> drivers/media/video/usbvision/usbvision-video.c | 150 ++++++----
> drivers/media/video/usbvision/usbvision.h | 27 --
> drivers/media/video/vivi.c | 8 +-
> drivers/media/video/w9966.c | 2 +-
> drivers/media/video/w9968cf.c | 24 +-
> drivers/media/video/zoran_device.c | 3 +-
> drivers/mtd/devices/m25p80.c | 4 +-
> drivers/mtd/devices/mtd_dataflash.c | 2 +-
> drivers/net/8139cp.c | 6 +-
> drivers/net/arm/ep93xx_eth.c | 4 +-
> drivers/net/b44.c | 6 +-
> drivers/net/e1000/e1000_ethtool.c | 3 +
> drivers/net/e1000/e1000_hw.c | 296
> ++++++++++--------- drivers/net/e1000/e1000_hw.h |
> 310 +++++++++++---------- drivers/net/e1000/e1000_main.c
> | 345 ++++++++++++++++------- drivers/net/e1000/e1000_param.c
> | 4 +-
> drivers/net/forcedeth.c | 16 +-
> drivers/net/ibm_emac/ibm_emac_phy.c | 4 +-
> drivers/net/myri10ge/myri10ge.c | 163 +++++------
> drivers/net/netxen/netxen_nic.h | 25 +--
> drivers/net/netxen/netxen_nic_ethtool.c | 5 +-
> drivers/net/netxen/netxen_nic_hw.c | 296
> +------------------- drivers/net/netxen/netxen_nic_init.c |
> 251 +---------------- drivers/net/netxen/netxen_nic_ioctl.h |
> 77 -----
> drivers/net/netxen/netxen_nic_isr.c | 3 +-
> drivers/net/netxen/netxen_nic_main.c | 85 ++-----
> drivers/net/r8169.c | 6 +-
> drivers/net/skge.c | 5 +-
> drivers/net/sky2.c | 35 +++-
> drivers/net/via-velocity.c | 18 +-
> drivers/net/wireless/zd1211rw/zd_mac.c | 96 +++++--
> drivers/net/wireless/zd1211rw/zd_mac.h | 5 +-
> drivers/net/wireless/zd1211rw/zd_usb.c | 4 +-
> drivers/pci/probe.c | 5 +-
> drivers/s390/char/monwriter.c | 2 +-
> drivers/s390/cio/cio.c | 13 +-
> drivers/scsi/ibmvscsi/Makefile | 2 +
> drivers/serial/sunsab.c | 11 +-
> drivers/serial/sunsu.c | 10 +-
> drivers/serial/sunzilog.c | 14 +-
> drivers/spi/spi_mpc83xx.c | 2 +
> drivers/spi/spi_s3c24xx.c | 2 +-
> drivers/spi/spi_s3c24xx_gpio.c | 2 +-
> drivers/usb/input/Kconfig | 2 +-
> drivers/video/bw2.c | 18 +-
> drivers/video/cg14.c | 28 +-
> drivers/video/cg3.c | 22 +-
> drivers/video/cg6.c | 33 ++-
> drivers/video/ffb.c | 25 +-
> drivers/video/leo.c | 29 +-
> drivers/video/p9100.c | 25 +-
> drivers/video/tcx.c | 33 ++-
> fs/aio.c | 7 +-
> fs/ocfs2/aops.c | 24 ++-
> fs/ocfs2/cluster/heartbeat.c | 17 ++
> fs/ocfs2/dlmglue.c | 10 +-
> fs/ocfs2/file.c | 13 +-
> fs/ramfs/file-mmu.c | 4 +-
> fs/ramfs/file-nommu.c | 4 +-
> include/asm-generic/bug.h | 2 +-
> include/asm-sparc/of_device.h | 2 +-
> include/asm-sparc64/of_device.h | 2 +-
> include/linux/cpuset.h | 2 +-
> include/linux/net.h | 2 +-
> include/linux/netdevice.h | 1 +
> include/linux/spi/spi.h | 2 +-
> include/media/cx2341x.h | 2 +-
> include/media/ir-common.h | 1 +
> kernel/cpuset.c | 2 +-
> kernel/exit.c | 8 +-
> kernel/lockdep.c | 8 +-
> kernel/module.c | 4 +-
> kernel/rcutorture.c | 3 +
> kernel/sched.c | 18 +-
> mm/oom_kill.c | 7 +-
> mm/page-writeback.c | 45 +++-
> mm/rmap.c | 2 +-
> mm/slob.c | 11 +-
> mm/vmscan.c | 2 +-
> net/ieee80211/softmac/ieee80211softmac_assoc.c | 4 +-
> net/ieee80211/softmac/ieee80211softmac_wx.c | 2 +-
> net/xfrm/xfrm_algo.c | 3 +-
> 138 files changed, 2077 insertions(+), 2049 deletions(-)
> create mode 100644 arch/i386/boot/compressed/.gitignore
> delete mode 100644 drivers/net/netxen/netxen_nic_ioctl.h
--
Cheers, Gene
"There are four boxes to be used in defense of liberty:
soap, ballot, jury, and ammo. Please use in that order."
-Ed Howdershelt (Author)
Yahoo.com and AOL/TW attorneys please note, additions to the above
message by Gene Heskett are:
Copyright 2006 by Maurice Eugene Heskett, all rights reserved.
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: Happy New Year (and v2.6.20-rc3 released)
2007-01-01 1:19 Happy New Year (and v2.6.20-rc3 released) Linus Torvalds
2007-01-01 1:39 ` Gene Heskett
@ 2007-01-01 2:40 ` Alexey Dobriyan
2007-01-01 7:22 ` Cyrill V. Gorcnov
` (11 subsequent siblings)
13 siblings, 0 replies; 56+ messages in thread
From: Alexey Dobriyan @ 2007-01-01 2:40 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel
On Sun, Dec 31, 2006 at 05:19:44PM -0800, Linus Torvalds wrote:
> Alexey Dobriyan (2):
> V4L/DVB (5012): Usbvision fix: It was using "&&" instead "&"
> fuse: fix typo
Second is from Thomas Hisch <t.hisch@gmail.com>, actually.
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: Happy New Year (and v2.6.20-rc3 released)
2007-01-01 1:19 Happy New Year (and v2.6.20-rc3 released) Linus Torvalds
2007-01-01 1:39 ` Gene Heskett
2007-01-01 2:40 ` Alexey Dobriyan
@ 2007-01-01 7:22 ` Cyrill V. Gorcnov
[not found] ` <4598BC0F.6070003@vc.cvut.cz>
2007-01-02 2:19 ` H. Peter Anvin
2007-01-01 11:29 ` Arkadiusz Miskiewicz
` (10 subsequent siblings)
13 siblings, 2 replies; 56+ messages in thread
From: Cyrill V. Gorcnov @ 2007-01-01 7:22 UTC (permalink / raw)
To: Linus Torvalds, kernel list
On Monday 01 January 2007 04:19, you wrote:
|
| In order to not get in trouble with MADR ("Mothers Against Drunk
| Releases") I decided to cut the 2.6.20-rc3 release early rather than wait
| for midnight, because it's bound to be new years _somewhere_ out there. So
| here's to a happy 2007 for everybody.
|
I've tried to clone linux git repo and got:
git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
fatal: unexpected EOF
fetch-pack from 'git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git' failed.
What's wrong?
Happy New Year ;)
--
- Cyrill
^ permalink raw reply [flat|nested] 56+ messages in thread
[parent not found: <4598BC0F.6070003@vc.cvut.cz>]
* Re: Happy New Year (and v2.6.20-rc3 released)
[not found] ` <4598BC0F.6070003@vc.cvut.cz>
@ 2007-01-01 9:41 ` Cyrill V. Gorcnov
0 siblings, 0 replies; 56+ messages in thread
From: Cyrill V. Gorcnov @ 2007-01-01 9:41 UTC (permalink / raw)
To: Petr Vandrovec, kernel list
On Monday 01 January 2007 10:45, you wrote:
| Cyrill V. Gorcnov wrote:
| > On Monday 01 January 2007 04:19, you wrote:
| > |
| > | In order to not get in trouble with MADR ("Mothers Against Drunk
| > | Releases") I decided to cut the 2.6.20-rc3 release early rather than wait
| > | for midnight, because it's bound to be new years _somewhere_ out there. So
| > | here's to a happy 2007 for everybody.
| > |
| >
| > I've tried to clone linux git repo and got:
| >
| > git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
| > fatal: unexpected EOF
| > fetch-pack from 'git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git' failed.
| >
| > What's wrong?
|
| I think that git does not like year rollover. I've tried it after Linus
| sent message out, and it was not giving me anything new (cca from 5PM
| PST when Linus sent change to 8PM). Then it gave out random changes
| (8PM to 9PM). After that it was dead, as you've noticed. But after
| that I was able to get 2.6.20-rc3 out - compiling now. So perhaps just
| try it again...
| Petr
|
| P.S.: Happy New Year. Here in California we still have 15 minutes of
| year 2006 to go.
|
|
|
Yea, I've got linux git clone later. I think that was some files activity
on git server so that is why I was noticed with "fatal: unexpected EOF" git
message.
--
- Cyrill
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: Happy New Year (and v2.6.20-rc3 released)
2007-01-01 7:22 ` Cyrill V. Gorcnov
[not found] ` <4598BC0F.6070003@vc.cvut.cz>
@ 2007-01-02 2:19 ` H. Peter Anvin
1 sibling, 0 replies; 56+ messages in thread
From: H. Peter Anvin @ 2007-01-02 2:19 UTC (permalink / raw)
To: gorcunov; +Cc: Linus Torvalds, kernel list
Cyrill V. Gorcnov wrote:
> On Monday 01 January 2007 04:19, you wrote:
> |
> | In order to not get in trouble with MADR ("Mothers Against Drunk
> | Releases") I decided to cut the 2.6.20-rc3 release early rather than wait
> | for midnight, because it's bound to be new years _somewhere_ out there. So
> | here's to a happy 2007 for everybody.
> |
>
> I've tried to clone linux git repo and got:
>
> git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
> fatal: unexpected EOF
> fetch-pack from 'git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git' failed.
>
> What's wrong?
>
> Happy New Year ;)
>
Look at http://www.kernel.org/. Currently, the git daemon stops serving
new clients at loadavg 200.
-hpa
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: Happy New Year (and v2.6.20-rc3 released)
2007-01-01 1:19 Happy New Year (and v2.6.20-rc3 released) Linus Torvalds
` (2 preceding siblings ...)
2007-01-01 7:22 ` Cyrill V. Gorcnov
@ 2007-01-01 11:29 ` Arkadiusz Miskiewicz
2007-01-01 13:28 ` Alessandro Suardi
` (9 subsequent siblings)
13 siblings, 0 replies; 56+ messages in thread
From: Arkadiusz Miskiewicz @ 2007-01-01 11:29 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Linux Kernel Mailing List
On Monday 01 January 2007 02:19, Linus Torvalds wrote:
> In order to not get in trouble with MADR ("Mothers Against Drunk
> Releases") I decided to cut the 2.6.20-rc3 release early rather than wait
> for midnight, because it's bound to be new years _somewhere_ out there. So
> here's to a happy 2007 for everybody.
I hope that upcoming gcc 4.2 will be considered as supported compiler before
final 2.6.20 release and patch which broke build is reverted or the thing
fixed :)
MODPOST 1371 modules
WARNING: "_proxy_pda" [fs/fuse/fuse.ko] undefined!
make[1]: *** [__modpost] Błąd 1
+ some other modules which I didn't enable this time
--
Arkadiusz Miśkiewicz PLD/Linux Team
arekm / maven.pl http://ftp.pld-linux.org/
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: Happy New Year (and v2.6.20-rc3 released)
2007-01-01 1:19 Happy New Year (and v2.6.20-rc3 released) Linus Torvalds
` (3 preceding siblings ...)
2007-01-01 11:29 ` Arkadiusz Miskiewicz
@ 2007-01-01 13:28 ` Alessandro Suardi
2007-01-01 20:13 ` Linus Torvalds
2007-01-01 15:52 ` Olaf Hering
` (8 subsequent siblings)
13 siblings, 1 reply; 56+ messages in thread
From: Alessandro Suardi @ 2007-01-01 13:28 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Linux Kernel Mailing List, alan
On 1/1/07, Linus Torvalds <torvalds@osdl.org> wrote:
>
> In order to not get in trouble with MADR ("Mothers Against Drunk
> Releases") I decided to cut the 2.6.20-rc3 release early rather than wait
> for midnight, because it's bound to be new years _somewhere_ out there. So
> here's to a happy 2007 for everybody.
>
> The big thing at least for me personally is that nasty shared mmap
> corruption fix, but there's a number of other changes in here, many of
> them just documentation (and some media and network drivers). Shortlog and
> diffstat appended..
>
> The git trees have been updated, and the tar-tree and patches seem to have
> finisged crawling out my poor DSL connection too.
>
> As usual, mirroring might take a while, although the delay has not been
> all that horrible lately, so it's probably going to be up-to-date by the
> time the hangovers are mostly gone.
>
> At which point the first thing on any self-respecting geek's mind should
> obviously be: "is there a new kernel release for me to try?"
>
> Right?
Right ! And this one is still broken in -rc3:
Subject : kernel panics on boot (libata-sff)
References : http://lkml.org/lkml/2006/12/3/99
http://lkml.org/lkml/2006/12/14/153
http://lkml.org/lkml/2006/12/24/33
Submitter : Alessandro Suardi <alessandro.suardi@gmail.com>
Caused-By : Alan Cox <alan@lxorguk.ukuu.org.uk>
commit 368c73d4f689dae0807d0a2aa74c61fd2b9b075f
Handled-By : Alan Cox <alan@lxorguk.ukuu.org.uk>
Status : people are working on a fix
Happy 2007 everyone,
--alessandro
"...when I get it, I _get_ it"
(Lara Eidemiller)
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: Happy New Year (and v2.6.20-rc3 released)
2007-01-01 13:28 ` Alessandro Suardi
@ 2007-01-01 20:13 ` Linus Torvalds
2007-01-01 20:49 ` Jeff Garzik
2007-01-01 21:26 ` Happy New Year (and v2.6.20-rc3 released) Alan
0 siblings, 2 replies; 56+ messages in thread
From: Linus Torvalds @ 2007-01-01 20:13 UTC (permalink / raw)
To: Alessandro Suardi, Jeff Garzik; +Cc: Linux Kernel Mailing List, alan
Jeff,
what was the resolution to this one? Just revert the offending commit, or
what?
We're about five weeks into the 2.6.20-rc series. I was hoping for a
two-month release rather than the usual dragged-out three months, so I'd
like to get these regressions to be actively fixed. By forcible reverts if
that is what it takes.
Linus
On Mon, 1 Jan 2007, Alessandro Suardi wrote:
>
> Right ! And this one is still broken in -rc3:
>
> Subject : kernel panics on boot (libata-sff)
> References : http://lkml.org/lkml/2006/12/3/99
> http://lkml.org/lkml/2006/12/14/153
> http://lkml.org/lkml/2006/12/24/33
> Submitter : Alessandro Suardi <alessandro.suardi@gmail.com>
> Caused-By : Alan Cox <alan@lxorguk.ukuu.org.uk>
> commit 368c73d4f689dae0807d0a2aa74c61fd2b9b075f
> Handled-By : Alan Cox <alan@lxorguk.ukuu.org.uk>
> Status : people are working on a fix
>
> Happy 2007 everyone,
>
> --alessandro
>
> "...when I get it, I _get_ it"
>
> (Lara Eidemiller)
>
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: Happy New Year (and v2.6.20-rc3 released)
2007-01-01 20:13 ` Linus Torvalds
@ 2007-01-01 20:49 ` Jeff Garzik
2007-01-01 21:31 ` Alan
2007-01-02 11:58 ` [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released)) Alan
2007-01-01 21:26 ` Happy New Year (and v2.6.20-rc3 released) Alan
1 sibling, 2 replies; 56+ messages in thread
From: Jeff Garzik @ 2007-01-01 20:49 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Alessandro Suardi, Linux Kernel Mailing List, alan
Linus Torvalds wrote:
> Jeff,
> what was the resolution to this one? Just revert the offending commit, or
> what?
>
> We're about five weeks into the 2.6.20-rc series. I was hoping for a
> two-month release rather than the usual dragged-out three months, so I'd
> like to get these regressions to be actively fixed. By forcible reverts if
> that is what it takes.
Data points:
* I was unable to argue against Alan's logic behind
368c73d4f689dae0807d0a2aa74c61fd2b9b075f but I just don't like it.
Regardless of whether or not this truly reflects how the PCI device is
wired, it makes pci_request_regions() and similar resource handling code
behave differently.
* Alan's 368c73d4f689dae0807d0a2aa74c61fd2b9b075f change was IMO
incomplete, because he obviously did not fix all the breakage it caused
* Alan proposed a libata fix patch. I noted two key breakages in his
fix patch, one of which Alan agreed was a problem.
* Outside of the two bugfix pushes, I've been actively avoiding
computers during the holidays. It's a shocking concept I'm trying with
the new wife :) Don't expect anything useful from me until Jan 4th or so.
* This affects a lot of Intel ICH platforms in legacy/combined mode, so
it's definitely high on my post-holiday priority list. If the patch is
not reverted, then I'll definitely fix it sooner rather than later.
* For 2.6.21, I proposed to yank out all the ugly combined mode hacks
(grep for '____request_resource'), which should make Alan's change a bit
easier... but nonetheless stirs the IDE quirks code again.
* I am lazy and would rather not touch the fragile ata_pci_init_one()
code now /and/ in 2.6.21.
So I vote for revert, for 2.6.20, but I know Alan will squawk loudly.
Also NOTE thoughfb0f2b40faff41f03acaa2ee6e6231fc96ca497c which fixes
fallout from Alan's change, too.
Jeff
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: Happy New Year (and v2.6.20-rc3 released)
2007-01-01 20:49 ` Jeff Garzik
@ 2007-01-01 21:31 ` Alan
2007-01-01 23:34 ` Linus Torvalds
2007-01-02 11:58 ` [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released)) Alan
1 sibling, 1 reply; 56+ messages in thread
From: Alan @ 2007-01-01 21:31 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Linus Torvalds, Alessandro Suardi, Linux Kernel Mailing List
> * I was unable to argue against Alan's logic behind
> 368c73d4f689dae0807d0a2aa74c61fd2b9b075f but I just don't like it.
> Regardless of whether or not this truly reflects how the PCI device is
> wired, it makes pci_request_regions() and similar resource handling code
> behave differently.
Correctly: The resource tree is no longer corrupt for example and
pci_* resource functions actually now do the right thing. The old code
works by chance due to link order, not because anything was "broken" by
the corrections.
> * Alan proposed a libata fix patch. I noted two key breakages in his
> fix patch, one of which Alan agreed was a problem.
Not a "2.6.20 stopping problem" and trivial to fix further.
> So I vote for revert, for 2.6.20, but I know Alan will squawk loudly.
> Also NOTE thoughfb0f2b40faff41f03acaa2ee6e6231fc96ca497c which fixes
> fallout from Alan's change, too.
I'm very concerned about what that will break that depends upon it - eg
all the work done for suspend/resume PCI handling has not been tested
without the patch. Thus I'd rather fix it given the fix is trivial.
Want a fix Linus given Jeff is away ?
Alan
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: Happy New Year (and v2.6.20-rc3 released)
2007-01-01 21:31 ` Alan
@ 2007-01-01 23:34 ` Linus Torvalds
2007-01-02 2:32 ` Theodore Tso
0 siblings, 1 reply; 56+ messages in thread
From: Linus Torvalds @ 2007-01-01 23:34 UTC (permalink / raw)
To: Alan; +Cc: Jeff Garzik, Alessandro Suardi, Linux Kernel Mailing List
On Mon, 1 Jan 2007, Alan wrote:
>
> Want a fix Linus given Jeff is away ?
Send it over, and please cc Alessandro and others that can test it. Things
obviously aren't broken on _my_ machines ;)
And if we end up having more problems related to this in -rc4, I'll just
revert both your fix and the original one. No hair lost over this one, I
think.
Linus
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: Happy New Year (and v2.6.20-rc3 released)
2007-01-01 23:34 ` Linus Torvalds
@ 2007-01-02 2:32 ` Theodore Tso
0 siblings, 0 replies; 56+ messages in thread
From: Theodore Tso @ 2007-01-02 2:32 UTC (permalink / raw)
To: Linus Torvalds
Cc: Alan, Jeff Garzik, Alessandro Suardi, Linux Kernel Mailing List
On Mon, Jan 01, 2007 at 03:34:53PM -0800, Linus Torvalds wrote:
>
>
> On Mon, 1 Jan 2007, Alan wrote:
> >
> > Want a fix Linus given Jeff is away ?
>
> Send it over, and please cc Alessandro and others that can test it. Things
> obviously aren't broken on _my_ machines ;)
Can I get a copy of the fix for testing as well? I can confirm that
Alan's 368c73d4f689dae0807d0a2aa74c61fd2b9b075f breaks for me on my
T60 thinkpad. Unfortunately I missed the earlier discussion on this,
and I didn't have time to test -rc1 and -rc2, so I spent a few hours
doing the git bisection in order to determine that it was Alan's
2b9b075f patch which was breaking -rc3 for me.
My current plan for testing -rc3 was to back out Alan's patch
(attached below for others' convenience), but I'm happy to test an
alternative fix.
- Ted
Revert "PCI: quirks: fix the festering mess that claims to handle IDE quirks"
This reverts commit 368c73d4f689dae0807d0a2aa74c61fd2b9b075f.
This is needed to fix booting on a Thinkpad T60. Without this patch,
we see the following error messages, and the SATA drive in the laptop
isn't detected, with the following messages printed during the boot
sequence:
ata_piix 0000:00:1f.2: MAP [ P0 P2 IDE IDE ]
ACPI: PCI Interrupt 0000:00:1f.2[B] -> GSI 16 (level, low) -> IRQ 16
PCI: Unable to reserve I/O Region #1:8@1f0 for device 0000:00:1f.2
ata_piix: probe of 0000:00:1f.2 failed with error -16
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
arch/i386/pci/fixup.c | 46 ++++++++++++++++++++++++++++++++++++++
drivers/pci/probe.c | 27 ----------------------
drivers/pci/quirks.c | 59 ++++++++++++++++++++++++++++++++++++++++++++++--
3 files changed, 102 insertions(+), 30 deletions(-)
diff --git a/arch/i386/pci/fixup.c b/arch/i386/pci/fixup.c
index 8053b17..422483e 100644
--- a/arch/i386/pci/fixup.c
+++ b/arch/i386/pci/fixup.c
@@ -74,6 +74,52 @@ static void __devinit pci_fixup_ncr53c810(struct pci_dev *d)
}
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_NCR, PCI_DEVICE_ID_NCR_53C810, pci_fixup_ncr53c810);
+static void __devinit pci_fixup_ide_bases(struct pci_dev *d)
+{
+ int i;
+
+ /*
+ * PCI IDE controllers use non-standard I/O port decoding, respect it.
+ */
+ if ((d->class >> 8) != PCI_CLASS_STORAGE_IDE)
+ return;
+ DBG("PCI: IDE base address fixup for %s\n", pci_name(d));
+ for(i=0; i<4; i++) {
+ struct resource *r = &d->resource[i];
+ if ((r->start & ~0x80) == 0x374) {
+ r->start |= 2;
+ r->end = r->start;
+ }
+ }
+}
+DECLARE_PCI_FIXUP_HEADER(PCI_ANY_ID, PCI_ANY_ID, pci_fixup_ide_bases);
+
+static void __devinit pci_fixup_ide_trash(struct pci_dev *d)
+{
+ int i;
+
+ /*
+ * Runs the fixup only for the first IDE controller
+ * (Shai Fultheim - shai@ftcon.com)
+ */
+ static int called = 0;
+ if (called)
+ return;
+ called = 1;
+
+ /*
+ * There exist PCI IDE controllers which have utter garbage
+ * in first four base registers. Ignore that.
+ */
+ DBG("PCI: IDE base address trash cleared for %s\n", pci_name(d));
+ for(i=0; i<4; i++)
+ d->resource[i].start = d->resource[i].end = d->resource[i].flags = 0;
+}
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SI, PCI_DEVICE_ID_SI_5513, pci_fixup_ide_trash);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801CA_10, pci_fixup_ide_trash);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801CA_11, pci_fixup_ide_trash);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801DB_9, pci_fixup_ide_trash);
+
static void __devinit pci_fixup_latency(struct pci_dev *d)
{
/*
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 0e0401d..8e077b1 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -681,33 +681,6 @@ static int pci_setup_device(struct pci_dev * dev)
pci_read_bases(dev, 6, PCI_ROM_ADDRESS);
pci_read_config_word(dev, PCI_SUBSYSTEM_VENDOR_ID, &dev->subsystem_vendor);
pci_read_config_word(dev, PCI_SUBSYSTEM_ID, &dev->subsystem_device);
-
- /*
- * Do the ugly legacy mode stuff here rather than broken chip
- * quirk code. Legacy mode ATA controllers have fixed
- * addresses. These are not always echoed in BAR0-3, and
- * BAR0-3 in a few cases contain junk!
- */
- if (class == PCI_CLASS_STORAGE_IDE) {
- u8 progif;
- pci_read_config_byte(dev, PCI_CLASS_PROG, &progif);
- if ((progif & 1) == 0) {
- dev->resource[0].start = 0x1F0;
- dev->resource[0].end = 0x1F7;
- dev->resource[0].flags = LEGACY_IO_RESOURCE;
- dev->resource[1].start = 0x3F6;
- dev->resource[1].end = 0x3F6;
- dev->resource[1].flags = LEGACY_IO_RESOURCE;
- }
- if ((progif & 4) == 0) {
- dev->resource[2].start = 0x170;
- dev->resource[2].end = 0x177;
- dev->resource[2].flags = LEGACY_IO_RESOURCE;
- dev->resource[3].start = 0x376;
- dev->resource[3].end = 0x376;
- dev->resource[3].flags = LEGACY_IO_RESOURCE;
- }
- }
break;
case PCI_HEADER_TYPE_BRIDGE: /* bridge header */
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 8f0322d..d6c4130 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -827,6 +827,56 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_CYRIX, PCI_DEVICE_ID_CYRIX_PCI_MASTER, qui
DECLARE_PCI_FIXUP_RESUME(PCI_VENDOR_ID_CYRIX, PCI_DEVICE_ID_CYRIX_PCI_MASTER, quirk_mediagx_master );
/*
+ * As per PCI spec, ignore base address registers 0-3 of the IDE controllers
+ * running in Compatible mode (bits 0 and 2 in the ProgIf for primary and
+ * secondary channels respectively). If the device reports Compatible mode
+ * but does use BAR0-3 for address decoding, we assume that firmware has
+ * programmed these BARs with standard values (0x1f0,0x3f4 and 0x170,0x374).
+ * Exceptions (if they exist) must be handled in chip/architecture specific
+ * fixups.
+ *
+ * Note: for non x86 people. You may need an arch specific quirk to handle
+ * moving IDE devices to native mode as well. Some plug in card devices power
+ * up in compatible mode and assume the BIOS will adjust them.
+ *
+ * Q: should we load the 0x1f0,0x3f4 into the registers or zap them as
+ * we do now ? We don't want is pci_enable_device to come along
+ * and assign new resources. Both approaches work for that.
+ */
+static void __devinit quirk_ide_bases(struct pci_dev *dev)
+{
+ struct resource *res;
+ int first_bar = 2, last_bar = 0;
+
+ if ((dev->class >> 8) != PCI_CLASS_STORAGE_IDE)
+ return;
+
+ res = &dev->resource[0];
+
+ /* primary channel: ProgIf bit 0, BAR0, BAR1 */
+ if (!(dev->class & 1) && (res[0].flags || res[1].flags)) {
+ res[0].start = res[0].end = res[0].flags = 0;
+ res[1].start = res[1].end = res[1].flags = 0;
+ first_bar = 0;
+ last_bar = 1;
+ }
+
+ /* secondary channel: ProgIf bit 2, BAR2, BAR3 */
+ if (!(dev->class & 4) && (res[2].flags || res[3].flags)) {
+ res[2].start = res[2].end = res[2].flags = 0;
+ res[3].start = res[3].end = res[3].flags = 0;
+ last_bar = 3;
+ }
+
+ if (!last_bar)
+ return;
+
+ printk(KERN_INFO "PCI: Ignoring BAR%d-%d of IDE controller %s\n",
+ first_bar, last_bar, pci_name(dev));
+}
+DECLARE_PCI_FIXUP_HEADER(PCI_ANY_ID, PCI_ANY_ID, quirk_ide_bases);
+
+/*
* Ensure C0 rev restreaming is off. This is normally done by
* the BIOS but in the odd case it is not the results are corruption
* hence the presence of a Linux check
@@ -878,10 +928,11 @@ static void __devinit quirk_svwks_csb5ide(struct pci_dev *pdev)
prog &= ~5;
pdev->class &= ~5;
pci_write_config_byte(pdev, PCI_CLASS_PROG, prog);
- /* PCI layer will sort out resources */
+ /* need to re-assign BARs for compat mode */
+ quirk_ide_bases(pdev);
}
}
-DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_CSB5IDE, quirk_svwks_csb5ide );
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_CSB5IDE, quirk_svwks_csb5ide );
/*
* Intel 82801CAM ICH3-M datasheet says IDE modes must be the same
@@ -897,9 +948,11 @@ static void __init quirk_ide_samemode(struct pci_dev *pdev)
prog &= ~5;
pdev->class &= ~5;
pci_write_config_byte(pdev, PCI_CLASS_PROG, prog);
+ /* need to re-assign BARs for compat mode */
+ quirk_ide_bases(pdev);
}
}
-DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801CA_10, quirk_ide_samemode);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801CA_10, quirk_ide_samemode);
/* This was originally an Alpha specific thing, but it really fits here.
* The i82375 PCI/EISA bridge appears as non-classified. Fix that.
--
1.5.0.rc0.g1d42
^ permalink raw reply related [flat|nested] 56+ messages in thread
* [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
2007-01-01 20:49 ` Jeff Garzik
2007-01-01 21:31 ` Alan
@ 2007-01-02 11:58 ` Alan
2007-01-02 12:07 ` Alessandro Suardi
` (3 more replies)
1 sibling, 4 replies; 56+ messages in thread
From: Alan @ 2007-01-02 11:58 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Linus Torvalds, Alessandro Suardi, Linux Kernel Mailing List
This is a slight variant on the patch I posted December 16th to fix
libata combined mode handling. The only real change is that we now
correctly also reserve BAR1,2,4. That is basically a neatness issue.
Jeff was unhappy about two things
1. That it didn't work in the case of one channel native one channel
legacy.
This is a silly complaint because the SFF layer in libata doesn't handle
this case yet anyway.
2. The case where combined mode is in use and IDE=n.
In this case the libata quirk code reserves the resources in question
correctly already.
Once the combined mode stuff is redone properly (2.6.21) then the entire
mess turns into a single pci_request_regions() for all cases and all the
ugly resource hackery goes away.
I'm sending this now rather than after running full test suites so that
it can get the maximal testing in a short time. I'll be running tests on
this after lunch.
Signed-off-by: Alan Cox <alan@redhat.com>
--- linux.vanilla-2.6.20-rc3/drivers/ata/libata-sff.c 2007-01-01 21:43:27.000000000 +0000
+++ linux-2.6.20-rc3/drivers/ata/libata-sff.c 2007-01-02 11:15:53.000000000 +0000
@@ -1027,13 +1027,15 @@
#endif
}
- rc = pci_request_regions(pdev, DRV_NAME);
- if (rc) {
- disable_dev_on_err = 0;
- goto err_out;
- }
-
- if (legacy_mode) {
+ if (!legacy_mode) {
+ rc = pci_request_regions(pdev, DRV_NAME);
+ if (rc) {
+ disable_dev_on_err = 0;
+ goto err_out;
+ }
+ } else {
+ /* Deal with combined mode hack. This side of the logic all
+ goes away once the combined mode hack is killed in 2.6.21 */
if (!request_region(ATA_PRIMARY_CMD, 8, "libata")) {
struct resource *conflict, res;
res.start = ATA_PRIMARY_CMD;
@@ -1071,6 +1073,13 @@
}
} else
legacy_mode |= ATA_PORT_SECONDARY;
+
+ if (legacy_mode & ATA_PORT_PRIMARY)
+ pci_request_region(pdev, 1, DRV_NAME);
+ if (legacy_mode & ATA_PORT_SECONDARY)
+ pci_request_region(pdev, 3, DRV_NAME);
+ /* If there is a DMA resource, allocate it */
+ pci_request_region(pdev, 4, DRV_NAME);
}
/* we have legacy mode, but all ports are unavailable */
@@ -1114,11 +1123,20 @@
err_out_ent:
kfree(probe_ent);
err_out_regions:
- if (legacy_mode & ATA_PORT_PRIMARY)
- release_region(ATA_PRIMARY_CMD, 8);
- if (legacy_mode & ATA_PORT_SECONDARY)
- release_region(ATA_SECONDARY_CMD, 8);
- pci_release_regions(pdev);
+ /* All this conditional stuff is needed for the combined mode hack
+ until 2.6.21 when it can go */
+ if (legacy_mode) {
+ pci_release_region(pdev, 4);
+ if (legacy_mode & ATA_PORT_PRIMARY) {
+ release_region(ATA_PRIMARY_CMD, 8);
+ pci_release_region(pdev, 1);
+ }
+ if (legacy_mode & ATA_PORT_SECONDARY) {
+ release_region(ATA_SECONDARY_CMD, 8);
+ pci_release_region(pdev, 3);
+ }
+ } else
+ pci_release_regions(pdev);
err_out:
if (disable_dev_on_err)
pci_disable_device(pdev);
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
2007-01-02 11:58 ` [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released)) Alan
@ 2007-01-02 12:07 ` Alessandro Suardi
2007-01-02 14:00 ` Alan
2007-01-02 16:12 ` Theodore Tso
` (2 subsequent siblings)
3 siblings, 1 reply; 56+ messages in thread
From: Alessandro Suardi @ 2007-01-02 12:07 UTC (permalink / raw)
To: Alan; +Cc: Jeff Garzik, Linus Torvalds, Linux Kernel Mailing List
On 1/2/07, Alan <alan@lxorguk.ukuu.org.uk> wrote:
> This is a slight variant on the patch I posted December 16th to fix
> libata combined mode handling. The only real change is that we now
> correctly also reserve BAR1,2,4. That is basically a neatness issue.
>
> Jeff was unhappy about two things
>
> 1. That it didn't work in the case of one channel native one channel
> legacy.
>
> This is a silly complaint because the SFF layer in libata doesn't handle
> this case yet anyway.
>
> 2. The case where combined mode is in use and IDE=n.
>
> In this case the libata quirk code reserves the resources in question
> correctly already.
>
> Once the combined mode stuff is redone properly (2.6.21) then the entire
> mess turns into a single pci_request_regions() for all cases and all the
> ugly resource hackery goes away.
>
> I'm sending this now rather than after running full test suites so that
> it can get the maximal testing in a short time. I'll be running tests on
> this after lunch.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> --- linux.vanilla-2.6.20-rc3/drivers/ata/libata-sff.c 2007-01-01 21:43:27.000000000 +0000
> +++ linux-2.6.20-rc3/drivers/ata/libata-sff.c 2007-01-02 11:15:53.000000000 +0000
> @@ -1027,13 +1027,15 @@
> #endif
> }
>
> - rc = pci_request_regions(pdev, DRV_NAME);
> - if (rc) {
> - disable_dev_on_err = 0;
> - goto err_out;
> - }
> -
> - if (legacy_mode) {
> + if (!legacy_mode) {
> + rc = pci_request_regions(pdev, DRV_NAME);
> + if (rc) {
> + disable_dev_on_err = 0;
> + goto err_out;
> + }
> + } else {
> + /* Deal with combined mode hack. This side of the logic all
> + goes away once the combined mode hack is killed in 2.6.21 */
> if (!request_region(ATA_PRIMARY_CMD, 8, "libata")) {
> struct resource *conflict, res;
> res.start = ATA_PRIMARY_CMD;
> @@ -1071,6 +1073,13 @@
> }
> } else
> legacy_mode |= ATA_PORT_SECONDARY;
> +
> + if (legacy_mode & ATA_PORT_PRIMARY)
> + pci_request_region(pdev, 1, DRV_NAME);
> + if (legacy_mode & ATA_PORT_SECONDARY)
> + pci_request_region(pdev, 3, DRV_NAME);
> + /* If there is a DMA resource, allocate it */
> + pci_request_region(pdev, 4, DRV_NAME);
> }
>
> /* we have legacy mode, but all ports are unavailable */
> @@ -1114,11 +1123,20 @@
> err_out_ent:
> kfree(probe_ent);
> err_out_regions:
> - if (legacy_mode & ATA_PORT_PRIMARY)
> - release_region(ATA_PRIMARY_CMD, 8);
> - if (legacy_mode & ATA_PORT_SECONDARY)
> - release_region(ATA_SECONDARY_CMD, 8);
> - pci_release_regions(pdev);
> + /* All this conditional stuff is needed for the combined mode hack
> + until 2.6.21 when it can go */
> + if (legacy_mode) {
> + pci_release_region(pdev, 4);
> + if (legacy_mode & ATA_PORT_PRIMARY) {
> + release_region(ATA_PRIMARY_CMD, 8);
> + pci_release_region(pdev, 1);
> + }
> + if (legacy_mode & ATA_PORT_SECONDARY) {
> + release_region(ATA_SECONDARY_CMD, 8);
> + pci_release_region(pdev, 3);
> + }
> + } else
> + pci_release_regions(pdev);
> err_out:
> if (disable_dev_on_err)
> pci_disable_device(pdev);
>
Appears to work just fine here (compiles, boots and I'm
typing this email :). The build warnings below seem new
to me - but I guess they're harmless...
CC drivers/ata/libata-sff.o
drivers/ata/libata-sff.c: In function 'ata_pci_init_one':
drivers/ata/libata-sff.c:1078: warning: ignoring return value of
'pci_request_region', declared with attribute warn_unused_result
drivers/ata/libata-sff.c:1080: warning: ignoring return value of
'pci_request_region', declared with attribute warn_unused_result
drivers/ata/libata-sff.c:1082: warning: ignoring return value of
'pci_request_region', declared with attribute warn_unused_result
Thanks, ciao,
--alessandro
"but I thought that I should let you know
the things that I don't always show
might not be worth the time it took"
(Steve Wynn, 'If My Life Was An Open Book')
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
2007-01-02 11:58 ` [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released)) Alan
2007-01-02 12:07 ` Alessandro Suardi
@ 2007-01-02 16:12 ` Theodore Tso
2007-01-02 21:00 ` Jeff Garzik
2007-01-03 19:59 ` Steve Wise
3 siblings, 0 replies; 56+ messages in thread
From: Theodore Tso @ 2007-01-02 16:12 UTC (permalink / raw)
To: Alan
Cc: Jeff Garzik, Linus Torvalds, Alessandro Suardi,
Linux Kernel Mailing List
On Tue, Jan 02, 2007 at 11:58:34AM +0000, Alan wrote:
> This is a slight variant on the patch I posted December 16th to fix
> libata combined mode handling. The only real change is that we now
> correctly also reserve BAR1,2,4. That is basically a neatness issue.
Thanks,
I can confirm that with this patch applied, I can boot 2.6.20-rc3 on
my Thinkpad T60p. My primary laptop is now running the with the
patch, and I'll start pushing it through its paces. If start losing
any files or seeing any disk corruption I'll let folks now.
- Ted
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
2007-01-02 11:58 ` [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released)) Alan
2007-01-02 12:07 ` Alessandro Suardi
2007-01-02 16:12 ` Theodore Tso
@ 2007-01-02 21:00 ` Jeff Garzik
2007-01-02 21:27 ` Alan
2007-01-03 19:59 ` Steve Wise
3 siblings, 1 reply; 56+ messages in thread
From: Jeff Garzik @ 2007-01-02 21:00 UTC (permalink / raw)
To: Alan, Linus Torvalds; +Cc: Alessandro Suardi, Linux Kernel Mailing List
Alan wrote:
> This is a slight variant on the patch I posted December 16th to fix
> libata combined mode handling. The only real change is that we now
> correctly also reserve BAR1,2,4. That is basically a neatness issue.
>
> Jeff was unhappy about two things
>
> 1. That it didn't work in the case of one channel native one channel
> legacy.
> This is a silly complaint because the SFF layer in libata doesn't handle
> this case yet anyway.
Yes, it's "silly" people people use configurations you find inconvenient.
At least one embedded x86 case cares, that I know of. They only needed
to make two minor changes to make it work.
> 2. The case where combined mode is in use and IDE=n.
> In this case the libata quirk code reserves the resources in question
> correctly already.
Not /all/ the resources. And YOU were the person harping me about
acquiring all resources, so that even races no one cares about[1] are
avoided.
But those two items were just from my five-minute, on-vacation review.
Obvious bug #3:
The code no long reserves resources for the "extra" PCI BAR that often
exists on PCI controllers regardless of legacy/native mode. Previously,
the code called pci_request_regions() to reserve ALL regions attached to
the PCI device.
You have suddenly decided that it's OK to --not reserve at all-- these
additional regions.
Proof: The AHCI PCI BAR (#5, zero-based) is clearly NOT reserved, even
though we talk to it, in piix_disable_ahci() of ata_piix.c.
Jeff
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
2007-01-02 21:00 ` Jeff Garzik
@ 2007-01-02 21:27 ` Alan
2007-01-02 21:29 ` Jeff Garzik
0 siblings, 1 reply; 56+ messages in thread
From: Alan @ 2007-01-02 21:27 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Linus Torvalds, Alessandro Suardi, Linux Kernel Mailing List
> > This is a silly complaint because the SFF layer in libata doesn't handle
> > this case yet anyway.
>
> Yes, it's "silly" people people use configurations you find inconvenient.
>
> At least one embedded x86 case cares, that I know of. They only needed
> to make two minor changes to make it work.
*It is not part of 2.6.20*
> The code no long reserves resources for the "extra" PCI BAR that often
> exists on PCI controllers regardless of legacy/native mode. Previously,
> the code called pci_request_regions() to reserve ALL regions attached to
> the PCI device.
We use BAR5 on two devices in legacy mode. Both of those reserve all the
other resources. We can fix BAR5 in .21 when all the combined mode crap
goes away.
> You have suddenly decided that it's OK to --not reserve at all-- these
> additional regions.
It's not ideal - but it is perfectly sufficient for 2.6.20
> Proof: The AHCI PCI BAR (#5, zero-based) is clearly NOT reserved, even
> though we talk to it, in piix_disable_ahci() of ata_piix.c.
We always claim the other BARs so catch a collision.
Alan
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
2007-01-02 21:27 ` Alan
@ 2007-01-02 21:29 ` Jeff Garzik
2007-01-02 21:32 ` Jeff Garzik
2007-01-02 22:45 ` Alan
0 siblings, 2 replies; 56+ messages in thread
From: Jeff Garzik @ 2007-01-02 21:29 UTC (permalink / raw)
To: Alan; +Cc: Linus Torvalds, Alessandro Suardi, Linux Kernel Mailing List
Alan wrote:
>>> This is a silly complaint because the SFF layer in libata doesn't handle
>>> this case yet anyway.
>> Yes, it's "silly" people people use configurations you find inconvenient.
>>
>> At least one embedded x86 case cares, that I know of. They only needed
>> to make two minor changes to make it work.
>
> *It is not part of 2.6.20*
>
>> The code no long reserves resources for the "extra" PCI BAR that often
>> exists on PCI controllers regardless of legacy/native mode. Previously,
>> the code called pci_request_regions() to reserve ALL regions attached to
>> the PCI device.
>
> We use BAR5 on two devices in legacy mode. Both of those reserve all the
> other resources.
Translation: You want to hand-wave away an obvious regression that YOU
have created with your fix-to-a-fix.
> We can fix BAR5 in .21 when all the combined mode crap
> goes away.
Translation: Problems disappear in 2.6.21 because Jeff will revert the
code I touched to its previous state -- always calling
pci_request_regions() -- and all the problems I introduced by avoiding
pci_request_regions() will go away.
Why INTRODUCE these 2.6.20 Alan-isms, if they are going away in 2.6.21?
>> You have suddenly decided that it's OK to --not reserve at all-- these
>> additional regions.
>
> It's not ideal - but it is perfectly sufficient for 2.6.20
>
>> Proof: The AHCI PCI BAR (#5, zero-based) is clearly NOT reserved, even
>> though we talk to it, in piix_disable_ahci() of ata_piix.c.
>
> We always claim the other BARs so catch a collision.
Where? AFAICS, it is crystal clear the behavior:
* Prior to your patch, ata_piix in legacy mode calls
pci_request_regions() to intentionally reserve ALL regions on the PCI
device.
* After your patch, the code explicitly calls pci_request_region() for
BARs 0-4, but never for BAR5.
Another driver is now free to claim a PCI BAR, and start running the
hardware in AHCI mode, whee!
Jeff
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
2007-01-02 21:29 ` Jeff Garzik
@ 2007-01-02 21:32 ` Jeff Garzik
2007-01-02 22:48 ` Alan
2007-01-02 22:45 ` Alan
1 sibling, 1 reply; 56+ messages in thread
From: Jeff Garzik @ 2007-01-02 21:32 UTC (permalink / raw)
To: Alan, Linus Torvalds; +Cc: Alessandro Suardi, Linux Kernel Mailing List
Jeff Garzik wrote:
> * After your patch, the code explicitly calls pci_request_region() for
> BARs 0-4, but never for BAR5.
Without checking for failures, I might add.
Let's call that regression/obvious bug #4, because the previous code
actually CARED if the resource was reserved.
> if (legacy_mode & ATA_PORT_PRIMARY)
> pci_request_region(pdev, 1, DRV_NAME);
> if (legacy_mode & ATA_PORT_SECONDARY)
> pci_request_region(pdev, 3, DRV_NAME);
> /* If there is a DMA resource, allocate it */
> pci_request_region(pdev, 4, DRV_NAME);
I agree this is one way to avoid conflicts! ;-)
Jeff
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
2007-01-02 21:32 ` Jeff Garzik
@ 2007-01-02 22:48 ` Alan
0 siblings, 0 replies; 56+ messages in thread
From: Alan @ 2007-01-02 22:48 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Linus Torvalds, Alessandro Suardi, Linux Kernel Mailing List
On Tue, 02 Jan 2007 16:32:01 -0500
Jeff Garzik <jeff@garzik.org> wrote:
> Jeff Garzik wrote:
> > * After your patch, the code explicitly calls pci_request_region() for
> > BARs 0-4, but never for BAR5.
>
> Without checking for failures, I might add.
The old code didn't reserve 1 or 3 at all let alone check them!
> I agree this is one way to avoid conflicts! ;-)
I did actually go through and verify that there are no drivers where this
would cause a problem including reading some of the painful crap in
drivers/ide to double check.
Is it perfection - no, does it fix 2.6.20 - yes, is it causing any
problems for a 2.6.21 roadmap - no.
Alan
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
2007-01-02 21:29 ` Jeff Garzik
2007-01-02 21:32 ` Jeff Garzik
@ 2007-01-02 22:45 ` Alan
2007-01-02 23:01 ` Jeff Garzik
2007-01-02 23:04 ` Jeff Garzik
1 sibling, 2 replies; 56+ messages in thread
From: Alan @ 2007-01-02 22:45 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Linus Torvalds, Alessandro Suardi, Linux Kernel Mailing List
> > We use BAR5 on two devices in legacy mode. Both of those reserve all the
> > other resources.
>
> Translation: You want to hand-wave away an obvious regression that YOU
> have created with your fix-to-a-fix.
It's not regressing anything.
> Why INTRODUCE these 2.6.20 Alan-isms, if they are going away in 2.6.21?
To fix the problem I introduced ? and because that patch to do so is
trivial and easy to test and verify.
> * Prior to your patch, ata_piix in legacy mode calls
> pci_request_regions() to intentionally reserve ALL regions on the PCI
> device.
Actually it didn't reserve BAR1 and BAR3 in legacy mode precisely because
of the PCI resource mismanagement in the old tree. So you take your pick.
BAR1 and BAR3 were used on all devices and not reserved, BAR5 is used on
two. Neither case is actually a problem in the current tree and driver
set. Both will be fixed when the combined mode junk gets fired into
hyperspace.
Alan
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
2007-01-02 22:45 ` Alan
@ 2007-01-02 23:01 ` Jeff Garzik
2007-01-02 23:27 ` Alan
2007-01-02 23:04 ` Jeff Garzik
1 sibling, 1 reply; 56+ messages in thread
From: Jeff Garzik @ 2007-01-02 23:01 UTC (permalink / raw)
To: Alan; +Cc: Linus Torvalds, Alessandro Suardi, Linux Kernel Mailing List
Alan wrote:
>>> We use BAR5 on two devices in legacy mode. Both of those reserve all the
>>> other resources.
>> Translation: You want to hand-wave away an obvious regression that YOU
>> have created with your fix-to-a-fix.
>
> It's not regressing anything.
False:
2.6.0 - 2.6.19: libata guarantees that all PCI BARs are reserved to the
libata driver.
2.6.20: no guarantee that all PCI BARs are reserved to libata driver.
Real-life ata_piix example already provided, where a PCI BAR is no
longer reserved to the driver.
2.6.21 - infinity: libata guarantees that all PCI BARs are reserved to
the driver.
Jeff
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
2007-01-02 23:01 ` Jeff Garzik
@ 2007-01-02 23:27 ` Alan
2007-01-02 23:43 ` Jeff Garzik
2007-01-02 23:54 ` Jeff Garzik
0 siblings, 2 replies; 56+ messages in thread
From: Alan @ 2007-01-02 23:27 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Linus Torvalds, Alessandro Suardi, Linux Kernel Mailing List
> 2.6.0 - 2.6.19: libata guarantees that all PCI BARs are reserved to the
> libata driver.
Please read the code Jeff. The old IDE quirk code in the PCI layer blanked
BAR 0 to BAR 3 of a compatibility mode controller
You then request_region 0x1f0 and 0x170 (BAR 0 and BAR 2) directly. You
never request the legacy BAR 1 and BAR 3 because they were erased by the
PCI quirk code and thus never claim the other port. Thats been a bug since
day one but it never seemed worth fixing in the short term.
Alan
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
2007-01-02 23:27 ` Alan
@ 2007-01-02 23:43 ` Jeff Garzik
2007-01-03 0:36 ` Alan
2007-01-02 23:54 ` Jeff Garzik
1 sibling, 1 reply; 56+ messages in thread
From: Jeff Garzik @ 2007-01-02 23:43 UTC (permalink / raw)
To: Alan; +Cc: Linus Torvalds, Alessandro Suardi, Linux Kernel Mailing List
Alan wrote:
>> 2.6.0 - 2.6.19: libata guarantees that all PCI BARs are reserved to the
>> libata driver.
>
> Please read the code Jeff. The old IDE quirk code in the PCI layer blanked
> BAR 0 to BAR 3 of a compatibility mode controller
(a) I'm well of aware of this, and (b) that changes nothing.
I said "PCI BARs" for a reason. libata was written according to the
following model:
1) Programmatically reserve /all/ resources associated with
our PCI device
2) Manually reserve resources associated with our PCI device,
but are not listed in struct pci_dev.
You have changed this to:
1) Manually reserve /some/ resources associated with PCI device
2) Manually reserve resources associated with our PCI device,
but are not listed in struct pci_dev.
But then 2.6.21 goes back to:
1) Programmatically reserve /all/ resources associated with
our PCI device
2) Manually reserve resources associated with our PCI device,
but are not listed in struct pci_dev.
Maybe I can say it more clearly by telling you how to fix the regression
you have introduced: Loop through all BAR resources in struct pci_dev,
and reserve them if they are not already reserved by libata earlier in
the code. There. Regression fixed.
(but then we rewrite this code again in 2.6.21)
> You then request_region 0x1f0 and 0x170 (BAR 0 and BAR 2) directly. You
> never request the legacy BAR 1 and BAR 3 because they were erased by the
> PCI quirk code and thus never claim the other port. Thats been a bug since
> day one but it never seemed worth fixing in the short term.
Yes -- that's a bug, one that existed prior to the "it doesn't boot"
combined mode regression everybody complained about. I'm talking about
a new regression just introduced via
dc3c3377f03634d351fafdfe35b237b283586c04, not a old bug that existed
prior to the regression introduced in
368c73d4f689dae0807d0a2aa74c61fd2b9b075f.
Jeff
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
2007-01-02 23:43 ` Jeff Garzik
@ 2007-01-03 0:36 ` Alan
2007-01-03 1:02 ` Jeff Garzik
0 siblings, 1 reply; 56+ messages in thread
From: Alan @ 2007-01-03 0:36 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Linus Torvalds, Alessandro Suardi, Linux Kernel Mailing List
> 1) Programmatically reserve /all/ resources associated with
> our PCI device
> 2) Manually reserve resources associated with our PCI device,
> but are not listed in struct pci_dev.
Which it doesn't actually do. You reserve 0x1F0-0x1F7 but forget the
other register. BTW on unload you forget to release 0x1F0-7 too. I've not
fixed that as its not a regression just a bug. It's just another symptom
of a pile of code trying to do things the wrong way, in the wrong place.
> But then 2.6.21 goes back to:
>
> 1) Programmatically reserve /all/ resources associated with
> our PCI device
> 2) Manually reserve resources associated with our PCI device,
> but are not listed in struct pci_dev.
Nope. You are either very confused about how PCI bus resources work or
you are trying to implement the future code in a very very peculiar way 8)
Remember with the resource tree now correct all the resources for an IDE
controller *are* in the pci_dev struct properly - the special cases are
all gone in libata and in drivers/ide.
Once combined mode is fixed not to abuse resources (and it originally
did it that way for a good reason I grant and am not criticising that) the
entire management for legacy mode, mixed mode and native mode resources
for an ATA device (including 0x170, 0x3F6 and other wacky magic) becomes
if (pci_request_regions(pdev, "libata")) ...
You'll note:
- No special cases for differing modes
- No libata knowledge of PCI legacy mapping rules and addresses
- The death of the magic ATA_PRIMARY/SECONDARY constants and their magic
numbers
- Support for platforms that map legacy space differently
- Trivial cleanup from failure unlike the current code
all in one line. This will also fix all the existing bugs where unloading
a libata driver fails to free resources as pci_release_regions() will also
now do the correct thing.
*That* is one key reason why getting the PCI resource map right is so
important. We turn fifty lines of bug ridden hard to debug code into one
line of code that actually does more than the original, and gets it
right. For free we get the leaked resources after rmmod fixed, we get the
mixed mode resources fixed, we get all this stuff for free. We get to
shoot a chunk of code in drivers/ide if we want as well.
If we want to keep a combined mode in 2.6.21 with drivers/ide (which
seems dumb as libata has progressed far beyond the need for it) then the
-mm tree has a pci_request_regions_mask() function which we can push
to .21 development and we end up with five lines not three for these
cases.
Make sense ?
Alan
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
2007-01-03 0:36 ` Alan
@ 2007-01-03 1:02 ` Jeff Garzik
0 siblings, 0 replies; 56+ messages in thread
From: Jeff Garzik @ 2007-01-03 1:02 UTC (permalink / raw)
To: Alan; +Cc: Linus Torvalds, Alessandro Suardi, Linux Kernel Mailing List
Alan wrote:
> Once combined mode is fixed not to abuse resources (and it originally
> did it that way for a good reason I grant and am not criticising that) the
> entire management for legacy mode, mixed mode and native mode resources
> for an ATA device (including 0x170, 0x3F6 and other wacky magic) becomes
>
> if (pci_request_regions(pdev, "libata")) ...
> Make sense ?
Yes. For 2.6.21. As I've always said.
But for 2.6.20, we are only HALFWAY there, and all these /new/ bugs
exist as a result.
Your patch makes far more sense for 2.6.21, where the "halfway to
salvation" state, and associated rough edges, is not exposed to users.
Fixing the resource tree was only half the solution, since the drivers
that /use/ the resource tree now need updating.
Jeff
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
2007-01-02 23:27 ` Alan
2007-01-02 23:43 ` Jeff Garzik
@ 2007-01-02 23:54 ` Jeff Garzik
2007-01-03 0:39 ` Alan
1 sibling, 1 reply; 56+ messages in thread
From: Jeff Garzik @ 2007-01-02 23:54 UTC (permalink / raw)
To: Alan, Linus Torvalds; +Cc: Alessandro Suardi, Linux Kernel Mailing List
Or maybe this rephrase helps:
Regardless of how the IDE quirks have configured the PCI BARs, libata is
written to assume that /all/ struct pci_dev resources for a single PCI
device are reserved to the libata driver.
Thus, if you avoid calling pci_request_regions (as your patch does), you
must manually provide the same guarantees that pci_request_regions
provides to its callers.
Jeff
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
2007-01-02 23:54 ` Jeff Garzik
@ 2007-01-03 0:39 ` Alan
0 siblings, 0 replies; 56+ messages in thread
From: Alan @ 2007-01-03 0:39 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Linus Torvalds, Alessandro Suardi, Linux Kernel Mailing List
> Thus, if you avoid calling pci_request_regions (as your patch does), you
> must manually provide the same guarantees that pci_request_regions
> provides to its callers.
pci_request_regions reserves only BAR4/BAR5 in legacy mode because of the
fact the resources are mashed and eventually cleaare by the existing (pre
2.6.20-rc) PCI code. The new code does provide that guarantee which is
(unfortunately) precisely why you get the problem - because the combined
mode hack currently relies on it failing to do so.
Alan
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
2007-01-02 22:45 ` Alan
2007-01-02 23:01 ` Jeff Garzik
@ 2007-01-02 23:04 ` Jeff Garzik
1 sibling, 0 replies; 56+ messages in thread
From: Jeff Garzik @ 2007-01-02 23:04 UTC (permalink / raw)
To: Alan; +Cc: Linus Torvalds, Alessandro Suardi, Linux Kernel Mailing List
Alan wrote:
> Actually it didn't reserve BAR1 and BAR3 in legacy mode precisely because
> of the PCI resource mismanagement in the old tree. So you take your pick.
I pick old bugs over new regressions.
Jeff
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
2007-01-02 11:58 ` [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released)) Alan
` (2 preceding siblings ...)
2007-01-02 21:00 ` Jeff Garzik
@ 2007-01-03 19:59 ` Steve Wise
3 siblings, 0 replies; 56+ messages in thread
From: Steve Wise @ 2007-01-03 19:59 UTC (permalink / raw)
To: Alan
Cc: Jeff Garzik, Linus Torvalds, Alessandro Suardi,
Linux Kernel Mailing List
On Tue, 2007-01-02 at 11:58 +0000, Alan wrote:
...
>
> I'm sending this now rather than after running full test suites so that
> it can get the maximal testing in a short time. I'll be running tests on
> this after lunch.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> --- linux.vanilla-2.6.20-rc3/drivers/ata/libata-sff.c 2007-01-01 21:43:27.000000000 +0000
> +++ linux-2.6.20-rc3/drivers/ata/libata-sff.c 2007-01-02 11:15:53.000000000 +0000
> @@ -1027,13 +1027,15 @@
> #endif
> }
>
> - rc = pci_request_regions(pdev, DRV_NAME);
> - if (rc) {
> - disable_dev_on_err = 0;
> - goto err_out;
> - }
> -
> - if (legacy_mode) {
> + if (!legacy_mode) {
> + rc = pci_request_regions(pdev, DRV_NAME);
> + if (rc) {
> + disable_dev_on_err = 0;
> + goto err_out;
> + }
> + } else {
> + /* Deal with combined mode hack. This side of the logic all
> + goes away once the combined mode hack is killed in 2.6.21 */
> if (!request_region(ATA_PRIMARY_CMD, 8, "libata")) {
> struct resource *conflict, res;
> res.start = ATA_PRIMARY_CMD;
> @@ -1071,6 +1073,13 @@
> }
> } else
> legacy_mode |= ATA_PORT_SECONDARY;
> +
> + if (legacy_mode & ATA_PORT_PRIMARY)
> + pci_request_region(pdev, 1, DRV_NAME);
> + if (legacy_mode & ATA_PORT_SECONDARY)
> + pci_request_region(pdev, 3, DRV_NAME);
> + /* If there is a DMA resource, allocate it */
> + pci_request_region(pdev, 4, DRV_NAME);
> }
>
> /* we have legacy mode, but all ports are unavailable */
> @@ -1114,11 +1123,20 @@
> err_out_ent:
> kfree(probe_ent);
> err_out_regions:
> - if (legacy_mode & ATA_PORT_PRIMARY)
> - release_region(ATA_PRIMARY_CMD, 8);
> - if (legacy_mode & ATA_PORT_SECONDARY)
> - release_region(ATA_SECONDARY_CMD, 8);
> - pci_release_regions(pdev);
> + /* All this conditional stuff is needed for the combined mode hack
> + until 2.6.21 when it can go */
> + if (legacy_mode) {
> + pci_release_region(pdev, 4);
> + if (legacy_mode & ATA_PORT_PRIMARY) {
> + release_region(ATA_PRIMARY_CMD, 8);
> + pci_release_region(pdev, 1);
> + }
> + if (legacy_mode & ATA_PORT_SECONDARY) {
> + release_region(ATA_SECONDARY_CMD, 8);
> + pci_release_region(pdev, 3);
> + }
> + } else
> + pci_release_regions(pdev);
> err_out:
> if (disable_dev_on_err)
> pci_disable_device(pdev);
This patch works for me too.
Steve.
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: Happy New Year (and v2.6.20-rc3 released)
2007-01-01 20:13 ` Linus Torvalds
2007-01-01 20:49 ` Jeff Garzik
@ 2007-01-01 21:26 ` Alan
2007-01-02 16:09 ` Linus Torvalds
1 sibling, 1 reply; 56+ messages in thread
From: Alan @ 2007-01-01 21:26 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Alessandro Suardi, Jeff Garzik, Linux Kernel Mailing List
On Mon, 1 Jan 2007 12:13:08 -0800 (PST)
Linus Torvalds <torvalds@osdl.org> wrote:
>
> Jeff,
> what was the resolution to this one? Just revert the offending commit, or
> what?
If you revert the commit you end with all the PCI resource tree breakage
back
>
> We're about five weeks into the 2.6.20-rc series. I was hoping for a
> two-month release rather than the usual dragged-out three months, so I'd
> like to get these regressions to be actively fixed. By forcible reverts if
> that is what it takes.
The patch I sent ages back is perfectly adequate for 2.6.20-rc/2.6.20
final. Jeff is correct that it isn't perfection in all cases but it does
no real harm and the right fix (removing the whole bogus combined mode
garbage) is short and simple.
If Jeff doesn't get you a patch please let me know before reverting it
and I'll send you the one I'm using that folks have tested and works.
Alan
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: Happy New Year (and v2.6.20-rc3 released)
2007-01-01 21:26 ` Happy New Year (and v2.6.20-rc3 released) Alan
@ 2007-01-02 16:09 ` Linus Torvalds
0 siblings, 0 replies; 56+ messages in thread
From: Linus Torvalds @ 2007-01-02 16:09 UTC (permalink / raw)
To: Alan; +Cc: Alessandro Suardi, Jeff Garzik, Linux Kernel Mailing List
On Mon, 1 Jan 2007, Alan wrote:
>
> If you revert the commit you end with all the PCI resource tree breakage
> back
Which weren't a regression or anything new.
Alan: regressions are what we don't do. Ever. If your second patch is
found to have some other problems, we revert them both. It's that simple.
It's better to stay in place than walk backwards, even if the "backwards"
is just for a few people.
So far, it fixed at least Alessandro's problems, so here's to hoping there
aren't any others..
Linus
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: Happy New Year (and v2.6.20-rc3 released)
2007-01-01 1:19 Happy New Year (and v2.6.20-rc3 released) Linus Torvalds
` (4 preceding siblings ...)
2007-01-01 13:28 ` Alessandro Suardi
@ 2007-01-01 15:52 ` Olaf Hering
2007-01-02 19:16 ` 2.6.20-rc3: known unfixed regressions Adrian Bunk
` (7 subsequent siblings)
13 siblings, 0 replies; 56+ messages in thread
From: Olaf Hering @ 2007-01-01 15:52 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 618 bytes --]
The final 2.6.20 release note should mention the following commit in some
way: "[NETFILTER]: Kconfig: improve conntrack selection"
It will break existing iptable setups without warning becausee it
disables all related .config options. If one says NO to the new
NF_CONNTRACK_ENABLED "Netfilter connection tracking support",
NAT and other stuff will disappear.
One has to choose '2 "Layer 3 Dependent Connection tracking (OBSOLETE)"'
in a following question, to keep most of the existing modules during a
make oldconfig.
Its not obvious why make oldconfig still asks that many questions about
existing .config options.
[-- Attachment #2: config-2.6.16.gz --]
[-- Type: application/x-gunzip, Size: 8067 bytes --]
^ permalink raw reply [flat|nested] 56+ messages in thread
* 2.6.20-rc3: known unfixed regressions
2007-01-01 1:19 Happy New Year (and v2.6.20-rc3 released) Linus Torvalds
` (5 preceding siblings ...)
2007-01-01 15:52 ` Olaf Hering
@ 2007-01-02 19:16 ` Adrian Bunk
2007-01-03 18:15 ` Steve Youngs
2007-01-02 19:24 ` 2.6.20-rc3: known regressions with patches available (part 1) Adrian Bunk
` (6 subsequent siblings)
13 siblings, 1 reply; 56+ messages in thread
From: Adrian Bunk @ 2007-01-02 19:16 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton
Cc: Linux Kernel Mailing List, Steve Youngs, Berthold Cogel,
len.brown, linux-acpi, Florin Iucha, greg, linux-usb-devel,
dmitry.torokhov, linux-input, Jon Smirl, Horst H. von Brand,
davem, sparclinux, Komuro, YOSHIFUJI Hideaki, netdev,
Michael Reske, Ayaz Abdulla, Jeff Garzik, Tobias Diedrich,
Andi Kleen, Yinghai Lu, Eric W. Biederman, discuss
This email lists some known regressions in 2.6.20-rc3 compared to 2.6.19
that are not yet fixed in Linus' tree.
If you find your name in the Cc header, you are either submitter of one
of the bugs, maintainer of an affectected subsystem or driver, a patch
of you caused a breakage or I'm considering you in any other way possibly
involved with one or more of these issues.
Due to the huge amount of recipients, please trim the Cc when answering.
Subject : kernel immediately reboots
References : http://lkml.org/lkml/2007/1/2/15
Submitter : Steve Youngs <steve@youngs.au.com>
Status : unknown
Subject : Acer Extensa 3002 WLMi: 'shutdown -h now' reboots the system
References : http://lkml.org/lkml/2006/12/25/40
Submitter : Berthold Cogel <cogel@rrz.uni-koeln.de>
Status : unknown
Subject : USB keyboard unresponsive after some time
References : http://lkml.org/lkml/2006/12/25/35
http://lkml.org/lkml/2006/12/26/106
Submitter : Florin Iucha <florin@iucha.net>
Status : unknown
Subject : BUG: scheduling while atomic
References : http://lkml.org/lkml/2006/12/26/105
Submitter : Jon Smirl <jonsmirl@gmail.com>
Status : unknown
Subject : SPARC64: Can't mount /
References : http://lkml.org/lkml/2006/12/13/181
Submitter : Horst H. von Brand <vonbrand@inf.utfsm.cl>
Status : unknown
Subject : ftp: get or put stops during file-transfer
References : http://lkml.org/lkml/2006/12/16/174
Submitter : Komuro <komurojun-mbn@nifty.com>
Caused-By : YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
commit cfb6eeb4c860592edd123fdea908d23c6ad1c7dc
Handled-By : YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Status : problem is being debugged
Subject : forcedeth.c 0.59: problem with sideband managment
References : http://bugzilla.kernel.org/show_bug.cgi?id=7684
Submitter : Michael Reske <micha@gmx.com>
Handled-By : Ayaz Abdulla <aabdulla@nvidia.com>
Status : problem is being debugged
Subject : x86_64 boot failure: "IO-APIC + timer doesn't work"
References : http://lkml.org/lkml/2006/12/16/101
Submitter : Tobias Diedrich <ranma+kernel@tdiedrich.de>
Caused-By : Andi Kleen <ak@suse.de>
commit b026872601976f666bae77b609dc490d1834bf77
Handled-By : Yinghai Lu <yinghai.lu@amd.com>
Eric W. Biederman <ebiederm@xmission.com>
Status : problem is being debugged
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: 2.6.20-rc3: known unfixed regressions
2007-01-02 19:16 ` 2.6.20-rc3: known unfixed regressions Adrian Bunk
@ 2007-01-03 18:15 ` Steve Youngs
2007-01-03 20:03 ` Adrian Bunk
0 siblings, 1 reply; 56+ messages in thread
From: Steve Youngs @ 2007-01-03 18:15 UTC (permalink / raw)
To: Adrian Bunk
Cc: Linus Torvalds, Andrew Morton, Linux Kernel Mailing List,
Segher Boessenkool, Vivek Goyal, Jean Delvare, Eric W. Biederman,
Andi Kleen
[-- Attachment #1: Type: text/plain, Size: 637 bytes --]
* Adrian Bunk <bunk@stusta.de> writes:
> Subject : kernel immediately reboots
> References : http://lkml.org/lkml/2007/1/2/15
> Submitter : Steve Youngs <steve@youngs.au.com>
> Status : unknown
I'm very happy to report that this is now fixed for me. See commit
c6b33cc4e9882b44f1b0c36396f420076e04a4e2.
Thanks very much for the fast response and fix.
--
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
| Te audire no possum. |
| Musa sapientum fixa est in aure. |
|----------------------------------<steve@youngs.au.com>---|
[-- Attachment #2: Type: application/pgp-signature, Size: 312 bytes --]
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: 2.6.20-rc3: known unfixed regressions
2007-01-03 18:15 ` Steve Youngs
@ 2007-01-03 20:03 ` Adrian Bunk
0 siblings, 0 replies; 56+ messages in thread
From: Adrian Bunk @ 2007-01-03 20:03 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton, Linux Kernel Mailing List,
Segher Boessenkool, Vivek Goyal, Jean Delvare, Eric W. Biederman,
Andi Kleen
On Thu, Jan 04, 2007 at 04:15:02AM +1000, Steve Youngs wrote:
> * Adrian Bunk <bunk@stusta.de> writes:
>
> > Subject : kernel immediately reboots
> > References : http://lkml.org/lkml/2007/1/2/15
> > Submitter : Steve Youngs <steve@youngs.au.com>
> > Status : unknown
>
> I'm very happy to report that this is now fixed for me. See commit
> c6b33cc4e9882b44f1b0c36396f420076e04a4e2.
>
> Thanks very much for the fast response and fix.
Thanks for both your bug report and your confirmation that it's fixed.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 56+ messages in thread
* 2.6.20-rc3: known regressions with patches available (part 1)
2007-01-01 1:19 Happy New Year (and v2.6.20-rc3 released) Linus Torvalds
` (6 preceding siblings ...)
2007-01-02 19:16 ` 2.6.20-rc3: known unfixed regressions Adrian Bunk
@ 2007-01-02 19:24 ` Adrian Bunk
2007-01-02 19:26 ` Jens Axboe
2007-01-02 19:30 ` 2.6.20-rc3: known regressions with patches available (part 2) Adrian Bunk
` (5 subsequent siblings)
13 siblings, 1 reply; 56+ messages in thread
From: Adrian Bunk @ 2007-01-02 19:24 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton
Cc: Linux Kernel Mailing List, Andrey Borzenkov, Robert Hancock,
Rafael J. Wysocki, pavel, linux-pm, Jean Delvare,
Eric W. Biederman, Vivek Goyal, Marcel Holtmann, bluez-devel,
Rene Herman, Mark Lord, Jens Axboe, Laurent Riffard,
Christoph Hellwig, petero2
This email lists some known regressions in 2.6.20-rc3 compared to 2.6.19
with patches available.
If you find your name in the Cc header, you are either submitter of one
of the bugs, maintainer of an affectected subsystem or driver, a patch
of you caused a breakage or I'm considering you in any other way possibly
involved with one or more of these issues.
Due to the huge amount of recipients, please trim the Cc when answering.
Subject : suspend to disk no longer works
References : http://lkml.org/lkml/2007/1/1/72
http://lkml.org/lkml/2006/12/31/13
Submitter : Andrey Borzenkov <arvidjaar@mail.ru>
Robert Hancock <hancockr@shaw.ca>
Handled-By : Rafael J. Wysocki <rjw@sisk.pl>
Patch : http://lkml.org/lkml/2007/1/1/117
Status : patch available
Subject : "i386: Relocatable kernel support" causes instant reboot
References : http://lkml.org/lkml/2006/12/20/114
Submitter : Jean Delvare <khali@linux-fr.org>
Caused-By : Eric W. Biederman <ebiederm@xmission.com>
commit 968de4f02621db35b8ae5239c8cfc6664fb872d8
Handled-By : Vivek Goyal <vgoyal@in.ibm.com>
Patch : http://lkml.org/lkml/2007/1/2/9
Status : patch available
Subject : bluetooth oopses because of multiple kobject_add()
References : http://lkml.org/lkml/2007/1/2/101
Submitter : Pavel Machek <pavel@ucw.cz>
Handled-By : Marcel Holtmann <marcel@holtmann.org>
Patch : http://lkml.org/lkml/2007/1/2/147
Status : patch available
Subject : CFQ disk throughput halved
References : http://lkml.org/lkml/2007/01/1/104
Submitter : Rene Herman <rene.herman@gmail.com>
Mark Lord <lkml@rtr.ca>
Caused-By : Jens Axboe <jens.axboe@oracle.com>
commit 719d34027e1a186e46a3952e8a24bf91ecc33837
Handled-By : Jens Axboe <jens.axboe@oracle.com>
Patch : http://lkml.org/lkml/2007/1/2/75
Status : patch available
Subject : BUG at drivers/scsi/scsi_lib.c:1118 by "pktsetup dvd /dev/sr0"
References : http://bugzilla.kernel.org/show_bug.cgi?id=7667
Submitter : Laurent Riffard <laurent.riffard@free.fr>
Caused-By : Christoph Hellwig <hch@lst.de>
commit 3b00315799d78f76531b71435fbc2643cd71ae4c
Handled-By : Christoph Hellwig <hch@lst.de>
Patch : http://bugzilla.kernel.org/show_bug.cgi?id=7667
Status : patch available
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: 2.6.20-rc3: known regressions with patches available (part 1)
2007-01-02 19:24 ` 2.6.20-rc3: known regressions with patches available (part 1) Adrian Bunk
@ 2007-01-02 19:26 ` Jens Axboe
2007-01-02 19:34 ` Adrian Bunk
0 siblings, 1 reply; 56+ messages in thread
From: Jens Axboe @ 2007-01-02 19:26 UTC (permalink / raw)
To: Adrian Bunk
Cc: Linus Torvalds, Andrew Morton, Linux Kernel Mailing List,
Andrey Borzenkov, Robert Hancock, Rafael J. Wysocki, pavel,
linux-pm, Jean Delvare, Eric W. Biederman, Vivek Goyal,
Marcel Holtmann, bluez-devel, Rene Herman, Mark Lord,
Laurent Riffard, Christoph Hellwig, petero2
On Tue, Jan 02 2007, Adrian Bunk wrote:
> Subject : CFQ disk throughput halved
> References : http://lkml.org/lkml/2007/01/1/104
> Submitter : Rene Herman <rene.herman@gmail.com>
> Mark Lord <lkml@rtr.ca>
> Caused-By : Jens Axboe <jens.axboe@oracle.com>
> commit 719d34027e1a186e46a3952e8a24bf91ecc33837
> Handled-By : Jens Axboe <jens.axboe@oracle.com>
> Patch : http://lkml.org/lkml/2007/1/2/75
> Status : patch available
Patch is already merged in -git.
--
Jens Axboe
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: 2.6.20-rc3: known regressions with patches available (part 1)
2007-01-02 19:26 ` Jens Axboe
@ 2007-01-02 19:34 ` Adrian Bunk
2007-01-02 20:45 ` Rene Herman
0 siblings, 1 reply; 56+ messages in thread
From: Adrian Bunk @ 2007-01-02 19:34 UTC (permalink / raw)
To: Jens Axboe
Cc: Linus Torvalds, Andrew Morton, Linux Kernel Mailing List,
Andrey Borzenkov, Robert Hancock, Rafael J. Wysocki, pavel,
linux-pm, Jean Delvare, Eric W. Biederman, Vivek Goyal,
Marcel Holtmann, bluez-devel, Rene Herman, Mark Lord,
Laurent Riffard, Christoph Hellwig, petero2
On Tue, Jan 02, 2007 at 08:26:52PM +0100, Jens Axboe wrote:
> On Tue, Jan 02 2007, Adrian Bunk wrote:
> > Subject : CFQ disk throughput halved
> > References : http://lkml.org/lkml/2007/01/1/104
> > Submitter : Rene Herman <rene.herman@gmail.com>
> > Mark Lord <lkml@rtr.ca>
> > Caused-By : Jens Axboe <jens.axboe@oracle.com>
> > commit 719d34027e1a186e46a3952e8a24bf91ecc33837
> > Handled-By : Jens Axboe <jens.axboe@oracle.com>
> > Patch : http://lkml.org/lkml/2007/1/2/75
> > Status : patch available
>
> Patch is already merged in -git.
Thanks for this information, I missed this (as well as the merged SATA
fix) since it isn't yet at the git mirrors.
> Jens Axboe
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: 2.6.20-rc3: known regressions with patches available (part 1)
2007-01-02 19:34 ` Adrian Bunk
@ 2007-01-02 20:45 ` Rene Herman
2007-01-02 20:51 ` Jens Axboe
0 siblings, 1 reply; 56+ messages in thread
From: Rene Herman @ 2007-01-02 20:45 UTC (permalink / raw)
To: Adrian Bunk
Cc: Jens Axboe, Linus Torvalds, Andrew Morton,
Linux Kernel Mailing List, Andrey Borzenkov, Robert Hancock,
Rafael J. Wysocki, pavel, linux-pm, Jean Delvare,
Eric W. Biederman, Vivek Goyal, Marcel Holtmann, bluez-devel,
Mark Lord, Laurent Riffard, Christoph Hellwig, petero2
Adrian Bunk wrote:
> On Tue, Jan 02, 2007 at 08:26:52PM +0100, Jens Axboe wrote:
>> Patch is already merged in -git.
>
> Thanks for this information, I missed this (as well as the merged SATA
> fix) since it isn't yet at the git mirrors.
What's "-git" here? I just now pulled
git://git2.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
and it's not there.
Otherwise, patch confirmed to work by me as well.
Cheers,
Rene
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: 2.6.20-rc3: known regressions with patches available (part 1)
2007-01-02 20:45 ` Rene Herman
@ 2007-01-02 20:51 ` Jens Axboe
0 siblings, 0 replies; 56+ messages in thread
From: Jens Axboe @ 2007-01-02 20:51 UTC (permalink / raw)
To: Rene Herman
Cc: Adrian Bunk, Linus Torvalds, Andrew Morton,
Linux Kernel Mailing List, Andrey Borzenkov, Robert Hancock,
Rafael J. Wysocki, pavel, linux-pm, Jean Delvare,
Eric W. Biederman, Vivek Goyal, Marcel Holtmann, bluez-devel,
Mark Lord, Laurent Riffard, Christoph Hellwig, petero2
On Tue, Jan 02 2007, Rene Herman wrote:
> Adrian Bunk wrote:
>
> >On Tue, Jan 02, 2007 at 08:26:52PM +0100, Jens Axboe wrote:
>
> >>Patch is already merged in -git.
> >
> >Thanks for this information, I missed this (as well as the merged SATA
> >fix) since it isn't yet at the git mirrors.
>
> What's "-git" here? I just now pulled
>
> git://git2.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
>
> and it's not there.
>
> Otherwise, patch confirmed to work by me as well.
Perhaps not mirrored out yet, I pulled it from master/hera some hours
ago though. The top of Linus' tree is
ec8acb6904fabb8e741f741ec99bb1c18f2b3dee, which is the commit with that
patch.
--
Jens Axboe
^ permalink raw reply [flat|nested] 56+ messages in thread
* 2.6.20-rc3: known regressions with patches available (part 2)
2007-01-01 1:19 Happy New Year (and v2.6.20-rc3 released) Linus Torvalds
` (7 preceding siblings ...)
2007-01-02 19:24 ` 2.6.20-rc3: known regressions with patches available (part 1) Adrian Bunk
@ 2007-01-02 19:30 ` Adrian Bunk
2007-01-03 19:06 ` [2.6.20-rc3] INFO: possible recursive locking detected (was: Happy New Year (and v2.6.20-rc3 released)) Tilman Schmidt
` (4 subsequent siblings)
13 siblings, 0 replies; 56+ messages in thread
From: Adrian Bunk @ 2007-01-02 19:30 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton
Cc: Linux Kernel Mailing List, Adam J. Richter, Paul Moore,
Parag Warudkar, sds, jmorris, netdev, Alessandro Suardi,
Theodore Tso, Alan Cox, Jeff Garzik, linux-ide, Ben Castricum,
Greg Kroah-Hartman, linux-pci
This email lists some known regressions in 2.6.20-rc3 compared to 2.6.19
with patches available
If you find your name in the Cc header, you are either submitter of one
of the bugs, maintainer of an affectected subsystem or driver, a patch
of you caused a breakage or I'm considering you in any other way possibly
involved with one or more of these issues.
Due to the huge amount of recipients, please trim the Cc when answering.
Subject : selinux networking: sleeping function called from invalid context
References : http://lkml.org/lkml/2006/12/24/78
Submitter : Adam J. Richter <adam@yggdrasil.com>
Caused-By : Paul Moore <paul.moore@hp.com>
Handled-By : Parag Warudkar <paragw@paragw.zapto.org>
Patch : http://lkml.org/lkml/2006/12/24/89
Status : patch available
Subject : kernel panics on boot (libata-sff)
References : http://lkml.org/lkml/2006/12/3/99
http://lkml.org/lkml/2006/12/14/153
http://lkml.org/lkml/2006/12/24/33
http://lkml.org/lkml/2007/1/1/84
Submitter : Alessandro Suardi <alessandro.suardi@gmail.com>
Theodore Tso <tytso@mit.edu>
Caused-By : Alan Cox <alan@lxorguk.ukuu.org.uk>
commit 368c73d4f689dae0807d0a2aa74c61fd2b9b075f
Handled-By : Alan Cox <alan@lxorguk.ukuu.org.uk>
Jeff Garzik <jeff@garzik.org>
Patch : http://lkml.org/lkml/2007/1/2/64
Status : patch available
Subject : PCI_MULTITHREAD_PROBE breakage
References : http://lkml.org/lkml/2006/12/12/21
Submitter : Ben Castricum <mail0612@bencastricum.nl>
Caused-By : Greg Kroah-Hartman <gregkh@suse.de>
commit 009af1ff78bfc30b9a27807dd0207fc32848218a
Handled-By : Greg Kroah-Hartman <gregkh@suse.de>
Status : patch available
^ permalink raw reply [flat|nested] 56+ messages in thread
* [2.6.20-rc3] INFO: possible recursive locking detected (was: Happy New Year (and v2.6.20-rc3 released))
2007-01-01 1:19 Happy New Year (and v2.6.20-rc3 released) Linus Torvalds
` (8 preceding siblings ...)
2007-01-02 19:30 ` 2.6.20-rc3: known regressions with patches available (part 2) Adrian Bunk
@ 2007-01-03 19:06 ` Tilman Schmidt
2007-01-03 20:59 ` 2.6.20-rc3: known unfixed regressions (v2) Adrian Bunk
` (3 subsequent siblings)
13 siblings, 0 replies; 56+ messages in thread
From: Tilman Schmidt @ 2007-01-03 19:06 UTC (permalink / raw)
To: Linux Kernel Mailing List
On Sun, 31 Dec 2006 17:19:44 -0800 (PST), Linus Torvalds wrote:
> In order to not get in trouble with MADR ("Mothers Against Drunk
> Releases") I decided to cut the 2.6.20-rc3 release early rather than wait
[...]
> At which point the first thing on any self-respecting geek's mind should
> obviously be: "is there a new kernel release for me to try?"
2.6.20-rc3 produces the following lockdep warning when hald is
started during system startup:
=============================================
[ INFO: possible recursive locking detected ]
2.6.20-rc3-noinitrd #0
---------------------------------------------
hald-subfs-moun/4608 is trying to acquire lock:
(&inode->i_mutex){--..}, at: [<c035bb02>] mutex_lock+0x1c/0x1f
but task is already holding lock:
(&inode->i_mutex){--..}, at: [<c035bb02>] mutex_lock+0x1c/0x1f
other info that might help us debug this:
3 locks held by hald-subfs-moun/4608:
#0: (&inode->i_mutex){--..}, at: [<c035bb02>] mutex_lock+0x1c/0x1f
#1: (&REISERFS_I(inode)->xattr_sem){----}, at: [<c01c0098>] reiserfs_setxattr+0x51/0xe9
#2: (&REISERFS_SB(s)->xattr_dir_sem){----}, at: [<c01c00be>] reiserfs_setxattr+0x77/0xe9
stack backtrace:
[<c0103c72>] show_trace_log_lvl+0x19/0x2e
[<c0103d6b>] show_trace+0x12/0x14
[<c0103d81>] dump_stack+0x14/0x16
[<c01303b3>] __lock_acquire+0x116/0xa5c
[<c0130fe6>] lock_acquire+0x56/0x70
[<c035b95c>] __mutex_lock_slowpath+0xdc/0x266
[<c035bb02>] mutex_lock+0x1c/0x1f
[<c01c07d0>] reiserfs_xattr_set+0xe4/0x2c0
[<c01c0c21>] trusted_set+0x74/0x80
[<c01c00e9>] reiserfs_setxattr+0xa2/0xe9
[<c0177b45>] vfs_setxattr+0xa6/0x1ff
[<c0177d57>] setxattr+0xb9/0xd1
[<c0177e14>] sys_lsetxattr+0x3e/0x50
[<c0102d9a>] sysenter_past_esp+0x5f/0x99
=======================
I guess it's really the same ReiserFS issue I already reported for
the previous releases, just triggered at an earlier point in the
system's life.
Other than that, everything seems fine and dandy on this plain old P3.
HTH, and Happy New Year everyone
Tilman
^ permalink raw reply [flat|nested] 56+ messages in thread
* 2.6.20-rc3: known unfixed regressions (v2)
2007-01-01 1:19 Happy New Year (and v2.6.20-rc3 released) Linus Torvalds
` (9 preceding siblings ...)
2007-01-03 19:06 ` [2.6.20-rc3] INFO: possible recursive locking detected (was: Happy New Year (and v2.6.20-rc3 released)) Tilman Schmidt
@ 2007-01-03 20:59 ` Adrian Bunk
2007-01-04 13:23 ` Horst H. von Brand
2007-01-03 21:04 ` 2.6.20-rc3: known regressions with patches (v2) Adrian Bunk
` (2 subsequent siblings)
13 siblings, 1 reply; 56+ messages in thread
From: Adrian Bunk @ 2007-01-03 20:59 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton
Cc: Linux Kernel Mailing List, Berthold Cogel, len.brown, linux-acpi,
Florin Iucha, greg, linux-usb-devel, dmitry.torokhov,
linux-input, Jon Smirl, Horst H. von Brand, davem, sparclinux,
Komuro, YOSHIFUJI Hideaki, netdev, Tobias Diedrich, Andi Kleen,
Yinghai Lu, Eric W. Biederman, discuss, mingo
This email lists some known regressions in 2.6.20-rc3 compared to 2.6.19
that are not yet fixed in Linus' tree.
If you find your name in the Cc header, you are either submitter of one
of the bugs, maintainer of an affectected subsystem or driver, a patch
of you caused a breakage or I'm considering you in any other way possibly
involved with one or more of these issues.
Due to the huge amount of recipients, please trim the Cc when answering.
Subject : Acer Extensa 3002 WLMi: 'shutdown -h now' reboots the system
References : http://lkml.org/lkml/2006/12/25/40
Submitter : Berthold Cogel <cogel@rrz.uni-koeln.de>
Status : unknown
Subject : USB keyboard unresponsive after some time
References : http://lkml.org/lkml/2006/12/25/35
http://lkml.org/lkml/2006/12/26/106
Submitter : Florin Iucha <florin@iucha.net>
Status : unknown
Subject : BUG: scheduling while atomic
References : http://lkml.org/lkml/2006/12/26/105
Submitter : Jon Smirl <jonsmirl@gmail.com>
Status : unknown
Subject : SPARC64: Can't mount /
References : http://lkml.org/lkml/2006/12/13/181
Submitter : Horst H. von Brand <vonbrand@inf.utfsm.cl>
Status : unknown
Subject : ftp: get or put stops during file-transfer
References : http://lkml.org/lkml/2006/12/16/174
Submitter : Komuro <komurojun-mbn@nifty.com>
Caused-By : YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
commit cfb6eeb4c860592edd123fdea908d23c6ad1c7dc
Handled-By : YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Status : problem is being debugged
Subject : x86_64 boot failure: "IO-APIC + timer doesn't work"
References : http://lkml.org/lkml/2006/12/16/101
http://lkml.org/lkml/2007/1/3/9
Submitter : Tobias Diedrich <ranma+kernel@tdiedrich.de>
Caused-By : Andi Kleen <ak@suse.de>
commit b026872601976f666bae77b609dc490d1834bf77
Handled-By : Yinghai Lu <yinghai.lu@amd.com>
Eric W. Biederman <ebiederm@xmission.com>
Status : patches are being discussed
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: 2.6.20-rc3: known unfixed regressions (v2)
2007-01-03 20:59 ` 2.6.20-rc3: known unfixed regressions (v2) Adrian Bunk
@ 2007-01-04 13:23 ` Horst H. von Brand
0 siblings, 0 replies; 56+ messages in thread
From: Horst H. von Brand @ 2007-01-04 13:23 UTC (permalink / raw)
To: Adrian Bunk
Cc: Linus Torvalds, Andrew Morton, Linux Kernel Mailing List,
sparclinux, davem
Adrian Bunk <bunk@stusta.de> wrote:
> This email lists some known regressions in 2.6.20-rc3 compared to 2.6.19
> that are not yet fixed in Linus' tree.
>
> If you find your name in the Cc header, you are either submitter of one
> of the bugs, maintainer of an affectected subsystem or driver, a patch
> of you caused a breakage or I'm considering you in any other way possibly
> involved with one or more of these issues.
>
> Due to the huge amount of recipients, please trim the Cc when answering.
I hope I cut it down sensibly...
[...]
> Subject : SPARC64: Can't mount /
> References : http://lkml.org/lkml/2006/12/13/181
> Submitter : Horst H. von Brand <vonbrand@inf.utfsm.cl>
> Status : unknown
Works for me now with 2.6.20-rc3. Might have been some form of pilot error
(perhaps setting SCSI_TGT=m and/or SCSI_SCAN_ASYNC=y, I unset them for the
current trial run).
I see CONFIG_SCSI_SCAN_ASYNC introduced in
21db1882f79a1ad5977cae6766376a63f60ec414 ([SCSI] Add Kconfig option for
asynchronous SCSI scanning). If this is the cause, the override provided:
scsi_mod.scan="sync"
seems not to work. Are the '"' necessary? How do you give them via silo,
which in its configuration file for strings with spaces uses:
append="some string here"
How do you say '"'? The silo documentation is silent on this.
--
Dr. Horst H. von Brand User #22616 counter.li.org
Departamento de Informatica Fono: +56 32 2654431
Universidad Tecnica Federico Santa Maria +56 32 2654239
Casilla 110-V, Valparaiso, Chile Fax: +56 32 2797513
^ permalink raw reply [flat|nested] 56+ messages in thread
* 2.6.20-rc3: known regressions with patches (v2)
2007-01-01 1:19 Happy New Year (and v2.6.20-rc3 released) Linus Torvalds
` (10 preceding siblings ...)
2007-01-03 20:59 ` 2.6.20-rc3: known unfixed regressions (v2) Adrian Bunk
@ 2007-01-03 21:04 ` Adrian Bunk
2007-01-03 21:30 ` Jiri Kosina
2007-01-04 17:46 ` 2.6.20-rc3: known unfixed regressions (v3) Adrian Bunk
2007-01-06 21:04 ` 2.6.20-rc3: known unfixed regressions (v4) Adrian Bunk
13 siblings, 1 reply; 56+ messages in thread
From: Adrian Bunk @ 2007-01-03 21:04 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton
Cc: Linux Kernel Mailing List, Andrey Borzenkov, Robert Hancock,
Rafael J. Wysocki, pavel, linux-pm, Laurent Riffard,
Christoph Hellwig, petero2, Michael Reske, Ayaz Abdulla, jgarzik,
netdev, Marcel Holtmann, bluez-devel, Ben Castricum,
Greg Kroah-Hartman, linux-pci
This email lists some known regressions in 2.6.20-rc3 compared to 2.6.19
with patches available.
If you find your name in the Cc header, you are either submitter of one
of the bugs, maintainer of an affectected subsystem or driver, a patch
of you caused a breakage or I'm considering you in any other way possibly
involved with one or more of these issues.
Due to the huge amount of recipients, please trim the Cc when answering.
Subject : suspend to disk no longer works
References : http://lkml.org/lkml/2007/1/1/72
http://lkml.org/lkml/2006/12/31/13
Submitter : Andrey Borzenkov <arvidjaar@mail.ru>
Robert Hancock <hancockr@shaw.ca>
Handled-By : Rafael J. Wysocki <rjw@sisk.pl>
Patch : http://lkml.org/lkml/2007/1/1/117
Status : patch available
Subject : BUG at drivers/scsi/scsi_lib.c:1118 by "pktsetup dvd /dev/sr0"
References : http://bugzilla.kernel.org/show_bug.cgi?id=7667
Submitter : Laurent Riffard <laurent.riffard@free.fr>
Caused-By : Christoph Hellwig <hch@lst.de>
commit 3b00315799d78f76531b71435fbc2643cd71ae4c
Handled-By : Christoph Hellwig <hch@lst.de>
Patch : http://bugzilla.kernel.org/show_bug.cgi?id=7667
Status : patch available
Subject : forcedeth.c 0.59: problem with sideband managment
References : http://bugzilla.kernel.org/show_bug.cgi?id=7684
Submitter : Michael Reske <micha@gmx.com>
Handled-By : Ayaz Abdulla <aabdulla@nvidia.com>
Status : patch available
Subject : bluetooth oopses because of multiple kobject_add()
References : http://lkml.org/lkml/2007/1/2/101
Submitter : Pavel Machek <pavel@ucw.cz>
Handled-By : Marcel Holtmann <marcel@holtmann.org>
Patch : http://lkml.org/lkml/2007/1/2/147
Status : patch available
Subject : PCI_MULTITHREAD_PROBE breakage
References : http://lkml.org/lkml/2006/12/12/21
Submitter : Ben Castricum <mail0612@bencastricum.nl>
Caused-By : Greg Kroah-Hartman <gregkh@suse.de>
commit 009af1ff78bfc30b9a27807dd0207fc32848218a
Handled-By : Greg Kroah-Hartman <gregkh@suse.de>
Status : patch available
^ permalink raw reply [flat|nested] 56+ messages in thread
* 2.6.20-rc3: known unfixed regressions (v3)
2007-01-01 1:19 Happy New Year (and v2.6.20-rc3 released) Linus Torvalds
` (11 preceding siblings ...)
2007-01-03 21:04 ` 2.6.20-rc3: known regressions with patches (v2) Adrian Bunk
@ 2007-01-04 17:46 ` Adrian Bunk
2007-01-04 18:13 ` Matthew Wilcox
2007-01-05 0:25 ` Horst H. von Brand
2007-01-06 21:04 ` 2.6.20-rc3: known unfixed regressions (v4) Adrian Bunk
13 siblings, 2 replies; 56+ messages in thread
From: Adrian Bunk @ 2007-01-04 17:46 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton
Cc: Linux Kernel Mailing List, Jon Smirl, Damien Wyart,
Aaron Sethman, alan, linux-ide, Berthold Cogel, len.brown,
linux-acpi, Florin Iucha, greg, linux-usb-devel, dmitry.torokhov,
linux-input, James.Bottomley, linux-scsi, Komuro,
YOSHIFUJI Hideaki, netdev, Tobias Diedrich, Andi Kleen,
Yinghai Lu, Eric W. Biederman, discuss, mingo
This email lists some known regressions in 2.6.20-rc3 compared to 2.6.19
that are not yet fixed in Linus' tree.
If you find your name in the Cc header, you are either submitter of one
of the bugs, maintainer of an affectected subsystem or driver, a patch
of you caused a breakage or I'm considering you in any other way possibly
involved with one or more of these issues.
Due to the huge amount of recipients, please trim the Cc when answering.
Subject : BUG: scheduling while atomic: hald-addon-stor/...
cdrom_{open,release,ioctl} in trace
References : http://lkml.org/lkml/2006/12/26/105
http://lkml.org/lkml/2006/12/29/22
http://lkml.org/lkml/2006/12/31/133
Submitter : Jon Smirl <jonsmirl@gmail.com>
Damien Wyart <damien.wyart@free.fr>
Aaron Sethman <androsyn@ratbox.org>
Status : unknown
Subject : Acer Extensa 3002 WLMi: 'shutdown -h now' reboots the system
References : http://lkml.org/lkml/2006/12/25/40
Submitter : Berthold Cogel <cogel@rrz.uni-koeln.de>
Status : unknown
Subject : USB keyboard unresponsive after some time
References : http://lkml.org/lkml/2006/12/25/35
http://lkml.org/lkml/2006/12/26/106
Submitter : Florin Iucha <florin@iucha.net>
Status : unknown
Subject : SPARC64: Can't mount / (CONFIG_SCSI_SCAN_ASYNC=y ?)
References : http://lkml.org/lkml/2006/12/13/181
http://lkml.org/lkml/2007/01/04/75
Submitter : Horst H. von Brand <vonbrand@inf.utfsm.cl>
Status : unknown
Subject : ftp: get or put stops during file-transfer
References : http://lkml.org/lkml/2006/12/16/174
Submitter : Komuro <komurojun-mbn@nifty.com>
Caused-By : YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
commit cfb6eeb4c860592edd123fdea908d23c6ad1c7dc
Handled-By : YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Status : problem is being debugged
Subject : x86_64 boot failure: "IO-APIC + timer doesn't work"
References : http://lkml.org/lkml/2006/12/16/101
http://lkml.org/lkml/2007/1/3/9
Submitter : Tobias Diedrich <ranma+kernel@tdiedrich.de>
Caused-By : Andi Kleen <ak@suse.de>
commit b026872601976f666bae77b609dc490d1834bf77
Handled-By : Yinghai Lu <yinghai.lu@amd.com>
Eric W. Biederman <ebiederm@xmission.com>
Status : patches are being discussed
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: 2.6.20-rc3: known unfixed regressions (v3)
2007-01-04 17:46 ` 2.6.20-rc3: known unfixed regressions (v3) Adrian Bunk
@ 2007-01-04 18:13 ` Matthew Wilcox
2007-01-05 0:25 ` Horst H. von Brand
1 sibling, 0 replies; 56+ messages in thread
From: Matthew Wilcox @ 2007-01-04 18:13 UTC (permalink / raw)
To: Horst H. von Brand; +Cc: linux-kernel, linux-scsi
On Thu, Jan 04, 2007 at 06:46:32PM +0100, Adrian Bunk wrote:
> Subject : SPARC64: Can't mount / (CONFIG_SCSI_SCAN_ASYNC=y ?)
> References : http://lkml.org/lkml/2006/12/13/181
> http://lkml.org/lkml/2007/01/04/75
> Submitter : Horst H. von Brand <vonbrand@inf.utfsm.cl>
> Status : unknown
It'd be nice if people bothered to cc authors on bug reports, eh?
It seems to me that you're building scsi as modules. In which case
you need to follow the instructions in the help text to load the
scsi_wait_scan module. Or just say 'n' to the CONFIG_SCSI_SCAN_ASYNC
option, of course.
You're right that the quotes need to disappear from the Kconfig help
text as they're just confusing.
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 60f5827..103d0da 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -230,6 +230,7 @@ config SCSI_SCAN_ASYNC
The SCSI subsystem can probe for devices while the rest of the
system continues booting, and even probe devices on different
busses in parallel, leading to a significant speed-up.
+
If you have built SCSI as modules, enabling this option can
be a problem as the devices may not have been found by the
time your system expects them to have been. You can load the
@@ -237,8 +238,8 @@ config SCSI_SCAN_ASYNC
If you build your SCSI drivers into the kernel, then everything
will work fine if you say Y here.
- You can override this choice by specifying scsi_mod.scan="sync"
- or "async" on the kernel's command line.
+ You can override this choice by specifying "scsi_mod.scan=sync"
+ or async on the kernel's command line.
menu "SCSI Transports"
depends on SCSI
^ permalink raw reply related [flat|nested] 56+ messages in thread
* Re: 2.6.20-rc3: known unfixed regressions (v3)
2007-01-04 17:46 ` 2.6.20-rc3: known unfixed regressions (v3) Adrian Bunk
2007-01-04 18:13 ` Matthew Wilcox
@ 2007-01-05 0:25 ` Horst H. von Brand
1 sibling, 0 replies; 56+ messages in thread
From: Horst H. von Brand @ 2007-01-05 0:25 UTC (permalink / raw)
To: Adrian Bunk
Cc: Linus Torvalds, Andrew Morton, Linux Kernel Mailing List, sparclinux
Adrian Bunk <bunk@stusta.de> wrote:
> This email lists some known regressions in 2.6.20-rc3 compared to 2.6.19
> that are not yet fixed in Linus' tree.
>
> If you find your name in the Cc header, you are either submitter of one
> of the bugs, maintainer of an affectected subsystem or driver, a patch
> of you caused a breakage or I'm considering you in any other way possibly
> involved with one or more of these issues.
>
> Due to the huge amount of recipients, please trim the Cc when answering.
[...]
> Subject : SPARC64: Can't mount / (CONFIG_SCSI_SCAN_ASYNC=y ?)
> References : http://lkml.org/lkml/2006/12/13/181
> http://lkml.org/lkml/2007/01/04/75
> Submitter : Horst H. von Brand <vonbrand@inf.utfsm.cl>
> Status : unknown
Fixed in 2.6.20-rc3 (perhaps was due to SCSI_SCAN_ASYNC)
--
Dr. Horst H. von Brand User #22616 counter.li.org
Departamento de Informatica Fono: +56 32 2654431
Universidad Tecnica Federico Santa Maria +56 32 2654239
Casilla 110-V, Valparaiso, Chile Fax: +56 32 2797513
^ permalink raw reply [flat|nested] 56+ messages in thread
* 2.6.20-rc3: known unfixed regressions (v4)
2007-01-01 1:19 Happy New Year (and v2.6.20-rc3 released) Linus Torvalds
` (12 preceding siblings ...)
2007-01-04 17:46 ` 2.6.20-rc3: known unfixed regressions (v3) Adrian Bunk
@ 2007-01-06 21:04 ` Adrian Bunk
2007-01-06 22:06 ` Brice Goglin
13 siblings, 1 reply; 56+ messages in thread
From: Adrian Bunk @ 2007-01-06 21:04 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton
Cc: Linux Kernel Mailing List, Tobias Diedrich, Andi Kleen,
Yinghai Lu, Eric W. Biederman, mingo, discuss, Jon Smirl,
Damien Wyart, Aaron Sethman, alan, linux-ide, Uwe Bugla,
Florin Iucha, greg, linux-usb-devel, dmitry.torokhov,
linux-input, Berthold Cogel, Alexey Starikovskiy, len.brown,
linux-acpi, Komuro, YOSHIFUJI Hideaki, netdev, Hugh Dickins,
Marcus Meissner
This email lists some known regressions in 2.6.20-rc3 compared to 2.6.19
that are not yet fixed in Linus' tree.
If you find your name in the Cc header, you are either submitter of one
of the bugs, maintainer of an affectected subsystem or driver, a patch
of you caused a breakage or I'm considering you in any other way possibly
involved with one or more of these issues.
Due to the huge amount of recipients, please trim the Cc when answering.
Subject : x86_64 boot failure: "IO-APIC + timer doesn't work"
References : http://lkml.org/lkml/2006/12/16/101
http://lkml.org/lkml/2007/1/3/9
Submitter : Tobias Diedrich <ranma+kernel@tdiedrich.de>
Caused-By : Andi Kleen <ak@suse.de>
commit b026872601976f666bae77b609dc490d1834bf77
Handled-By : Yinghai Lu <yinghai.lu@amd.com>
Eric W. Biederman <ebiederm@xmission.com>
Status : patches are being discussed
Subject : BUG: scheduling while atomic: hald-addon-stor/...
cdrom_{open,release,ioctl} in trace
References : http://lkml.org/lkml/2006/12/26/105
http://lkml.org/lkml/2006/12/29/22
http://lkml.org/lkml/2006/12/31/133
Submitter : Jon Smirl <jonsmirl@gmail.com>
Damien Wyart <damien.wyart@free.fr>
Aaron Sethman <androsyn@ratbox.org>
Status : unknown
Subject : problems with CD burning
References : http://www.spinics.net/lists/linux-ide/msg06545.html
Submitter : Uwe Bugla <uwe.bugla@gmx.de>
Status : unknown
Subject : USB keyboard unresponsive after some time
References : http://lkml.org/lkml/2006/12/25/35
http://lkml.org/lkml/2006/12/26/106
Submitter : Florin Iucha <florin@iucha.net>
Status : unknown
Subject : Acer Extensa 3002 WLMi: 'shutdown -h now' reboots the system
References : http://lkml.org/lkml/2006/12/25/40
Submitter : Berthold Cogel <cogel@rrz.uni-koeln.de>
Handled-By : Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>
Status : problem is being debugged
Subject : ftp: get or put stops during file-transfer
References : http://lkml.org/lkml/2006/12/16/174
Submitter : Komuro <komurojun-mbn@nifty.com>
Caused-By : YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
commit cfb6eeb4c860592edd123fdea908d23c6ad1c7dc
Handled-By : YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Status : problem is being debugged
Subject : PIE randomization causes random failures of kernel compiles
References : http://lkml.org/lkml/2007/1/6/124
Submitter : Hugh Dickins <hugh@veritas.com>
Caused-By : Marcus Meissner <meissner@suse.de>
commit 59287c0913cc9a6c75712a775f6c1c1ef418ef3b
Handled-By : Hugh Dickins <hugh@veritas.com>
Patch : http://lkml.org/lkml/2007/1/6/124
Status : patch was suggested
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: 2.6.20-rc3: known unfixed regressions (v4)
2007-01-06 21:04 ` 2.6.20-rc3: known unfixed regressions (v4) Adrian Bunk
@ 2007-01-06 22:06 ` Brice Goglin
2007-01-07 23:49 ` Adrian Bunk
0 siblings, 1 reply; 56+ messages in thread
From: Brice Goglin @ 2007-01-06 22:06 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Linus Torvalds, Andrew Morton, Linux Kernel Mailing List
Adrian Bunk wrote:
> This email lists some known regressions in 2.6.20-rc3 compared to 2.6.19
> that are not yet fixed in Linus' tree.
>
I reported another one yesterday, about HT MSI capability lookup being
broken (can only find the first one in the chain). See
http://lkml.org/lkml/2007/1/5/215. The patch works well here, but I
didn't get any comment so far.
The regression has been confirmed by Robert Hancock.
Brice
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: 2.6.20-rc3: known unfixed regressions (v4)
2007-01-06 22:06 ` Brice Goglin
@ 2007-01-07 23:49 ` Adrian Bunk
0 siblings, 0 replies; 56+ messages in thread
From: Adrian Bunk @ 2007-01-07 23:49 UTC (permalink / raw)
To: Brice Goglin; +Cc: Linus Torvalds, Andrew Morton, Linux Kernel Mailing List
On Sat, Jan 06, 2007 at 11:06:46PM +0100, Brice Goglin wrote:
> Adrian Bunk wrote:
> > This email lists some known regressions in 2.6.20-rc3 compared to 2.6.19
> > that are not yet fixed in Linus' tree.
> >
>
> I reported another one yesterday, about HT MSI capability lookup being
> broken (can only find the first one in the chain). See
> http://lkml.org/lkml/2007/1/5/215. The patch works well here, but I
> didn't get any comment so far.
>
> The regression has been confirmed by Robert Hancock.
Thanks, added to my list.
> Brice
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 56+ messages in thread