* [PATCH 7/11] Vmi timer race
@ 2007-02-06 3:53 Zachary Amsden
0 siblings, 0 replies; only message in thread
From: Zachary Amsden @ 2007-02-06 3:53 UTC (permalink / raw)
To: Linux Kernel Mailing List, Andrew Morton, Andi Kleen,
Rusty Russell, Jeremy Fitzhardinge, Chris Wright, Zachary Amsden
Because timer code moves around, and we might eventually move our init to a
late_time_init hook, save and restore IRQs around this code because it is
definitely not interrupt safe.
Signed-off-by: Zachary Amsden <zach@vmware.com>
diff -r dd4d4324a5b3 arch/i386/kernel/vmitime.c
--- a/arch/i386/kernel/vmitime.c Thu Feb 01 23:53:06 2007 -0800
+++ b/arch/i386/kernel/vmitime.c Fri Feb 02 00:03:05 2007 -0800
@@ -178,7 +178,9 @@ void __init vmi_time_init(void)
void __init vmi_time_init(void)
{
unsigned long long cycles_per_sec, cycles_per_msec;
-
+ unsigned long flags;
+
+ local_irq_save(flags);
setup_irq(0, &vmi_timer_irq);
#ifdef CONFIG_X86_LOCAL_APIC
set_intr_gate(LOCAL_TIMER_VECTOR, apic_vmi_timer_interrupt);
@@ -222,6 +224,8 @@ void __init vmi_time_init(void)
VMI_ALARM_WIRED_IRQ0 | VMI_ALARM_IS_PERIODIC | VMI_CYCLES_AVAILABLE,
per_cpu(process_times_cycles_accounted_cpu, 0) + cycles_per_alarm,
cycles_per_alarm);
+
+ local_irq_restore(flags);
}
#ifdef CONFIG_X86_LOCAL_APIC
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-02-06 3:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-06 3:53 [PATCH 7/11] Vmi timer race Zachary Amsden
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).