From: Paul Mundt <lethal@linux-sh.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: akpm@linux-foundation.org, linux-mm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [QUICKLIST 1/4] Generic quicklist implementation
Date: Tue, 13 Mar 2007 18:05:46 +0900 [thread overview]
Message-ID: <20070313090546.GA4511@linux-sh.org> (raw)
In-Reply-To: <20070313071330.4920.54914.sendpatchset@schroedinger.engr.sgi.com>
On Tue, Mar 13, 2007 at 12:13:30AM -0700, Christoph Lameter wrote:
> --- linux-2.6.21-rc3-mm2.orig/mm/Kconfig 2007-03-12 22:49:21.000000000 -0700
> +++ linux-2.6.21-rc3-mm2/mm/Kconfig 2007-03-13 00:09:50.000000000 -0700
> @@ -220,3 +220,8 @@ config DEBUG_READAHEAD
>
> Say N for production servers.
>
> +config QUICKLIST
> + bool
> + default y if NR_QUICK != 0
> +
> +
This doesn't work, and so CONFIG_QUICKLIST is always set. The NR_QUICK
thing seems a bit backwards anyways, perhaps it would make more sense to
have architectures set CONFIG_GENERIC_QUICKLIST in the same way that the
other GENERIC_xxx bits are defined, and then set NR_QUICK based off of
that. It's obviously going to be 2 or 1 for most people, and x86 seems to
be the only one that needs 2.
How about this?
--
diff --git a/mm/Kconfig b/mm/Kconfig
index 7942b33..2f20860 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -163,3 +163,8 @@ config ZONE_DMA_FLAG
default "0" if !ZONE_DMA
default "1"
+config NR_QUICK
+ int
+ depends on GENERIC_QUICKLIST
+ default "2" if X86
+ default "1"
next prev parent reply other threads:[~2007-03-13 9:08 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-13 7:13 [QUICKLIST 0/4] Arch independent quicklists V2 Christoph Lameter
2007-03-13 7:13 ` [QUICKLIST 1/4] Generic quicklist implementation Christoph Lameter
2007-03-13 9:05 ` Paul Mundt [this message]
2007-03-15 20:51 ` Christoph Lameter
2007-03-13 7:13 ` [QUICKLIST 2/4] Quicklist support for i386 Christoph Lameter
2007-03-13 7:13 ` [QUICKLIST 3/4] Quicklist support for x86_64 Christoph Lameter
2007-03-13 7:13 ` [QUICKLIST 4/4] Quicklist support for sparc64 Christoph Lameter
2007-03-13 8:53 ` [QUICKLIST 0/4] Arch independent quicklists V2 Andrew Morton
2007-03-13 8:03 ` Nick Piggin
2007-03-13 11:52 ` Andrew Morton
2007-03-13 11:06 ` Nick Piggin
2007-03-13 12:15 ` Andrew Morton
2007-03-13 11:20 ` Christoph Lameter
2007-03-13 12:30 ` Andrew Morton
2007-03-15 20:23 ` Christoph Lameter
2007-03-13 11:30 ` Nick Piggin
2007-03-13 12:47 ` Andrew Morton
2007-03-13 12:01 ` Nick Piggin
2007-03-13 13:11 ` Andrew Morton
2007-03-13 12:18 ` Nick Piggin
2007-03-13 17:30 ` Jeremy Fitzhardinge
2007-03-13 20:03 ` Matt Mackall
2007-03-13 20:17 ` Jeremy Fitzhardinge
2007-03-13 20:21 ` Matt Mackall
2007-03-13 21:07 ` David Miller
2007-03-13 21:14 ` Matt Mackall
2007-03-13 21:36 ` Jeremy Fitzhardinge
2007-03-13 21:46 ` Peter Chubb
2007-03-13 21:48 ` David Miller
2007-03-14 1:12 ` William Lee Irwin III
2007-03-15 23:12 ` William Lee Irwin III
2007-03-13 23:58 ` Paul Mackerras
2007-03-13 11:17 ` Christoph Lameter
2007-03-13 12:27 ` Andrew Morton
2007-03-15 20:28 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070313090546.GA4511@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).