Suspend to disk bug 2.6.21-rc2-git1

Suspend to disk bug 2.6.21-rc2-git1

[Lukas Hejtmanek]

Hello, 

I'm not sure what version did exacly caused susped to disk problems but
anyway, in 2.6.21-rc2-git1, suspend to disk breaks ACPI. ACPI events do not
even emit ACPI interrupts. Suspend to ram works nicely.

-- 
Lukáš Hejtmánek

Re: Suspend to disk bug 2.6.21-rc2-git1

[Pavel Machek]

Hi!

> I'm not sure what version did exacly caused susped to disk problems but
> anyway, in 2.6.21-rc2-git1, suspend to disk breaks ACPI. ACPI events do not
> even emit ACPI interrupts. Suspend to ram works nicely.

Is 2.6.21-latest better?  There were many problems in suspend area,
hopefully they are slowly being fixed...

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: Suspend to disk bug 2.6.21-rc2-git1

[Lukas Hejtmanek]

On Sat, Mar 10, 2007 at 11:16:39PM +0100, Pavel Machek wrote:
> Hi!
> 
> > I'm not sure what version did exacly caused susped to disk problems but
> > anyway, in 2.6.21-rc2-git1, suspend to disk breaks ACPI. ACPI events do not
> > even emit ACPI interrupts. Suspend to ram works nicely.
> 
> Is 2.6.21-latest better?  There were many problems in suspend area,
> hopefully they are slowly being fixed...

2.6.21-rc3-git with platform (previous method was reboot) method works OK.

-- 
Lukáš Hejtmánek

Re: Suspend to disk bug 2.6.21-rc2-git1

[Lukas Hejtmanek]

Hello,

On Sat, Mar 10, 2007 at 11:16:39PM +0100, Pavel Machek wrote:
> > I'm not sure what version did exacly caused susped to disk problems but
> > anyway, in 2.6.21-rc2-git1, suspend to disk breaks ACPI. ACPI events do not
> > even emit ACPI interrupts. Suspend to ram works nicely.
> 
> Is 2.6.21-latest better?  There were many problems in suspend area,
> hopefully they are slowly being fixed...

I've found out that only platform method is working. reboot method does not.

-- 
Lukáš Hejtmánek

Re: Suspend to disk bug 2.6.21-rc2-git1

[Pavel Machek]

Hi!

> > > I'm not sure what version did exacly caused susped to disk problems but
> > > anyway, in 2.6.21-rc2-git1, suspend to disk breaks ACPI. ACPI events do not
> > > even emit ACPI interrupts. Suspend to ram works nicely.
> > 
> > Is 2.6.21-latest better?  There were many problems in suspend area,
> > hopefully they are slowly being fixed...
> 
> I've found out that only platform method is working. reboot method does not.

Try this one.
									Pavel

Fix reboot mode blinking moon icon after resume.

---
commit 5958dbea2ea6147f4fd0477b303be752d5c4f53a
tree 9c032e050d09201f66e1706fef4d7bbe8e55c418
parent 2744ccbdcc03f36d193fe20fc17698cfb2a1acea
author Pavel <pavel@amd.ucw.cz> Tue, 20 Mar 2007 16:33:03 +0100
committer Pavel <pavel@amd.ucw.cz> Tue, 20 Mar 2007 16:33:03 +0100

 kernel/power/disk.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/kernel/power/disk.c b/kernel/power/disk.c
index 873cdf8..dee0ff4 100644
--- a/kernel/power/disk.c
+++ b/kernel/power/disk.c
@@ -241,18 +241,11 @@ static int software_resume(void)
 		goto Done;
 	}
 
-	error = platform_prepare();
-	if (error) {
-		swsusp_free();
-		goto Thaw;
-	}
-
 	pr_debug("PM: Reading swsusp image.\n");
 
 	error = swsusp_read();
 	if (error) {
 		swsusp_free();
-		platform_finish();
 		goto Thaw;
 	}
 
@@ -270,7 +263,6 @@ static int software_resume(void)
 	enable_nonboot_cpus();
  Free:
 	swsusp_free();
-	platform_finish();
 	device_resume();
 	resume_console();
  Thaw:

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: Suspend to disk bug 2.6.21-rc2-git1

[Pavel Machek]

Hi!

> > > > > I'm not sure what version did exacly caused susped to disk problems but
> > > > > anyway, in 2.6.21-rc2-git1, suspend to disk breaks ACPI. ACPI events do not
> > > > > even emit ACPI interrupts. Suspend to ram works nicely.
> > > > 
> > > > Is 2.6.21-latest better?  There were many problems in suspend area,
> > > > hopefully they are slowly being fixed...
> > > 
> > > I've found out that only platform method is working. reboot method does not.
> > 
> > Try this one.
> 
> Good idea.
> 
> BTW, we didn't use "platform" during the resume in 2.6.20, so I think this
> patch should go into 2.6.21.

Yes, I think so. Do you or I do the akpm submission?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: Suspend to disk bug 2.6.21-rc2-git1

[Rafael J. Wysocki]

On Wednesday, 21 March 2007 23:39, Pavel Machek wrote:
> Hi!
> 
> > > > I'm not sure what version did exacly caused susped to disk problems but
> > > > anyway, in 2.6.21-rc2-git1, suspend to disk breaks ACPI. ACPI events do not
> > > > even emit ACPI interrupts. Suspend to ram works nicely.
> > > 
> > > Is 2.6.21-latest better?  There were many problems in suspend area,
> > > hopefully they are slowly being fixed...
> > 
> > I've found out that only platform method is working. reboot method does not.
> 
> Try this one.

Good idea.

BTW, we didn't use "platform" during the resume in 2.6.20, so I think this
patch should go into 2.6.21.

Greetings,
Rafael


-- 
If you don't have the time to read,
you don't have the time or the tools to write.
		- Stephen King

Re: Suspend to disk bug 2.6.21-rc2-git1

[Lukas Hejtmanek]

On Wed, Mar 21, 2007 at 11:39:08PM +0100, Pavel Machek wrote:
> > > > I'm not sure what version did exacly caused susped to disk problems but
> > > > anyway, in 2.6.21-rc2-git1, suspend to disk breaks ACPI. ACPI events do not
> > > > even emit ACPI interrupts. Suspend to ram works nicely.
> > > 
> > > Is 2.6.21-latest better?  There were many problems in suspend area,
> > > hopefully they are slowly being fixed...
> > 
> > I've found out that only platform method is working. reboot method does not.
> 
> Try this one.

It seems to be OK. Thanks.

-- 
Lukáš Hejtmánek