From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
hch@infradead.org, Adrian Bunk <bunk@stusta.de>
Subject: Re: [patch 02/10] Linux Kernel Markers, architecture independent code.
Date: Thu, 10 May 2007 08:58:40 -0400 [thread overview]
Message-ID: <20070510125840.GB22424@Krystal> (raw)
In-Reply-To: <20070510051043.GA6640@martell.zuzino.mipt.ru>
Hi Alexey,
* Alexey Dobriyan (adobriyan@gmail.com) wrote:
> On Wed, May 09, 2007 at 09:55:57PM -0400, Mathieu Desnoyers wrote:
> > --- /dev/null
> > +++ linux-2.6-lttng/include/linux/marker.h
> > @@ -0,0 +1,124 @@
>
> > +#ifdef __KERNEL__
>
> Just don't add this file to include/linux/Kbuild and remove __KERNEL__
> ifdef.
>
> > --- linux-2.6-lttng.orig/include/linux/module.h
> > +++ linux-2.6-lttng/include/linux/module.h
> > @@ -356,6 +356,9 @@
> > /* The command line arguments (may be mangled). People like
> > keeping pointers to this stuff */
> > char *args;
> > +
> > + const struct __mark_marker *markers;
> > + unsigned int num_markers;
>
> #ifdef CONFIG_MARKERS, please.
>
Ok, I merged the patch from SystemTAP to help them parse the markers
section, but seeing the violent objections it gets, I guess they will
have to figure out another way to parse it. Let's drop the
allow-userspace-applications-to-use-markerh-to-parse-the-markers-section-in-the-kernel-binary.patch
then.
> > --- linux-2.6-lttng.orig/kernel/module.c
> > +++ linux-2.6-lttng/kernel/module.c
>
> > @@ -1659,6 +1884,9 @@
> > unsigned int unusedcrcindex;
> > unsigned int unusedgplindex;
> > unsigned int unusedgplcrcindex;
> > + unsigned int markersindex;
> > + unsigned int markersdataindex;
> > + unsigned int markersstringsindex;
>
> Bunch of underscores wouldn't hurt.
>
Hrm, I used the exact same variable naming style already present in the
function. Do you suggest changing _every_ variable name to underscores ?
> > +void list_modules(void)
> > +{
> > + /* Enumerate loaded modules */
> > + struct list_head *i;
> > + struct module *mod;
> > + unsigned long refcount = 0;
> > +
> > + mutex_lock(&module_mutex);
> > + list_for_each(i, &modules) {
> > + mod = list_entry(i, struct module, list);
> > +#ifdef CONFIG_MODULE_UNLOAD
> > + refcount = local_read(&mod->ref[0].count);
> ^
> Buy second CPU, already. ;-)
>
Good catch, will fix. I do already have more than one, don't worry ;)
> > +#endif //CONFIG_MODULE_UNLOAD
> > + trace_mark(list_module, "%s %d %lu",
> > + mod->name, mod->state, refcount);
> > + }
> > + mutex_unlock(&module_mutex);
> > +}
>
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next prev parent reply other threads:[~2007-05-10 13:03 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-10 1:55 [patch 00/10] Linux Kernel Markers for 2.6.21-mm2 Mathieu Desnoyers
2007-05-10 1:55 ` [patch 01/10] Linux Kernel Markers - Add kconfig menus for the marker code Mathieu Desnoyers
2007-05-10 6:57 ` Christoph Hellwig
2007-05-10 1:55 ` [patch 02/10] Linux Kernel Markers, architecture independent code Mathieu Desnoyers
2007-05-10 5:10 ` Alexey Dobriyan
2007-05-10 12:58 ` Mathieu Desnoyers [this message]
2007-05-10 13:12 ` Mathieu Desnoyers
2007-05-10 19:00 ` Alexey Dobriyan
2007-05-10 19:46 ` Mathieu Desnoyers
2007-05-10 1:55 ` [patch 03/10] Allow userspace applications to use marker.h to parse the markers section in the kernel binary Mathieu Desnoyers
2007-05-10 6:51 ` Christoph Hellwig
2007-05-10 22:14 ` David Smith
2007-06-23 8:09 ` Christoph Hellwig
2007-06-23 9:25 ` Alan Cox
2007-06-23 9:32 ` Christoph Hellwig
2007-06-23 9:49 ` Alan Cox
2007-06-23 10:06 ` Christoph Hellwig
2007-06-23 14:55 ` Alan Cox
2007-05-10 1:55 ` [patch 04/10] Linux Kernel Markers - PowerPC optimized version Mathieu Desnoyers
2007-05-10 6:57 ` Christoph Hellwig
2007-05-10 1:56 ` [patch 05/10] Linux Kernel Markers - i386 " Mathieu Desnoyers
2007-05-10 9:06 ` Andi Kleen
2007-05-10 15:55 ` Mathieu Desnoyers
2007-05-10 16:28 ` Alan Cox
2007-05-10 16:59 ` Mathieu Desnoyers
2007-05-11 4:57 ` Ananth N Mavinakayanahalli
2007-05-11 18:55 ` Mathieu Desnoyers
2007-05-12 5:29 ` Suparna Bhattacharya
2007-05-11 6:04 ` Andi Kleen
2007-05-11 18:02 ` Mathieu Desnoyers
2007-05-11 21:56 ` Alan Cox
2007-05-13 15:20 ` Mathieu Desnoyers
2007-05-10 1:56 ` [patch 06/10] Linux Kernel Markers - Non optimized architectures Mathieu Desnoyers
2007-05-10 5:13 ` Alexey Dobriyan
2007-05-10 6:56 ` Christoph Hellwig
2007-05-10 13:11 ` Mathieu Desnoyers
2007-05-10 13:40 ` Alan Cox
2007-05-10 14:25 ` Mathieu Desnoyers
2007-05-10 15:33 ` Nicholas Berry
2007-05-10 16:09 ` Alan Cox
2007-05-10 1:56 ` [patch 07/10] Linux Kernel Markers - Documentation Mathieu Desnoyers
2007-05-10 6:58 ` Christoph Hellwig
2007-05-10 11:41 ` Alan Cox
2007-05-10 11:41 ` Christoph Hellwig
2007-05-10 12:48 ` Alan Cox
2007-05-10 12:52 ` Pekka Enberg
2007-05-10 13:04 ` Alan Cox
2007-05-10 13:16 ` Pekka J Enberg
2007-05-10 13:43 ` Alan Cox
2007-05-10 14:04 ` Pekka J Enberg
2007-05-10 14:12 ` Mathieu Desnoyers
2007-05-10 14:14 ` Mathieu Desnoyers
2007-05-11 15:05 ` Valdis.Kletnieks
2007-05-10 12:00 ` Christoph Hellwig
2007-05-10 15:51 ` Scott Preece
2007-05-10 1:56 ` [patch 08/10] Defines the linker macro EXTRA_RWDATA for the marker data section Mathieu Desnoyers
2007-05-10 1:56 ` [patch 09/10] Linux Kernel Markers - Use EXTRA_RWDATA in architectures Mathieu Desnoyers
2007-05-10 1:56 ` [patch 10/10] Port of blktrace to the Linux Kernel Markers Mathieu Desnoyers
2007-05-10 6:53 ` Christoph Hellwig
2007-05-10 9:20 ` Jens Axboe
2007-05-10 2:30 ` [patch 00/10] Linux Kernel Markers for 2.6.21-mm2 Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070510125840.GB22424@Krystal \
--to=mathieu.desnoyers@polymtl.ca \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bunk@stusta.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).