Re: spurious completions during NCQ?

Re: spurious completions during NCQ?

[Robert Hancock]

Florin Iucha wrote:
> Hello,
> 
> I was working on a I/O heavy workload (parsing 100K spam messages to
> extract certain structures) when I got this in the kernel log:

..

> 
> This is on a Thinkpad T60 with 2 GB RAM, running Ubuntu 7.04 (kernel
> 2.6.20-16-generic).  No proprietary drivers (ok, maybe the Intel
> Wi-Fi - but that should not count).
> 
> The laptop came with Windows but I blew that away - did I mess some
> thing up regarding HPA and its ilk?

It means the drive reported command tags were completed that were not 
outstanding. What kind of drive is this?

-- 
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/

Re: spurious completions during NCQ?

[Florin Iucha]

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]

On Wed, Jun 06, 2007 at 08:28:07AM -0600, Robert Hancock wrote:
> >This is on a Thinkpad T60 with 2 GB RAM, running Ubuntu 7.04 (kernel
> >2.6.20-16-generic).  No proprietary drivers (ok, maybe the Intel
> >Wi-Fi - but that should not count).
> >
> >The laptop came with Windows but I blew that away - did I mess some
> >thing up regarding HPA and its ilk?
> 
> It means the drive reported command tags were completed that were not 
> outstanding. What kind of drive is this?

[   29.033142] ata1.00: ata_hpa_resize 1: sectors = 156301488, hpa_sectors = 156
301488
[   29.033146] ata1.00: ATA-7: HITACHI HTS541680J9SA00, SB2IC7EP, max UDMA/100
[   29.033149] ata1.00: 156301488 sectors, multi 16: LBA48 NCQ (depth 31/32)
[   29.034230] ata1.00: ata_hpa_resize 1: sectors = 156301488, hpa_sectors = 156
301488

florin

-- 
Bruce Schneier expects the Spanish Inquisition.
      http://geekz.co.uk/schneierfacts/fact/163

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: spurious completions during NCQ?

[Tejun Heo]

Florin Iucha wrote:
> On Wed, Jun 06, 2007 at 08:28:07AM -0600, Robert Hancock wrote:
>>> This is on a Thinkpad T60 with 2 GB RAM, running Ubuntu 7.04 (kernel
>>> 2.6.20-16-generic).  No proprietary drivers (ok, maybe the Intel
>>> Wi-Fi - but that should not count).
>>>
>>> The laptop came with Windows but I blew that away - did I mess some
>>> thing up regarding HPA and its ilk?
>> It means the drive reported command tags were completed that were not 
>> outstanding. What kind of drive is this?
> 
> [   29.033142] ata1.00: ata_hpa_resize 1: sectors = 156301488, hpa_sectors = 156
> 301488
> [   29.033146] ata1.00: ATA-7: HITACHI HTS541680J9SA00, SB2IC7EP, max UDMA/100
> [   29.033149] ata1.00: 156301488 sectors, multi 16: LBA48 NCQ (depth 31/32)
> [   29.034230] ata1.00: ata_hpa_resize 1: sectors = 156301488, hpa_sectors = 156
> 301488

Please report the result of 'hdparm -I /dev/sda'.  We'll probably have
to blacklist it for NCQ.

-- 
tejun

Re: spurious completions during NCQ?

[Florin Iucha]

[-- Attachment #1: Type: text/plain, Size: 3317 bytes --]

On Fri, Jun 08, 2007 at 09:55:58PM +0900, Tejun Heo wrote:
> Florin Iucha wrote:
> >> It means the drive reported command tags were completed that were not 
> >> outstanding. What kind of drive is this?
> > 
> > [   29.033142] ata1.00: ata_hpa_resize 1: sectors = 156301488, hpa_sectors = 156
> > 301488
> > [   29.033146] ata1.00: ATA-7: HITACHI HTS541680J9SA00, SB2IC7EP, max UDMA/100
> > [   29.033149] ata1.00: 156301488 sectors, multi 16: LBA48 NCQ (depth 31/32)
> > [   29.034230] ata1.00: ata_hpa_resize 1: sectors = 156301488, hpa_sectors = 156
> > 301488
> 
> Please report the result of 'hdparm -I /dev/sda'.  We'll probably have
> to blacklist it for NCQ.

Here it is: I only jumbled the serial number a bit.

/dev/sda:

ATA device, with non-removable media
	Model Number:       HITACHI HTS541680J9SA00                 
	Serial Number:      SB******I57L4A
	Firmware Revision:  SB2IC7EP
Standards:
	Used: ATA/ATAPI-7 T13 1532D revision 1 
	Supported: 7 6 5 4 
Configuration:
	Logical		max	current
	cylinders	16383	16383
	heads		16	16
	sectors/track	63	63
	--
	CHS current addressable sectors:   16514064
	LBA    user addressable sectors:  156301488
	LBA48  user addressable sectors:  156301488
	device size with M = 1024*1024:       76319 MBytes
	device size with M = 1000*1000:       80026 MBytes (80 GB)
Capabilities:
	LBA, IORDY(can be disabled)
	Queue depth: 32
	Standby timer values: spec'd by Vendor, no device specific minimum
	R/W multiple sector transfer: Max = 16	Current = 16
	Advanced power management level: 128 (0x80)
	Recommended acoustic management value: 128, current value: 254
	DMA: mdma0 mdma1 mdma2 udma0 udma1 udma2 udma3 udma4 *udma5 
	     Cycle time: min=120ns recommended=120ns
	PIO: pio0 pio1 pio2 pio3 pio4 
	     Cycle time: no flow control=120ns  IORDY flow control=120ns
Commands/features:
	Enabled	Supported:
	   *	SMART feature set
	    	Security Mode feature set
	   *	Power Management feature set
	   *	Write cache
	   *	Look-ahead
	   *	Host Protected Area feature set
	   *	WRITE_BUFFER command
	   *	READ_BUFFER command
	   *	NOP cmd
	   *	DOWNLOAD_MICROCODE
	   *	Advanced Power Management feature set
	    	SET_MAX security extension
	    	Automatic Acoustic Management feature set
	   *	48-bit Address feature set
	   *	Device Configuration Overlay feature set
	   *	Mandatory FLUSH_CACHE
	   *	FLUSH_CACHE_EXT
	   *	SMART error logging
	   *	SMART self-test
	   *	General Purpose Logging feature set
	   *	WRITE_{DMA|MULTIPLE}_FUA_EXT
	   *	64-bit World wide name
	   *	IDLE_IMMEDIATE with UNLOAD
	   *	SATA-I signaling speed (1.5Gb/s)
	   *	Native Command Queueing (NCQ)
	   *	Host-initiated interface power management
	   *	Phy event counters
	    	Non-Zero buffer offsets in DMA Setup FIS
	    	DMA Setup Auto-Activate optimization
	    	Device-initiated interface power management
	    	In-order data delivery
	   *	Software settings preservation
Security: 
	Master password revision code = 65534
		supported
	not	enabled
	not	locked
		frozen
	not	expired: security count
	not	supported: enhanced erase
	42min for SECURITY ERASE UNIT. 
Checksum: correct

florin

-- 
Bruce Schneier expects the Spanish Inquisition.
      http://geekz.co.uk/schneierfacts/fact/163

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[PATCH] libata: disable NCQ for HITACHI HTS541680J9SA00/SB21C7EP

[Tejun Heo]

HITACHI HTS541680J9SA00/SB21C7EP spuriously completes NCQ commands.
Blacklist it for NCQ.

Signed-off-by: Tejun Heo <htejun@gmail.com>
---
 drivers/ata/libata-core.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 636df4e..880cdd3 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -3787,6 +3787,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	{ "HTS541060G9SA00",    "MB3OC60D",     ATA_HORKAGE_NONCQ, },
 	{ "HTS541080G9SA00",    "MB4OC60D",     ATA_HORKAGE_NONCQ, },
 	{ "HTS541010G9SA00",    "MBZOC60D",     ATA_HORKAGE_NONCQ, },
+	/* Drives which do spurious command completion */
+	{ "HTS541680J9SA00",	"SB2IC7EP",	ATA_HORKAGE_NONCQ, },
 
 	/* Devices with NCQ limits */
 

Re: spurious completions during NCQ?

[Alan Cox]

> 	Model Number:       HITACHI HTS541680J9SA00                 
> 	Serial Number:      SB******I57L4A

This one is already blacklisted in the windows drivers.

Re: [PATCH] libata: disable NCQ for HITACHI HTS541680J9SA00/SB21C7EP

[Alan Cox]

On Fri, 8 Jun 2007 22:20:59 +0900
Tejun Heo <htejun@gmail.com> wrote:

> HITACHI HTS541680J9SA00/SB21C7EP spuriously completes NCQ commands.
> Blacklist it for NCQ.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>

Acked-by: Alan Cox <alan@redhat.com>

Re: [PATCH] libata: disable NCQ for HITACHI HTS541680J9SA00/SB21C7EP

[Jeff Garzik]

Tejun Heo wrote:
> HITACHI HTS541680J9SA00/SB21C7EP spuriously completes NCQ commands.
> Blacklist it for NCQ.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
>  drivers/ata/libata-core.c |    2 ++
>  1 file changed, 2 insertions(+)

applied

Re: spurious completions during NCQ?

[Massimiliano Hofer]

On Friday 8 June 2007, Alan Cox wrote:

> > 	Model Number:       HITACHI HTS541680J9SA00
> > 	Serial Number:      SB******I57L4A
>
> This one is already blacklisted in the windows drivers.

I have the same problem with this drive (shipped with a Thinkpad Z61m):

        Model Number:       HITACHI HTS541612J9SA00
        Firmware Revision:  SBDIC7JP

It reported several dozen spurious completions over a few days, but I can't 
find any corruption. Is it really dangerous? I understand this clearly is a 
firmware bug, but I'm not sure how to interpret the drive behavior.
I can perform any test you like, if you find it useful.

-- 
Saluti,
   Massimiliano Hofer

Re: spurious completions during NCQ?

[Tejun Heo]

Massimiliano Hofer wrote:
> On Friday 8 June 2007, Alan Cox wrote:
> 
>>> 	Model Number:       HITACHI HTS541680J9SA00
>>> 	Serial Number:      SB******I57L4A
>> This one is already blacklisted in the windows drivers.
> 
> I have the same problem with this drive (shipped with a Thinkpad Z61m):
> 
>         Model Number:       HITACHI HTS541612J9SA00
>         Firmware Revision:  SBDIC7JP
> 
> It reported several dozen spurious completions over a few days, but I can't 
> find any corruption. Is it really dangerous? I understand this clearly is a 
> firmware bug, but I'm not sure how to interpret the drive behavior.
> I can perform any test you like, if you find it useful.

It has _slight_ change of being dangerous and is just in violation of
the protocol.  No real data corruption case reported yet tho.  Till now
most drives which report such problems had stinky NCQ implementation
anyway - slow, buggy, blacklisted in the other OS, etc...  I'll submit a
patch to blacklist the drive.

Thanks.

-- 
tejun