From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: nigel@nigel.suspend2.net, linux-kernel@vger.kernel.org,
suspend-devel List <suspend-devel@lists.sourceforge.net>,
akpm@linux-foundation.org, Stefan Seyfried <seife@suse.de>
Subject: Re: [Suspend-devel] [PATCH, 3rd try] make disable_console_suspend runtime configurable
Date: Sun, 17 Jun 2007 23:49:40 +0200 [thread overview]
Message-ID: <20070617214940.GA1951@elf.ucw.cz> (raw)
In-Reply-To: <20070617213530.GE1803@elf.ucw.cz>
Hi!
> > > I hate having to recompile the kernel, just to be able to debug suspend.
> > > Remove CONFIG_DISABLE_CONSOLE_SUSPEND, replace it by a tunable in
> > > /sys/power/disable_console_suspend.
> > >
> > >
> > > Signed-off-by: Stefan Seyfried <seife@suse.de>
> > > Signed-off-by: Frank Seidel <fseidel@suse.de>
> > > ---
> > > Third try, renamed sysfs interface to console_suspend
> > > reporting and expecting either "enabled" or "disabled"
> >
> > Thanks a lot for redoing it.
> >
> > I have no objections. Pavel?
>
> I still think that patch is bad. I should have screamed when
> CONFIG_DISABLE_CONSOLE_SUSPEND went into kernel. That beast should
> _not_ be configurable, it should just do the right thing.
>
> But I realized that too late. And this only makes it works, making
> that mistake part of user-kernel interface.
>
> Sorry for not screaming when CONFIG_DISABLE_CONSOLE_SUSPEND went in,
> but please lets solve this correctly....
Ouch and sorry for not screaming at "try 1" time. But it still does
not make the patch right, and I believe that even patch authors agree
that "no-config-needed" is superior solution.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-06-17 21:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-13 20:03 [PATCH, 2nd try] make disable_console_suspend runtime configurable Stefan Seyfried
2007-06-13 21:36 ` Rafael J. Wysocki
2007-06-13 22:08 ` Pavel Machek
2007-06-13 22:23 ` Stefan Seyfried
2007-06-13 23:09 ` Rafael J. Wysocki
2007-06-14 12:14 ` Rafael J. Wysocki
2007-06-14 13:59 ` [PATCH, 3rd " Frank Seidel
2007-06-14 22:20 ` Rafael J. Wysocki
2007-06-17 21:35 ` Pavel Machek
2007-06-17 21:49 ` Pavel Machek [this message]
2007-06-18 5:27 ` [Suspend-devel] " Stefan Seyfried
2007-06-21 13:20 ` Pavel Machek
2007-06-21 21:14 ` Stefan Seyfried
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070617214940.GA1951@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nigel@nigel.suspend2.net \
--cc=rjw@sisk.pl \
--cc=seife@suse.de \
--cc=suspend-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).