linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wang Zhenyu <zhenyu.z.wang@intel.com>
To: Carlo Wood <carlo@alinoe.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Dave Jones <davej@redhat.com>,
	linux-kernel@vger.kernel.org, eric@anholt.net,
	lethal@linux-sh.org, y-goto@jp.fujitsu.com
Subject: Re: 2.6.22-rc5 regression
Date: Wed, 20 Jun 2007 09:15:21 +0800	[thread overview]
Message-ID: <20070620011521.GB2856@zhen-devel.sh.intel.com> (raw)
In-Reply-To: <20070619233716.GA5779@alinoe.com>

On 2007.06.20 01:37:16 +0000, Carlo Wood wrote:
> The result of this patch is that the kernel starts to print
> "agpgart: Detected an Intel 965G Chipset." again with the usual
> disastrous results. Now, that doesn't mean that this patch is
> wrong - but it explains why the problem returns after this patch.
> 

Yep, the device table patch doesn't change any function, so your problem
started from when 965G support patch has been in kernel. 

Carlo, pls try a kernel param of "pci=nommconf" to see if that could
fix your hang. There might be a BIOS bug, as similar issue also happen
like https://bugzilla.novell.com/show_bug.cgi?id=228683

I think for i965 we could have following patch to fix this, we may
fail if no IGD device got detected. 

Signed-off-by: Wang Zhenyu <zhenyu.z.wang@intel.com>
---
diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c
index 0439ee9..5a54a9c 100644
--- a/drivers/char/agp/intel-agp.c
+++ b/drivers/char/agp/intel-agp.c
@@ -1855,15 +1855,15 @@ static const struct intel_driver_description {
 	{ PCI_DEVICE_ID_INTEL_82946GZ_HB, PCI_DEVICE_ID_INTEL_82946GZ_IG, 0, "946GZ",
 		&intel_845_driver, &intel_i965_driver },
 	{ PCI_DEVICE_ID_INTEL_82965G_1_HB, PCI_DEVICE_ID_INTEL_82965G_1_IG, 0, "965G",
-		&intel_845_driver, &intel_i965_driver },
+		NULL, &intel_i965_driver },
 	{ PCI_DEVICE_ID_INTEL_82965Q_HB, PCI_DEVICE_ID_INTEL_82965Q_IG, 0, "965Q",
-		&intel_845_driver, &intel_i965_driver },
+		NULL, &intel_i965_driver },
 	{ PCI_DEVICE_ID_INTEL_82965G_HB, PCI_DEVICE_ID_INTEL_82965G_IG, 0, "965G",
-		&intel_845_driver, &intel_i965_driver },
+		NULL, &intel_i965_driver },
 	{ PCI_DEVICE_ID_INTEL_82965GM_HB, PCI_DEVICE_ID_INTEL_82965GM_IG, 1, "965GM",
-		&intel_845_driver, &intel_i965_driver },
+		NULL, &intel_i965_driver },
 	{ PCI_DEVICE_ID_INTEL_82965GM_HB, PCI_DEVICE_ID_INTEL_82965GME_IG, 0, "965GME/GLE",
-		&intel_845_driver, &intel_i965_driver },
+		NULL, &intel_i965_driver },
 	{ PCI_DEVICE_ID_INTEL_7505_0, 0, 0, "E7505", &intel_7505_driver, NULL },
 	{ PCI_DEVICE_ID_INTEL_7205_0, 0, 0, "E7205", &intel_7505_driver, NULL },
 	{ PCI_DEVICE_ID_INTEL_G33_HB, PCI_DEVICE_ID_INTEL_G33_IG, 0, "G33",
@@ -1917,6 +1917,7 @@ static int __devinit agp_intel_probe(struct pci_dev *pdev,
 	}
 
 	if (bridge->driver == NULL) {
+		/* The bridge has no AGP or no gfx device */
 		printk(KERN_WARNING PFX "Failed to find bridge device "
 			"(chip_id: %04x)\n", intel_agp_chipsets[i].gmch_chip_id);
 		agp_put_bridge(bridge);
---

  parent reply	other threads:[~2007-06-20  1:16 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-17 18:22 2.6.22-rc5 regression Carlo Wood
2007-06-17 19:58 ` Carlo Wood
2007-06-17 21:49   ` Carlo Wood
2007-06-17 23:18     ` Paul Mundt
2007-06-18  0:10       ` Carlo Wood
2007-06-18  0:25         ` Paul Mundt
2007-06-18  7:01           ` Sean
2007-06-18 17:01     ` Linus Torvalds
2007-06-18 18:12       ` Carlo Wood
2007-06-18 18:15         ` Carlo Wood
2007-06-18 18:35         ` Linus Torvalds
2007-06-18 19:54           ` Carlo Wood
2007-06-18 20:42             ` Linus Torvalds
2007-06-18 22:30               ` Daniel Barkalow
2007-06-18 22:50               ` Carlo Wood
2007-06-18 22:57                 ` Linus Torvalds
2007-06-19 23:37                   ` Carlo Wood
2007-06-19 23:44                     ` Dave Jones
2007-06-20  0:09                     ` Linus Torvalds
2007-06-20 13:11                       ` Carlo Wood
2007-06-20 13:31                         ` Carlo Wood
2007-06-20  1:15                     ` Wang Zhenyu [this message]
2007-06-20  1:42                       ` Wang Zhenyu
2007-06-20 14:02                         ` Carlo Wood
2007-06-20 15:46                           ` Wang Zhenyu
2007-06-21  5:43                             ` [PATCH][AGPGART] intel_agp: don't load if no IGD and AGP port Wang Zhenyu
2007-06-21 16:10                               ` Carlo Wood
2007-06-22  0:55                                 ` Wang Zhenyu
2007-06-23 16:52                               ` Andrew Morton
2007-06-23 18:42                                 ` Dave Jones
2007-06-23 18:50                                   ` Andrew Morton
2007-06-23 19:06                                     ` Dave Jones
2007-06-25  1:01                                     ` Wang Zhenyu
2007-06-20 13:22                       ` 2.6.22-rc5 regression Carlo Wood
2007-06-20 13:58                       ` Carlo Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070620011521.GB2856@zhen-devel.sh.intel.com \
    --to=zhenyu.z.wang@intel.com \
    --cc=carlo@alinoe.com \
    --cc=davej@redhat.com \
    --cc=eric@anholt.net \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=y-goto@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).