From: Linus Torvalds <torvalds@linux-foundation.org>
To: Carlo Wood <carlo@alinoe.com>
Cc: Dave Jones <davej@redhat.com>,
linux-kernel@vger.kernel.org, eric@anholt.net,
zhenyu.z.wang@intel.com, lethal@linux-sh.org,
y-goto@jp.fujitsu.com
Subject: Re: 2.6.22-rc5 regression
Date: Mon, 18 Jun 2007 13:42:18 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.98.0706181332400.3593@woody.linux-foundation.org> (raw)
In-Reply-To: <20070618195415.GA7481@alinoe.com>
On Mon, 18 Jun 2007, Carlo Wood wrote:
>
> Well,... when, and because, it's not a linear thing as you mentioned
> before - it's not necessarily precisely a cut into half... so I thought,
> seeing those weird (not half) numbers that that was the cause.
You're correct - "git bisect" will not always be able to find an exact
half-way point, and I was wrong to imply that it will always be quite that
close.
It's easily off by a few commits because of merges that make it harder to
find a good bisection point, but it should never (practically) be off by
quite as much as you saw.
For example, I could expect that from 127 commits, it would go down to 70
rather than 64. But not to 110 - not unless there are some *really*
strange patterns with lots of criss-crossing merges.
And indeed, for me, using the same commit ID's as you used, I see a nice
bisection to just about exactly half.
> > It might be worth it just making sure your git is ok. It really is acting
> > oddly. What version is it?
>
> git version 1.4.4.4
You really do want to use git-1.5.x these days.
It does look like 1.4.4.4 may have a bug, although I'm really surprised:
we've certainly tweaked stuff in bisection, but I and others have used
"git bisect" since long before the git-1.4 days, and it has always worked
ok. So I wonder if it's something specific to that debian build.
Or possibly to the fact that you have some other dirty state (you might
want to do a "git diff HEAD" to see what the changes are, and maybe a "git
checkout -f" to get rid of any differences)
> I am using Debian (suite 'testing') and trying to be a debian purist -
> so it isn't like I can easily upgrade to 1.5.x : there is no debian
> package for that version in 'testing'.
I'm surprised that debuan
>
> Nevertheless, if you think it's important - then I can download and
> compile a tar ball of course - certainly when I don't have to install
> it to test it.
>
> --
> Carlo Wood <carlo@alinoe.com>
>
> PS The result of 'git diff' is:
>
> diff --git a/include/asm-blackfin/macros.h b/include/asm-blackfin/macros.h
> deleted file mode 100644
> index e69de29..0000000
Ok, something deleted an empty file. Probably "make distclean". Our "make
clean" is sometimes too aggressive, and we generally shouldn't have empty
files.
> diff --git a/scripts/package/Makefile b/scripts/package/Makefile
> index 7c434e0..f758b75 100644
> --- a/scripts/package/Makefile
> +++ b/scripts/package/Makefile
but this one has actually been modified. To this:
> +# Dummy file
> +help:
And finally,
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> deleted file mode 100644
> index 6edb29f..0000000
That one also has been actually deleted. And "make distclean" doesn't do
that. You have something else going on.
Linus
next prev parent reply other threads:[~2007-06-18 20:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-17 18:22 2.6.22-rc5 regression Carlo Wood
2007-06-17 19:58 ` Carlo Wood
2007-06-17 21:49 ` Carlo Wood
2007-06-17 23:18 ` Paul Mundt
2007-06-18 0:10 ` Carlo Wood
2007-06-18 0:25 ` Paul Mundt
2007-06-18 7:01 ` Sean
2007-06-18 17:01 ` Linus Torvalds
2007-06-18 18:12 ` Carlo Wood
2007-06-18 18:15 ` Carlo Wood
2007-06-18 18:35 ` Linus Torvalds
2007-06-18 19:54 ` Carlo Wood
2007-06-18 20:42 ` Linus Torvalds [this message]
2007-06-18 22:30 ` Daniel Barkalow
2007-06-18 22:50 ` Carlo Wood
2007-06-18 22:57 ` Linus Torvalds
2007-06-19 23:37 ` Carlo Wood
2007-06-19 23:44 ` Dave Jones
2007-06-20 0:09 ` Linus Torvalds
2007-06-20 13:11 ` Carlo Wood
2007-06-20 13:31 ` Carlo Wood
2007-06-20 1:15 ` Wang Zhenyu
2007-06-20 1:42 ` Wang Zhenyu
2007-06-20 14:02 ` Carlo Wood
2007-06-20 15:46 ` Wang Zhenyu
2007-06-21 5:43 ` [PATCH][AGPGART] intel_agp: don't load if no IGD and AGP port Wang Zhenyu
2007-06-21 16:10 ` Carlo Wood
2007-06-22 0:55 ` Wang Zhenyu
2007-06-23 16:52 ` Andrew Morton
2007-06-23 18:42 ` Dave Jones
2007-06-23 18:50 ` Andrew Morton
2007-06-23 19:06 ` Dave Jones
2007-06-25 1:01 ` Wang Zhenyu
2007-06-20 13:22 ` 2.6.22-rc5 regression Carlo Wood
2007-06-20 13:58 ` Carlo Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.98.0706181332400.3593@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=carlo@alinoe.com \
--cc=davej@redhat.com \
--cc=eric@anholt.net \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=y-goto@jp.fujitsu.com \
--cc=zhenyu.z.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).