linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Joerg Schilling <Joerg.Schilling@fokus.fraunhofer.de>
Cc: arjan@infradead.org, linux-kernel@vger.kernel.org,
	schilling@fokus.fraunhofer.de
Subject: Re: Linux Kernel include files
Date: Wed, 27 Jun 2007 19:18:12 +0200	[thread overview]
Message-ID: <20070627171812.GA31705@uranus.ravnborg.org> (raw)
In-Reply-To: <46826d13.44vmeDzVCWEJhtNJ%Joerg.Schilling@fokus.fraunhofer.de>

On Wed, Jun 27, 2007 at 03:58:43PM +0200, Joerg Schilling wrote:
> Sam Ravnborg <sam@ravnborg.org> wrote:
> 
> > On Mon, Jun 25, 2007 at 04:53:55PM +0200, Joerg Schilling wrote:
> > > 
> > > star needs "ext2_fs.h". This file is not usable at all on many Linux 
> > > distributions, even with GCC.
> >
> > I was curious so I did:
> >
> > $ mkdir ~/foo
> > $ cd ~/kernel/linux-2.6
> > $ make INSTALL_HDR_PATH=~/foo
> > $ cd ~/foo
> > $ cat j.c
> > #include <stdio.h>
> > #include "etx2_fs.h"
> >
> > main()
> > {
> > 	printf("helloo\n");
> > }
> >
> > $ gcc -o j j.c
> > => No warning, no errors
> >
> 
> On Suse Linux 10.0, I get e.g.:
> 
> cat t.c
> #include <stdio.h>
> #include <linux/ext2_fs.h>
> 
> gcc -c t.c
> In file included from /usr/include/linux/ext2_fs.h:20,
>                  from t.c:2:
> /usr/include/linux/ext2_fs_sb.h:40: error: syntax error before âuid_tâ
> /usr/include/linux/ext2_fs_sb.h:49: error: syntax error before âs_next_generationâ
> /usr/include/linux/ext2_fs_sb.h:51: error: syntax error before â*â token
> /usr/include/linux/ext2_fs_sb.h:56: error: syntax error before â}â token

Hi Jörg.

For my test I used latest -git of the Linux kernel.
In this version the include of ext2_fs_bh.h is guarded
by __KERNEL__ like this:

#ifdef __KERNEL__
#include <linux/ext2_fs_sb.h>
static inline struct ext2_sb_info *EXT2_SB(struct super_block *sb)
{
        return sb->s_fs_info;
}

And therefore the include statement is removed in the exported set of kernel
include files.
So this particular issue is solved with the latest kernel and using the headers
prepared for export.

This tells me that we are on the right track with exporting the headers and sanitize them.

	Sam

  parent reply	other threads:[~2007-06-27 17:17 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-27 13:58 Linux Kernel include files Joerg Schilling
2007-06-27 16:40 ` Adrian Bunk
2007-06-27 16:41   ` Joerg Schilling
2007-06-27 18:50     ` Arjan van de Ven
2007-06-27 17:18 ` Sam Ravnborg [this message]
2007-06-28 10:47   ` Joerg Schilling
2007-06-28 13:49   ` Jan Engelhardt
2007-06-29 12:59     ` David Woodhouse
     [not found] <8AGnE-33a-13@gated-at.bofh.it>
     [not found] ` <8AIfO-63r-29@gated-at.bofh.it>
     [not found]   ` <8AZJA-7BV-3@gated-at.bofh.it>
     [not found]     ` <8AZJA-7BV-1@gated-at.bofh.it>
     [not found]       ` <8AZJQ-7BV-15@gated-at.bofh.it>
     [not found]         ` <8AZTo-7OT-3@gated-at.bofh.it>
     [not found]           ` <8B4T2-7py-37@gated-at.bofh.it>
2007-07-01  9:47             ` Bodo Eggert
     [not found] <8AGnE-33a-15@gated-at.bofh.it>
     [not found] ` <8AISu-6Qn-31@gated-at.bofh.it>
     [not found]   ` <8AISu-6Qn-29@gated-at.bofh.it>
     [not found]     ` <8AKUp-1wx-41@gated-at.bofh.it>
2007-06-27 22:35       ` Bodo Eggert
2007-06-27 23:07         ` Arjan van de Ven
  -- strict thread matches above, loose matches on Subject: below --
2007-06-27 14:00 Joerg Schilling
2007-06-27 16:04 ` David Woodhouse
2007-06-28 10:27   ` Joerg Schilling
2007-06-28 10:37     ` David Woodhouse
2007-06-28 10:39       ` Joerg Schilling
2007-06-28 10:57         ` Jan-Benedict Glaw
2007-06-28 16:15           ` Jan Engelhardt
2007-06-27 13:45 Joerg Schilling
2007-06-27 22:16 ` H. Peter Anvin
2007-06-21 22:32 Joerg Schilling
2007-06-21 23:25 ` david
2007-06-21 23:38   ` Joerg Schilling
2007-06-22  3:38     ` David Woodhouse
2007-06-22  5:18       ` H. Peter Anvin
2007-06-22 15:00       ` Adrian Bunk
2007-06-26 15:26         ` H. Peter Anvin
2007-06-27  1:32         ` Kyle Moffett
2007-06-27 15:40           ` Adrian Bunk
2007-06-27 15:52             ` Joerg Schilling
2007-06-27 15:59               ` Robert P. J. Day
2007-06-28  4:02           ` H. Peter Anvin
2007-06-25 15:17       ` Joerg Schilling
2007-06-25 15:27         ` David Woodhouse
2007-06-25 18:04           ` Harald Arnesen
2007-06-25 20:26             ` Joerg Schilling
2007-06-25 20:32               ` David Woodhouse
2007-06-25 21:43               ` Harald Arnesen
2007-06-25 21:48                 ` Harald Arnesen
2007-06-25 21:49                   ` Joerg Schilling
2007-06-25 22:30                     ` Harald Arnesen
2007-06-25 22:42                       ` Joerg Schilling
2007-06-21 23:59   ` Arnd Bergmann
2007-06-25 15:06     ` Joerg Schilling
2007-06-25 16:00       ` david
2007-06-25 14:48   ` Joerg Schilling
2007-06-21 23:47 ` Arjan van de Ven
2007-06-25 14:53   ` Joerg Schilling
2007-06-25 15:26     ` Arjan van de Ven
2007-06-25 15:27       ` Robert P. J. Day
2007-06-25 20:18     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070627171812.GA31705@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=Joerg.Schilling@fokus.fraunhofer.de \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schilling@fokus.fraunhofer.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).