* [PATCH] i2o: defined but not used.
@ 2007-07-20 22:58 Sebastian Siewior
2007-07-21 10:31 ` Andrew Morton
0 siblings, 1 reply; 5+ messages in thread
From: Sebastian Siewior @ 2007-07-20 22:58 UTC (permalink / raw)
To: linux-kernel
[-- Attachment #1: i2o_exec_lct_notify_def_not_used.patch --]
[-- Type: text/plain, Size: 1124 bytes --]
Got with randconfig
drivers/message/i2o/exec-osm.c:539: warning: 'i2o_exec_lct_notify' defined but
not used
Signed-off-by: Sebastian Siewior <sebastian@breakpoint.cc>
Index: b/drivers/message/i2o/exec-osm.c
===================================================================
--- a/drivers/message/i2o/exec-osm.c
+++ b/drivers/message/i2o/exec-osm.c
@@ -389,9 +389,7 @@ static void i2o_exec_lct_modified(struct
if (i2o_device_parse_lct(c) != -EAGAIN)
change_ind = c->lct->change_ind + 1;
-#ifdef CONFIG_I2O_LCT_NOTIFY_ON_CHANGES
i2o_exec_lct_notify(c, change_ind);
-#endif
};
/**
@@ -525,6 +523,7 @@ int i2o_exec_lct_get(struct i2o_controll
return rc;
}
+#ifdef CONFIG_I2O_LCT_NOTIFY_ON_CHANGES
/**
* i2o_exec_lct_notify - Send a asynchronus LCT NOTIFY request
* @c: I2O controller to which the request should be send
@@ -570,6 +569,13 @@ static int i2o_exec_lct_notify(struct i2
return 0;
};
+#else
+static int i2o_exec_lct_notify(struct i2o_controller *c, u32 change_ind)
+{
+ return 0;
+}
+#endif
+
/* Exec OSM driver struct */
struct i2o_driver i2o_exec_driver = {
.name = OSM_NAME,
--
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i2o: defined but not used.
2007-07-20 22:58 [PATCH] i2o: defined but not used Sebastian Siewior
@ 2007-07-21 10:31 ` Andrew Morton
2007-07-21 11:18 ` Sebastian Siewior
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Andrew Morton @ 2007-07-21 10:31 UTC (permalink / raw)
To: Sebastian Siewior; +Cc: linux-kernel
On Sat, 21 Jul 2007 00:58:01 +0200 Sebastian Siewior <sebastian@breakpoint.cc> wrote:
> Got with randconfig
randconfig apparently generates impossible configs. Please always
run `make oldconfig' after the randconfig, then do the test build.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i2o: defined but not used.
2007-07-21 10:31 ` Andrew Morton
@ 2007-07-21 11:18 ` Sebastian Siewior
2007-07-21 23:10 ` Randy Dunlap
2007-07-26 20:47 ` Roman Zippel
2 siblings, 0 replies; 5+ messages in thread
From: Sebastian Siewior @ 2007-07-21 11:18 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
* Andrew Morton | 2007-07-21 03:31:33 [-0700]:
>On Sat, 21 Jul 2007 00:58:01 +0200 Sebastian Siewior <sebastian@breakpoint.cc> wrote:
>
>> Got with randconfig
>
>randconfig apparently generates impossible configs. Please always
>run `make oldconfig' after the randconfig, then do the test build.
Ah okey, I did not know this.
CONFIG_I2O=y
# CONFIG_I2O_LCT_NOTIFY_ON_CHANGES is not set
Is still in my .config after oldconfig.
Sebastian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i2o: defined but not used.
2007-07-21 10:31 ` Andrew Morton
2007-07-21 11:18 ` Sebastian Siewior
@ 2007-07-21 23:10 ` Randy Dunlap
2007-07-26 20:47 ` Roman Zippel
2 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2007-07-21 23:10 UTC (permalink / raw)
To: Andrew Morton; +Cc: Sebastian Siewior, linux-kernel
On Sat, 21 Jul 2007 03:31:33 -0700 Andrew Morton wrote:
> On Sat, 21 Jul 2007 00:58:01 +0200 Sebastian Siewior <sebastian@breakpoint.cc> wrote:
>
> > Got with randconfig
>
> randconfig apparently generates impossible configs. Please always
> run `make oldconfig' after the randconfig, then do the test build.
This one is not impossible. Patch looks good.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i2o: defined but not used.
2007-07-21 10:31 ` Andrew Morton
2007-07-21 11:18 ` Sebastian Siewior
2007-07-21 23:10 ` Randy Dunlap
@ 2007-07-26 20:47 ` Roman Zippel
2 siblings, 0 replies; 5+ messages in thread
From: Roman Zippel @ 2007-07-26 20:47 UTC (permalink / raw)
To: Andrew Morton; +Cc: Sebastian Siewior, linux-kernel
Hi,
On Saturday 21 July 2007, Andrew Morton wrote:
> On Sat, 21 Jul 2007 00:58:01 +0200 Sebastian Siewior
<sebastian@breakpoint.cc> wrote:
> > Got with randconfig
>
> randconfig apparently generates impossible configs. Please always
> run `make oldconfig' after the randconfig, then do the test build.
If that should make any difference, that would be a bug and I'd like to see
that .config.
bye, Roman
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-07-26 20:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-20 22:58 [PATCH] i2o: defined but not used Sebastian Siewior
2007-07-21 10:31 ` Andrew Morton
2007-07-21 11:18 ` Sebastian Siewior
2007-07-21 23:10 ` Randy Dunlap
2007-07-26 20:47 ` Roman Zippel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).