* [PATCH] 2.6.24-rc2-mm1 powerpc (iseries)- build failure - mm/stab.c
@ 2007-11-14 10:54 Kamalesh Babulal
2007-11-19 2:38 ` Stephen Rothwell
0 siblings, 1 reply; 4+ messages in thread
From: Kamalesh Babulal @ 2007-11-14 10:54 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, anton, linuxppc-dev, paulus, apw
Hi Andrew,
The kernel builds fails with following error, with randconfig
CC arch/powerpc/mm/stab.o
arch/powerpc/mm/stab.c: In function ‘stab_initialize’:
arch/powerpc/mm/stab.c:282: error: implicit declaration of function ‘HvCall1’
arch/powerpc/mm/stab.c:282: error: ‘HvCallBaseSetASR’ undeclared (first use in this function)
arch/powerpc/mm/stab.c:282: error: (Each undeclared identifier is reported only once
arch/powerpc/mm/stab.c:282: error: for each function it appears in.)
make[1]: *** [arch/powerpc/mm/stab.o] Error 1
make: *** [arch/powerpc/mm] Error 2
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
--
--- linux-2.6.24-rc2/arch/powerpc/mm/stab.c 2007-11-14 05:22:55.000000000 -0500
+++ linux-2.6.24-rc2/arch/powerpc/mm/~stab.c 2007-11-14 05:23:18.000000000 -0500
@@ -21,6 +21,10 @@
#include <asm/abs_addr.h>
#include <asm/firmware.h>
+#ifdef CONFIG_PPC_ISERIES
+#include <asm/iseries/hv_call.h>
+#endif /* CONFIG_PPC_ISERIES */
+
struct stab_entry {
unsigned long esid_data;
unsigned long vsid_data;
--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] 2.6.24-rc2-mm1 powerpc (iseries)- build failure - mm/stab.c
2007-11-14 10:54 [PATCH] 2.6.24-rc2-mm1 powerpc (iseries)- build failure - mm/stab.c Kamalesh Babulal
@ 2007-11-19 2:38 ` Stephen Rothwell
2007-11-19 6:26 ` [PATCH-RESEND] " Kamalesh Babulal
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2007-11-19 2:38 UTC (permalink / raw)
To: Kamalesh Babulal; +Cc: akpm, linuxppc-dev, anton, paulus, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 427 bytes --]
Hi Kamalesh,
On Wed, 14 Nov 2007 16:24:10 +0530 Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
>
> +#ifdef CONFIG_PPC_ISERIES
> +#include <asm/iseries/hv_call.h>
> +#endif /* CONFIG_PPC_ISERIES */
You should not need the #ifdef and we prefer not to ifdef include unless
necessary. Please resubmit.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH-RESEND] 2.6.24-rc2-mm1 powerpc (iseries)- build failure - mm/stab.c
2007-11-19 2:38 ` Stephen Rothwell
@ 2007-11-19 6:26 ` Kamalesh Babulal
2007-11-19 6:44 ` [PATCH] " Stephen Rothwell
0 siblings, 1 reply; 4+ messages in thread
From: Kamalesh Babulal @ 2007-11-19 6:26 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Kamalesh Babulal, akpm, linuxppc-dev, anton, paulus, linux-kernel
Hi Stephen,
Resubmitting the patch titled
powerpc-iseries-build-failure-mm-stabc.patch in the -mm tree.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
--
--- linux-2.6.24-rc2/arch/powerpc/mm/stab.c 2007-11-07 03:27:46.000000000 +0530
+++ linux-2.6.24-rc2/arch/powerpc/mm/~stab.c 2007-11-19 19:43:55.000000000 +0530
@@ -20,6 +20,7 @@
#include <asm/lmb.h>
#include <asm/abs_addr.h>
#include <asm/firmware.h>
+#include <asm/iseries/hv_call.h>
struct stab_entry {
unsigned long esid_data;
--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] 2.6.24-rc2-mm1 powerpc (iseries)- build failure - mm/stab.c
2007-11-19 6:26 ` [PATCH-RESEND] " Kamalesh Babulal
@ 2007-11-19 6:44 ` Stephen Rothwell
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Rothwell @ 2007-11-19 6:44 UTC (permalink / raw)
To: paulus; +Cc: Kamalesh Babulal, anton, linux-kernel, linuxppc-dev, akpm
From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
The kernel builds fails with following error, with randconfig
CC arch/powerpc/mm/stab.o
arch/powerpc/mm/stab.c: In function ‘stab_initialize’:
arch/powerpc/mm/stab.c:282: error: implicit declaration of function ‘HvCall1’
arch/powerpc/mm/stab.c:282: error: ‘HvCallBaseSetASR’ undeclared (first use in this function)
arch/powerpc/mm/stab.c:282: error: (Each undeclared identifier is reported only once
arch/powerpc/mm/stab.c:282: error: for each function it appears in.)
make[1]: *** [arch/powerpc/mm/stab.o] Error 1
make: *** [arch/powerpc/mm] Error 2
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Acked-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
arch/powerpc/mm/stab.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
On Mon, 19 Nov 2007 11:56:11 +0530 Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
>
> Resubmitting the patch titled
> powerpc-iseries-build-failure-mm-stabc.patch in the -mm tree.
Paulus, this should be fine for merging like above.
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
diff --git a/arch/powerpc/mm/stab.c b/arch/powerpc/mm/stab.c
index 9e85bda..50448d5 100644
--- a/arch/powerpc/mm/stab.c
+++ b/arch/powerpc/mm/stab.c
@@ -20,6 +20,7 @@
#include <asm/lmb.h>
#include <asm/abs_addr.h>
#include <asm/firmware.h>
+#include <asm/iseries/hv_call.h>
struct stab_entry {
unsigned long esid_data;
--
1.5.3.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-11-19 6:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-11-14 10:54 [PATCH] 2.6.24-rc2-mm1 powerpc (iseries)- build failure - mm/stab.c Kamalesh Babulal
2007-11-19 2:38 ` Stephen Rothwell
2007-11-19 6:26 ` [PATCH-RESEND] " Kamalesh Babulal
2007-11-19 6:44 ` [PATCH] " Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).