From: Borislav Petkov <bbpetkov@yahoo.de>
To: Lucy McCoy <lucy@keyspan.com>
Cc: Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] keyspan: init termios properly
Date: Fri, 16 Nov 2007 07:24:13 +0100 [thread overview]
Message-ID: <20071116062413.GA6765@gollum.tnic> (raw)
In-Reply-To: <46954.192.168.1.71.1195161016.webmail@192.168.1.71>
On Thu, Nov 15, 2007 at 01:10:16PM -0800, Lucy McCoy wrote:
Hi Lucy,
> I'm not familiar with the termios stuff on Linux so can you take a look
> at the following modified code to see if this solves your NULL ptr problem?
will test the patch tomorrow and get back to you with results.
> Does cflag need to be set to anything other than CS8?
i'm not that familiar with serial port settings either, but IIRC the cflag is
used to set the requested byte size of the transferred chars (cf
http://en.wikipedia.org/wiki/Serial_port#Data_Bits). Thus, according to the
above CS8 is used for setting up transfer of any kind of data over the serial connection.
> Is keyspan_open_port() always followed by a keyspan_set_termios()?
err, you mean keyspan_open() ...
..and yes, almost all of the usb to serial converter drivers call their own
*_set_termios-routine so that they could "synchronize" the line discipline user
settings with those of the converter.
--
Regards/Gruß,
Boris.
next prev parent reply other threads:[~2007-11-16 6:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 21:10 [PATCH] keyspan: init termios properly Lucy McCoy
2007-11-16 6:24 ` Borislav Petkov [this message]
2007-11-18 13:11 ` Borislav Petkov
2007-11-26 22:18 ` Andrew Morton
2007-11-30 5:45 ` Borislav Petkov
2007-11-30 17:23 ` Lucy McCoy
2007-12-02 8:03 ` Borislav Petkov
2007-12-02 13:57 ` Alan Cox
2007-12-02 17:40 ` Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2007-11-03 10:03 Borislav Petkov
2007-11-15 17:49 ` Lucy McCoy
2007-11-15 20:09 ` Andrew Morton
2007-11-15 20:28 ` Lucy McCoy
2007-11-15 20:40 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071116062413.GA6765@gollum.tnic \
--to=bbpetkov@yahoo.de \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucy@keyspan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).