[RFC/PATCH] Export force_sig_info

[RFC/PATCH] Export force_sig_info

[Jeremy Kerr]

This change allows force_sig_info to be called from modules.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

--

Any objections to exporting this symbol? I'm  planning to move some
SPU fault-handling code from the kernel to the spufs.ko object.

---

 kernel/signal.c |    1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6-spufs/kernel/signal.c
===================================================================
--- linux-2.6-spufs.orig/kernel/signal.c
+++ linux-2.6-spufs/kernel/signal.c
@@ -815,6 +815,7 @@ force_sig_info(int sig, struct siginfo *
 
 	return ret;
 }
+EXPORT_SYMBOL_GPL(force_sig_info);
 
 void
 force_sig_specific(int sig, struct task_struct *t)

Re: [RFC/PATCH] Export force_sig_info

[Andrew Morton]

On Mon, 12 Nov 2007 16:36:52 +1100 Jeremy Kerr <jk@ozlabs.org> wrote:

> This change allows force_sig_info to be called from modules.
> 
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
> 
> --
> 
> Any objections to exporting this symbol? I'm  planning to move some
> SPU fault-handling code from the kernel to the spufs.ko object.
> 
> ---
> 
>  kernel/signal.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: linux-2.6-spufs/kernel/signal.c
> ===================================================================
> --- linux-2.6-spufs.orig/kernel/signal.c
> +++ linux-2.6-spufs/kernel/signal.c
> @@ -815,6 +815,7 @@ force_sig_info(int sig, struct siginfo *
>  
>  	return ret;
>  }
> +EXPORT_SYMBOL_GPL(force_sig_info);
>  
>  void
>  force_sig_specific(int sig, struct task_struct *t)

Perhaps export it from within a powerpc-specific C file (along with
suitable comment) to prevent people from generally relying upon the export?

Re: [Cbe-oss-dev] [RFC/PATCH] Export force_sig_info

[Christoph Hellwig]

On Thu, Nov 22, 2007 at 11:41:41PM -0800, Andrew Morton wrote:
> Perhaps export it from within a powerpc-specific C file (along with
> suitable comment) to prevent people from generally relying upon the export?

Yes, please.  I don't like this beeing exported at all.

Re: [RFC/PATCH] Export force_sig_info

[Jeremy Kerr]

Hi Andrew,

> Perhaps export it from within a powerpc-specific C file (along with
> suitable comment) to prevent people from generally relying upon the
> export?

Even better, I'll export it from a Cell-specific C file. I'll follow 
this up in my own spufs series for .25.

Cheers,


Jeremy