* [PATCH] wait_task_zombie: remove ->exit_state/exit_signal checks for WNOWAIT
@ 2007-11-24 17:24 Oleg Nesterov
0 siblings, 0 replies; only message in thread
From: Oleg Nesterov @ 2007-11-24 17:24 UTC (permalink / raw)
To: Andrew Morton; +Cc: Roland McGrath, linux-kernel
The first "p->exit_state != EXIT_ZOMBIE" check doesn't make too much sense. The
exit_state was EXIT_ZOMBIE when the function was called, and another thread can
change it to EXIT_DEAD right after the check.
The second condition is not possible, detached non-traced threads were already
filtered out by eligible_child(), we didn't drop tasklist since then.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- PT/kernel/exit.c~8_wtz_dead_code 2007-11-24 19:28:11.000000000 +0300
+++ PT/kernel/exit.c 2007-11-24 20:02:27.000000000 +0300
@@ -1193,10 +1193,6 @@ static int wait_task_zombie(struct task_
int exit_code = p->exit_code;
int why, status;
- if (unlikely(p->exit_state != EXIT_ZOMBIE))
- return 0;
- if (unlikely(p->exit_signal == -1 && p->ptrace == 0))
- return 0;
get_task_struct(p);
read_unlock(&tasklist_lock);
if ((exit_code & 0x7f) == 0) {
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-11-24 17:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-11-24 17:24 [PATCH] wait_task_zombie: remove ->exit_state/exit_signal checks for WNOWAIT Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).