* Re: HMAC broken on s390
[not found] <1196688700.4799.5.camel@localhost.localdomain>
@ 2007-12-03 22:09 ` Herbert Xu
2007-12-04 8:25 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Herbert Xu @ 2007-12-03 22:09 UTC (permalink / raw)
To: Jan Glauber; +Cc: linux-crypto, Jens Axboe, Linux Kernel Mailing List
On Mon, Dec 03, 2007 at 02:31:40PM +0100, Jan Glauber wrote:
> Hi Herbert,
>
> commit 788fefa33b0b50581585925c53c230a36af35d0e in cryptodev breaks hmac
> on s390 du to the usage of sg_chain():
>
> static inline void sg_chain(struct scatterlist *prv, unsigned int prv_nents,
> struct scatterlist *sgl)
> {
> #ifndef ARCH_HAS_SG_CHAIN
> BUG();
> #endif
>
> ARCH_HAS_SG_CHAIN is false for s390 (and also for some other arch's).
>
> What should we do with this?
Looks like we took a step backwards because the chaining I had
before worked on all architectures :)
I suppose either we'll have to do our own chaining again or implement
it for all architectures. I'll look into this.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: HMAC broken on s390
2007-12-03 22:09 ` HMAC broken on s390 Herbert Xu
@ 2007-12-04 8:25 ` Jens Axboe
2007-12-04 8:51 ` Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2007-12-04 8:25 UTC (permalink / raw)
To: Herbert Xu; +Cc: Jan Glauber, linux-crypto, Linux Kernel Mailing List
On Tue, Dec 04 2007, Herbert Xu wrote:
> On Mon, Dec 03, 2007 at 02:31:40PM +0100, Jan Glauber wrote:
> > Hi Herbert,
> >
> > commit 788fefa33b0b50581585925c53c230a36af35d0e in cryptodev breaks hmac
> > on s390 du to the usage of sg_chain():
> >
> > static inline void sg_chain(struct scatterlist *prv, unsigned int prv_nents,
> > struct scatterlist *sgl)
> > {
> > #ifndef ARCH_HAS_SG_CHAIN
> > BUG();
> > #endif
> >
> > ARCH_HAS_SG_CHAIN is false for s390 (and also for some other arch's).
> >
> > What should we do with this?
>
> Looks like we took a step backwards because the chaining I had
> before worked on all architectures :)
>
> I suppose either we'll have to do our own chaining again or implement
> it for all architectures. I'll look into this.
You should continue to do your own chaining if it's a requirement for
the driver/layer to function, until we get rid of ARCH_HAS_SG_CHAIN.
That'll happen when all archs are converted.
So don't rely on scatterlist helping you with chaining just yet, sorry.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: HMAC broken on s390
2007-12-04 8:25 ` Jens Axboe
@ 2007-12-04 8:51 ` Herbert Xu
0 siblings, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2007-12-04 8:51 UTC (permalink / raw)
To: Jens Axboe; +Cc: Jan Glauber, linux-crypto, Linux Kernel Mailing List
On Tue, Dec 04, 2007 at 09:25:11AM +0100, Jens Axboe wrote:
>
> You should continue to do your own chaining if it's a requirement for
> the driver/layer to function, until we get rid of ARCH_HAS_SG_CHAIN.
> That'll happen when all archs are converted.
Thanks for the confirmation. I'll back out my conversion patch.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-12-04 8:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1196688700.4799.5.camel@localhost.localdomain>
2007-12-03 22:09 ` HMAC broken on s390 Herbert Xu
2007-12-04 8:25 ` Jens Axboe
2007-12-04 8:51 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).