From: Pete Zaitcev <zaitcev@redhat.com>
To: Jaime Velasco Juan <jsagarribay@gmail.com>
Cc: Oliver Neukum <oliver@neukum.org>,
Johann Wilhelm <johann.wilhelm@student.tugraz.at>,
Rui Santos <rsantos@grupopie.com>,
linux-usb@vger.kernel.org, preining@logic.at,
kristoffer.ericson@gmail.com, drussell@redhat.com,
linux-kernel@vger.kernel.org, greg@kroah.com, zaitcev@redhat.com
Subject: Re: [PATCH] USB: option: Bind to the correct interface of the Huawei E220
Date: Wed, 5 Dec 2007 08:34:23 -0800 [thread overview]
Message-ID: <20071205083423.ca6ef199.zaitcev@redhat.com> (raw)
In-Reply-To: <20071130163011.GA4223@singular.local>
On Fri, 30 Nov 2007 16:30:11 +0000, Jaime Velasco Juan <jsagarribay@gmail.com> wrote:
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> - { USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220) },
> - { USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220BIS) },
> + { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220, 0xff, 0xff, 0xff) },
> + { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220BIS, 0xff, 0xff, 0xff) },
Looks good to me, shorter than my patch, has no duplication, allows to
use the storage, looks like a winner. Unfortunately, it leaves ub for dead,
because ub cannot invoke the necessary initializer unless we move it to
libusual. But oh well, I'll think about it.
Took me this long to test because I had to ask kind people in England
to replug the modem.
Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
-- Pete
next prev parent reply other threads:[~2007-12-05 16:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-29 0:13 Add the infamous Huawei E220 to option.c Pete Zaitcev
2007-11-29 6:33 ` Johann Wilhelm
2007-11-29 7:44 ` Oliver Neukum
2007-11-29 8:01 ` Pete Zaitcev
2007-11-29 8:14 ` Oliver Neukum
2007-11-29 9:09 ` Matthew Dharm
2007-11-29 10:01 ` Rui Santos
2007-11-29 10:49 ` Oliver Neukum
2007-11-29 11:07 ` Rui Santos
2007-11-29 11:55 ` Oliver Neukum
2007-11-29 14:05 ` Johann Wilhelm
2007-11-29 14:36 ` Kristoffer Ericson
2007-11-29 14:41 ` Oliver Neukum
2007-11-29 18:53 ` Jaime Velasco Juan
2007-11-29 23:23 ` Oliver Neukum
2007-11-30 16:30 ` [PATCH] USB: option: Bind to the correct interface of the Huawei E220 Jaime Velasco Juan
2007-12-01 8:07 ` Norbert Preining
2007-12-01 8:34 ` Pete Zaitcev
2007-12-01 10:04 ` Norbert Preining
2007-12-01 18:36 ` Borislav Petkov
2007-12-05 16:34 ` Pete Zaitcev [this message]
2007-12-05 18:23 ` Oliver Neukum
2007-12-05 19:14 ` Pete Zaitcev
2007-11-29 19:12 ` Add the infamous Huawei E220 to option.c Rui Santos
2007-11-29 17:08 ` Greg KH
2007-11-29 7:38 ` Oliver Neukum
2007-11-29 7:52 ` Pete Zaitcev
2007-11-29 8:04 ` Oliver Neukum
2007-11-29 8:10 ` Pete Zaitcev
2007-11-29 14:14 ` Norbert Preining
2007-11-29 14:16 ` Norbert Preining
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071205083423.ca6ef199.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=drussell@redhat.com \
--cc=greg@kroah.com \
--cc=johann.wilhelm@student.tugraz.at \
--cc=jsagarribay@gmail.com \
--cc=kristoffer.ericson@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=preining@logic.at \
--cc=rsantos@grupopie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).