linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: WANG Cong <xiyou.wangcong@gmail.com>
To: Gabriele Gorla <gorlik@yahoo.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Patch submission question [not in the FAQ]
Date: Wed, 5 Dec 2007 20:36:34 +0800	[thread overview]
Message-ID: <20071205123634.GO2460@hacking> (raw)
In-Reply-To: <602863.12913.qm@web53712.mail.re2.yahoo.com>

On Wed, Dec 05, 2007 at 03:36:54AM -0800, Gabriele Gorla wrote:
>Hello,
>I have submitted a patch for the 3x-xxxx driver on
>alpha several months ago to both the driver maintainer
>and the linux-scsi mailing list.
>I have read all the FAQ and I tried to stick to the
>instructions to the letter.
>However the patch has been completely ignored. No
>reply, no comment, no flames, absolutely nothing...
>
>the original email submission is at the end of the
>email.
>
>could anyone please explain what I am doing wrong?
>
>thanks,
>GG
>
>
>[PATCH 2.6.22] 3w-xxxx: Fix bad unaligned accesses on
>alpha SMP
>
>disable packing of the TAG_TW_Device_Extension
>structure to prevent kernel unaligned accesses when
>accessing ioctl_wqueue.
>Fixes smartmontools kernel panic on alpha SMP
>
>Signed-off-by: Gabriele Gorla <gorlik@yahoo.com>
>---
>
>
>--- linux-2.6.22/drivers/scsi/3w-xxxx.h.orig
>2007-09-01 17:49:22.000000000 -0700
>+++ linux-2.6.22/drivers/scsi/3w-xxxx.h 2007-09-01
>17:49:45.000000000 -0700

It seems that your email client wraps lines.
Please don't do this when you submit patches.


>@@ -392,6 +392,8 @@ typedef struct TAG_TW_Passthru
>        unsigned char padding[12];
> } TW_Passthru;

And also your email clients eats tabs.

Read Documentation/SubmittingPatches, please.
And read Documentation/email-clients.txt to learn more.

Regards.


 Cong


  reply	other threads:[~2007-12-05 12:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-05 11:36 Patch submission question [not in the FAQ] Gabriele Gorla
2007-12-05 12:36 ` WANG Cong [this message]
2007-12-06 15:01 ` Jan Engelhardt
2007-12-06 21:37 ` adam radford
2007-12-09 12:57   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071205123634.GO2460@hacking \
    --to=xiyou.wangcong@gmail.com \
    --cc=gorlik@yahoo.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).