linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Engelhardt <jengelh@computergmbh.de>
To: Gabriele Gorla <gorlik@yahoo.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Patch submission question [not in the FAQ]
Date: Thu, 6 Dec 2007 16:01:42 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.64.0712061559210.19266@fbirervta.pbzchgretzou.qr> (raw)
In-Reply-To: <602863.12913.qm@web53712.mail.re2.yahoo.com>


On Dec 5 2007 03:36, Gabriele Gorla wrote:
>@@ -392,6 +392,8 @@ typedef struct TAG_TW_Passthru
>        unsigned char padding[12];
> } TW_Passthru;
> 
>+#pragma pack()
>+
> typedef struct TAG_TW_Device_Extension {
>        u32                     base_addr;
>        unsigned long
>*alignment_virtual_address[TW_Q_LENGTH];
>@@ -430,6 +432,4 @@ typedef struct
>TAG_TW_Device_Extension {
>        wait_queue_head_t       ioctl_wqueue;
> } TW_Device_Extension;
> 
>-#pragma pack()
>-

Hmpf. Can't you __attribute__((packed))-ify the structs rather
than use #pragma?

  parent reply	other threads:[~2007-12-06 15:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-05 11:36 Patch submission question [not in the FAQ] Gabriele Gorla
2007-12-05 12:36 ` WANG Cong
2007-12-06 15:01 ` Jan Engelhardt [this message]
2007-12-06 21:37 ` adam radford
2007-12-09 12:57   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0712061559210.19266@fbirervta.pbzchgretzou.qr \
    --to=jengelh@computergmbh.de \
    --cc=gorlik@yahoo.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).