From: Herbert Xu <herbert@gondor.apana.org.au>
To: Richard Knutsson <ricknu-0@student.ltu.se>
Cc: David Miller <davem@davemloft.net>,
xiyou.wangcong@gmail.com, linux-kernel@vger.kernel.org,
akpm@osdl.org, netdev@vger.kernel.org
Subject: Re: [Patch] net/xfrm/xfrm_policy.c: Some small improvements
Date: Fri, 7 Dec 2007 04:40:52 +1100 [thread overview]
Message-ID: <20071206174052.GA530@gondor.apana.org.au> (raw)
In-Reply-To: <4758093A.7010608@student.ltu.se>
On Thu, Dec 06, 2007 at 03:37:46PM +0100, Richard Knutsson wrote:
>
> Is it not an improvement to distinct booleans from actual values? Do you
> use integers for ASCII characters too? It can also avoid some potential
> bugs like the 'if (i == TRUE)'...
> What is wrong with 'size_t' (since it is unsigned, compared to (some)
> 'int')?
I agree with Dave. There are so many useful things that we can do
(and need to do) in IPsec that bool/size_t conversions just add
churn without adding much value.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2007-12-06 17:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 11:01 [Patch] net/xfrm/xfrm_policy.c: Some small improvements WANG Cong
2007-12-06 11:14 ` David Miller
2007-12-06 14:37 ` Richard Knutsson
2007-12-06 17:40 ` Herbert Xu [this message]
2007-12-07 3:22 ` David Miller
2007-12-07 15:41 ` Richard Knutsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071206174052.GA530@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ricknu-0@student.ltu.se \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).