From: Richard Knutsson <ricknu-0@student.ltu.se>
To: David Miller <davem@davemloft.net>
Cc: xiyou.wangcong@gmail.com, linux-kernel@vger.kernel.org,
herbert@gondor.apana.org.au, akpm@osdl.org,
netdev@vger.kernel.org
Subject: Re: [Patch] net/xfrm/xfrm_policy.c: Some small improvements
Date: Thu, 06 Dec 2007 15:37:46 +0100 [thread overview]
Message-ID: <4758093A.7010608@student.ltu.se> (raw)
In-Reply-To: <20071206.031434.179419183.davem@davemloft.net>
David Miller wrote:
> From: WANG Cong <xiyou.wangcong@gmail.com>
> Date: Thu, 6 Dec 2007 19:01:23 +0800
>
>
>> This patch contains the following changes.
>>
>> - Use 'bool' instead of 'int' for booleans.
>> - Use 'size_t' instead of 'int' for 'sizeof' return value.
>> - Some style fixes.
>>
>> Cc: Herbert Xu <herbert@gondor.apana.org.au>
>> Cc: David Miller <davem@davemloft.net>
>> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
>>
>
> Normally I would let a patch like this sit in my mailbox
> for a week and then delete it.
>
That is evil! ;)
> But this time I'll just let you know up front that I
> don't see much value in this patch. It is not a clear
> improvement to replace int's with bool's in my mind and
> the other changes are just whitespace changes.
>
Is it not an improvement to distinct booleans from actual values? Do you
use integers for ASCII characters too? It can also avoid some potential
bugs like the 'if (i == TRUE)'...
What is wrong with 'size_t' (since it is unsigned, compared to (some)
'int')?
/Richard Knutsson
next prev parent reply other threads:[~2007-12-06 14:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 11:01 [Patch] net/xfrm/xfrm_policy.c: Some small improvements WANG Cong
2007-12-06 11:14 ` David Miller
2007-12-06 14:37 ` Richard Knutsson [this message]
2007-12-06 17:40 ` Herbert Xu
2007-12-07 3:22 ` David Miller
2007-12-07 15:41 ` Richard Knutsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4758093A.7010608@student.ltu.se \
--to=ricknu-0@student.ltu.se \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).