Re: [PATCH] Add EXPORT_SYMBOL(ksize);

From: Adrian Bunk <bunk@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: penguin-kernel@I-love.SAKURA.ne.jp, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add EXPORT_SYMBOL(ksize);
Date: Thu, 6 Dec 2007 22:07:08 +0100	[thread overview]
Message-ID: <20071206210708.GO15974@stusta.de> (raw)
In-Reply-To: <20071206210248.GN15974@stusta.de>

On Thu, Dec 06, 2007 at 10:02:48PM +0100, Adrian Bunk wrote:
> On Mon, Dec 03, 2007 at 03:34:59PM -0800, Andrew Morton wrote:
> > On Sun, 2 Dec 2007 14:48:42 +0100
> > Adrian Bunk <bunk@kernel.org> wrote:
> > 
> > > On Sun, Dec 02, 2007 at 05:43:39PM +0900, Tetsuo Handa wrote:
> > > > 
> > > > mm/slub.c exports ksize(), but mm/slob.c and mm/slab.c don't. I don't know why.
> > > >...
> > > 
> > > That's due to the fact that my patch to remove this unused export from 
> > > slub was not yet applied...
> > > 
> > > Where is the modular in-kernel user?
> > > 
> > 
> > binfmt_flat.c, binfmt_elf_fdpic.c.
> 
> I could have sworn I had checked that both are bools, but BINFMT_FLAT is 
> actually a tristate.
> 
> Is anyone actually using binfmt_flat modular (considering it's only 
> available for !MMU embedded systems)? If yes, then only exporting 
> ksize() will not be enough for getting it working modular...

Considering it even lacks a MODULE_LICENSE("GPL") I do very much suspect 
it simply lacks any use case.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed