* [PATCH 1/3] Fix use of skb after netif_rx
@ 2007-12-09 20:02 Julia Lawall
2007-12-10 18:03 ` Jeff Dike
2007-12-11 1:15 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Julia Lawall @ 2007-12-09 20:02 UTC (permalink / raw)
To: jdike, wangchen, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Recently, Wang Chen submitted a patch
(d30f53aeb31d453a5230f526bea592af07944564) to move a call to netif_rx(skb)
after a subsequent reference to skb, because netif_rx may call kfree_skb on
its argument. The same problem occurs in some other drivers as well.
This was found using the following semantic match.
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
expression skb, e,e1;
@@
(
netif_rx(skb);
|
netif_rx_ni(skb);
)
... when != skb = e
(
skb = e1
|
* skb
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
diff a/arch/um/drivers/net_kern.c b/arch/um/drivers/net_kern.c
--- a/arch/um/drivers/net_kern.c 2007-11-15 15:09:36.000000000 +0100
+++ b/arch/um/drivers/net_kern.c 2007-12-05 19:01:14.000000000 +0100
@@ -98,10 +98,10 @@ static int uml_net_rx(struct net_device
if (pkt_len > 0) {
skb_trim(skb, pkt_len);
skb->protocol = (*lp->protocol)(skb);
- netif_rx(skb);
lp->stats.rx_bytes += skb->len;
lp->stats.rx_packets++;
+ netif_rx(skb);
return pkt_len;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/3] Fix use of skb after netif_rx
2007-12-09 20:02 [PATCH 1/3] Fix use of skb after netif_rx Julia Lawall
@ 2007-12-10 18:03 ` Jeff Dike
2007-12-11 1:15 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Dike @ 2007-12-10 18:03 UTC (permalink / raw)
To: Julia Lawall; +Cc: wangchen, linux-kernel, kernel-janitors
On Sun, Dec 09, 2007 at 09:02:31PM +0100, Julia Lawall wrote:
> Recently, Wang Chen submitted a patch
> (d30f53aeb31d453a5230f526bea592af07944564) to move a call to netif_rx(skb)
> after a subsequent reference to skb, because netif_rx may call kfree_skb on
> its argument. The same problem occurs in some other drivers as well.
>
> This was found using the following semantic match.
> (http://www.emn.fr/x-info/coccinelle/)
Thanks, I'll forward this on.
Jeff
--
Work email - jdike at linux dot intel dot com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/3] Fix use of skb after netif_rx
2007-12-09 20:02 [PATCH 1/3] Fix use of skb after netif_rx Julia Lawall
2007-12-10 18:03 ` Jeff Dike
@ 2007-12-11 1:15 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2007-12-11 1:15 UTC (permalink / raw)
To: julia; +Cc: jdike, wangchen, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Date: Sun, 9 Dec 2007 21:02:31 +0100 (CET)
> From: Julia Lawall <julia@diku.dk>
>
> Recently, Wang Chen submitted a patch
> (d30f53aeb31d453a5230f526bea592af07944564) to move a call to netif_rx(skb)
> after a subsequent reference to skb, because netif_rx may call kfree_skb on
> its argument. The same problem occurs in some other drivers as well.
>
> This was found using the following semantic match.
> (http://www.emn.fr/x-info/coccinelle/)
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Patch applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-12-11 1:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-12-09 20:02 [PATCH 1/3] Fix use of skb after netif_rx Julia Lawall
2007-12-10 18:03 ` Jeff Dike
2007-12-11 1:15 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).