From: Stephen Hemminger <shemminger@linux-foundation.org>
To: "Joonwoo Park" <joonwpark81@gmail.com>
Cc: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"David Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
herbert@gondor.apana.org.au, "Kok,
Auke-jan H" <auke-jan.h.kok@intel.com>
Subject: Re: [PATCH] [NET]: Fix Ooops of napi net_rx_action.
Date: Tue, 11 Dec 2007 15:42:22 -0800 [thread overview]
Message-ID: <20071211154222.0aec68fc@freepuppy.rosehill> (raw)
In-Reply-To: <b25c3fa70712111527p561b3e2i24ee0fdf3d61a98c@mail.gmail.com>
Perhaps we should change the warning to identify the guilty device.
--- a/net/core/dev.c 2007-11-19 09:09:57.000000000 -0800
+++ b/net/core/dev.c 2007-12-07 15:54:03.000000000 -0800
@@ -2196,7 +2196,13 @@ static void net_rx_action(struct softirq
if (test_bit(NAPI_STATE_SCHED, &n->state))
work = n->poll(n, weight);
- WARN_ON_ONCE(work > weight);
+ if (unlikely(work > weight)) {
+ if (net_ratelimit())
+ printk(KERN_WARNING
+ "%s: driver poll bug (work=%d weight=%d)\n",
+ work, weight);
+ work = weight;
+ }
budget -= work;
next prev parent reply other threads:[~2007-12-11 23:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-11 9:13 [PATCH] [NET]: Fix Ooops of napi net_rx_action Joonwoo Park
2007-12-11 10:32 ` David Miller
2007-12-11 12:36 ` Herbert Xu
2007-12-11 12:41 ` David Miller
2007-12-11 12:57 ` Joonwoo Park
2007-12-11 23:12 ` Brandeburg, Jesse
2007-12-11 23:27 ` Joonwoo Park
2007-12-11 23:42 ` Stephen Hemminger [this message]
2007-12-16 21:35 ` David Miller
2007-12-12 0:12 ` Joonwoo Park
2007-12-12 0:38 ` Brandeburg, Jesse
2007-12-12 15:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071211154222.0aec68fc@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jesse.brandeburg@intel.com \
--cc=joonwpark81@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).