linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
To: "Joonwoo Park" <joonwpark81@gmail.com>,
	"David Miller" <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<herbert@gondor.apana.org.au>,
	"Kok, Auke-jan H" <auke-jan.h.kok@intel.com>
Subject: RE: [PATCH] [NET]: Fix Ooops of napi net_rx_action.
Date: Tue, 11 Dec 2007 15:12:10 -0800	[thread overview]
Message-ID: <36D9DB17C6DE9E40B059440DB8D95F5203F82FC3@orsmsx418.amr.corp.intel.com> (raw)
In-Reply-To: <b25c3fa70712110457g2bf04c6flc387f2b9cb51cf3b@mail.gmail.com>

Joonwoo Park wrote:
>     /* If no Tx and not enough Rx work done, exit the polling mode */
>     if ((!tx_cleaned && (work_done == 0)) ||
>        !netif_running(poll_dev)) {
> quit_polling:
>         if (likely(adapter->itr_setting & 3))
>             e1000_set_itr(adapter);
>         netif_rx_complete(poll_dev, napi);
>         e1000_irq_enable(adapter);

all drivers using NAPI in 2.6.24+ (NNAPI??) must return zero here, after
calling netif_rx_complete.  netif_rx_complete plus work_done != 0 causes
a bug.

>     }
> 
>     return work_done;
> }
> 

  reply	other threads:[~2007-12-11 23:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-11  9:13 [PATCH] [NET]: Fix Ooops of napi net_rx_action Joonwoo Park
2007-12-11 10:32 ` David Miller
2007-12-11 12:36   ` Herbert Xu
2007-12-11 12:41     ` David Miller
2007-12-11 12:57   ` Joonwoo Park
2007-12-11 23:12     ` Brandeburg, Jesse [this message]
2007-12-11 23:27       ` Joonwoo Park
2007-12-11 23:42         ` Stephen Hemminger
2007-12-16 21:35           ` David Miller
2007-12-12  0:12       ` Joonwoo Park
2007-12-12  0:38         ` Brandeburg, Jesse
2007-12-12 15:12           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36D9DB17C6DE9E40B059440DB8D95F5203F82FC3@orsmsx418.amr.corp.intel.com \
    --to=jesse.brandeburg@intel.com \
    --cc=auke-jan.h.kok@intel.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=joonwpark81@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).