From: Andrew Morton <akpm@linux-foundation.org>
To: Adam Jackson <ajax@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] apm_event{,info}_t are userspace types.
Date: Wed, 12 Dec 2007 02:47:00 -0800 [thread overview]
Message-ID: <20071212024700.19560b60.akpm@linux-foundation.org> (raw)
In-Reply-To: <1196452963295-git-send-email-ajax@redhat.com>
On Fri, 30 Nov 2007 15:02:43 -0500 Adam Jackson <ajax@redhat.com> wrote:
> These types define the size of data read from /dev/apm_bios. They
> should not be hidden behind #ifdef __KERNEL__.
Missing info: what are the consequences of this fix? What id broken when
it it not applied?
> ---
> include/linux/apm_bios.h | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
Please include Signed-off-by:, as per Documentation/SubmittingPatches,
thanks.
> diff --git a/include/linux/apm_bios.h b/include/linux/apm_bios.h
> index 9754baa..01a6244 100644
> --- a/include/linux/apm_bios.h
> +++ b/include/linux/apm_bios.h
> @@ -18,6 +18,9 @@
>
> #include <linux/types.h>
>
> +typedef unsigned short apm_event_t;
> +typedef unsigned short apm_eventinfo_t;
> +
> struct apm_bios_info {
> __u16 version;
> __u16 cseg;
> @@ -32,9 +35,6 @@ struct apm_bios_info {
>
> #ifdef __KERNEL__
>
> -typedef unsigned short apm_event_t;
> -typedef unsigned short apm_eventinfo_t;
> -
> #define APM_CS (GDT_ENTRY_APMBIOS_BASE * 8)
> #define APM_CS_16 (APM_CS + 8)
> #define APM_DS (APM_CS_16 + 8)
next prev parent reply other threads:[~2007-12-12 10:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 20:02 [PATCH] apm_event{,info}_t are userspace types Adam Jackson
2007-12-12 10:47 ` Andrew Morton [this message]
2007-12-13 21:03 ` Eamon Walsh
2007-12-19 19:00 ` Adam Jackson
2007-12-18 4:33 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071212024700.19560b60.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ajax@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).