From: Eamon Walsh <ewalsh@tycho.nsa.gov>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Adam Jackson <ajax@redhat.com>,
linux-kernel@vger.kernel.org, rusty@rustcorp.com.au
Subject: Re: [PATCH] apm_event{,info}_t are userspace types.
Date: Thu, 13 Dec 2007 16:03:37 -0500 [thread overview]
Message-ID: <47619E29.10101@tycho.nsa.gov> (raw)
In-Reply-To: <20071212024700.19560b60.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Fri, 30 Nov 2007 15:02:43 -0500 Adam Jackson <ajax@redhat.com> wrote:
>
>> These types define the size of data read from /dev/apm_bios. They
>> should not be hidden behind #ifdef __KERNEL__.
>
> Missing info: what are the consequences of this fix? What id broken when
> it it not applied?
This is killing my xserver compile, apm_event_t is used in the xserver
source. The commit that introduced the problem is:
commit ee8e7cfe9d330d6f1ce0b9b1620d6df5d9cf6b70
Author: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon Oct 22 10:56:19 2007 +1000
Make asm-x86/bootparam.h includable from userspace.
To actually write a bootloader (or, say, the lguest launcher)
currently requires duplication of these structures. Making them
includable from userspace is much nicer.
We merge the common userspace-required definitions of e820_32/64.h
into e820.h for export.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>
>
>> ---
>> include/linux/apm_bios.h | 6 +++---
>> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> Please include Signed-off-by:, as per Documentation/SubmittingPatches,
> thanks.
>
>> diff --git a/include/linux/apm_bios.h b/include/linux/apm_bios.h
>> index 9754baa..01a6244 100644
>> --- a/include/linux/apm_bios.h
>> +++ b/include/linux/apm_bios.h
>> @@ -18,6 +18,9 @@
>>
>> #include <linux/types.h>
>>
>> +typedef unsigned short apm_event_t;
>> +typedef unsigned short apm_eventinfo_t;
>> +
>> struct apm_bios_info {
>> __u16 version;
>> __u16 cseg;
>> @@ -32,9 +35,6 @@ struct apm_bios_info {
>>
>> #ifdef __KERNEL__
>>
>> -typedef unsigned short apm_event_t;
>> -typedef unsigned short apm_eventinfo_t;
>> -
>> #define APM_CS (GDT_ENTRY_APMBIOS_BASE * 8)
>> #define APM_CS_16 (APM_CS + 8)
>> #define APM_DS (APM_CS_16 + 8)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Eamon Walsh <ewalsh@tycho.nsa.gov>
National Security Agency
next prev parent reply other threads:[~2007-12-14 1:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 20:02 [PATCH] apm_event{,info}_t are userspace types Adam Jackson
2007-12-12 10:47 ` Andrew Morton
2007-12-13 21:03 ` Eamon Walsh [this message]
2007-12-19 19:00 ` Adam Jackson
2007-12-18 4:33 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47619E29.10101@tycho.nsa.gov \
--to=ewalsh@tycho.nsa.gov \
--cc=ajax@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).