* not needed patch
@ 2007-12-20 4:57 Yinghai Lu
2007-12-20 14:29 ` Ingo Molnar
0 siblings, 1 reply; 7+ messages in thread
From: Yinghai Lu @ 2007-12-20 4:57 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Andrew Morton, LKML
Ingo.
commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9 is not needed.
another patch (by you !! commit 699d934d5f958d7944d195c03c334f28cc0b3669 x86: fixup cpu_info array conversion)
already removed clearing of c->cpu_index. in identify_cpu
also it is not consisent to smpboot_32.c. (it will assign id to cpu_index right after
*c = boot_cpu_data;
)
by revert commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9, we could use c->cpu_index in identify_cpu.
YH
commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9
Author: Mike Travis <travis@sgi.com>
Date: Wed Dec 19 23:20:19 2007 +0100
x86: fix show cpuinfo cpu number always zero
when called by setup_arch) after smp_store_cpu_info() had set it to the
correct value.
The error shows up in 'cat /proc/cpuinfo' will all cpus = 0.
Signed-off-by: Mike Travis <travis@sgi.com>
Cc: Andi Kleen <ak@suse.de>
Cc: Christoph Lameter <clameter@sgi.com>
Cc: Jack Steiner <steiner@sgi.com>
Cc: Suresh B Siddha <suresh.b.siddha@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
diff --git a/arch/x86/kernel/smpboot_64.c b/arch/x86/kernel/smpboot_64.c
index 500670c..5948895 100644
--- a/arch/x86/kernel/smpboot_64.c
+++ b/arch/x86/kernel/smpboot_64.c
@@ -141,8 +141,8 @@ static void __cpuinit smp_store_cpu_info(int id)
struct cpuinfo_x86 *c = &cpu_data(id);
*c = boot_cpu_data;
- c->cpu_index = id;
identify_cpu(c);
+ c->cpu_index = id;
print_cpu_info(c);
}
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: not needed patch
2007-12-20 4:57 not needed patch Yinghai Lu
@ 2007-12-20 14:29 ` Ingo Molnar
2007-12-20 14:56 ` Mike Travis
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Ingo Molnar @ 2007-12-20 14:29 UTC (permalink / raw)
To: Yinghai Lu; +Cc: Andrew Morton, LKML, Mike Travis
* Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
> Ingo.
>
> commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9 is not needed. another
> patch (by you !! commit 699d934d5f958d7944d195c03c334f28cc0b3669 x86:
> fixup cpu_info array conversion) already removed clearing of
> c->cpu_index. in identify_cpu
> also it is not consisent to smpboot_32.c. (it will assign id to
> cpu_index right after
>
> *c = boot_cpu_data;
> )
well, it might in the worst-case be a superfluous change, but not cause
any problems in 2.6.24, right?
> by revert commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9, we could
> use c->cpu_index in identify_cpu.
but that's 2.6.25 stuff, right? Travis?
Ingo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: not needed patch
2007-12-20 14:29 ` Ingo Molnar
@ 2007-12-20 14:56 ` Mike Travis
2007-12-20 16:28 ` Mike Travis
2007-12-20 19:54 ` Yinghai Lu
2 siblings, 0 replies; 7+ messages in thread
From: Mike Travis @ 2007-12-20 14:56 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Yinghai Lu, Andrew Morton, LKML
Ingo Molnar wrote:
> * Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
>
>> Ingo.
>>
>> commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9 is not needed. another
>> patch (by you !! commit 699d934d5f958d7944d195c03c334f28cc0b3669 x86:
>> fixup cpu_info array conversion) already removed clearing of
>> c->cpu_index. in identify_cpu
>> also it is not consisent to smpboot_32.c. (it will assign id to
>> cpu_index right after
>>
>> *c = boot_cpu_data;
>> )
>
> well, it might in the worst-case be a superfluous change, but not cause
> any problems in 2.6.24, right?
>
>> by revert commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9, we could
>> use c->cpu_index in identify_cpu.
>
> but that's 2.6.25 stuff, right? Travis?
Since 6.5.24 needs to close soon, I'll queue up this change for 6.5.25.
Thanks everyone!
-Mike
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: not needed patch
2007-12-20 14:29 ` Ingo Molnar
2007-12-20 14:56 ` Mike Travis
@ 2007-12-20 16:28 ` Mike Travis
2007-12-20 16:33 ` Ingo Molnar
2007-12-20 19:54 ` Yinghai Lu
2 siblings, 1 reply; 7+ messages in thread
From: Mike Travis @ 2007-12-20 16:28 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Yinghai Lu, Andrew Morton, LKML
Ingo Molnar wrote:
> * Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
>
>> Ingo.
>>
>> commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9 is not needed. another
>> patch (by you !! commit 699d934d5f958d7944d195c03c334f28cc0b3669 x86:
>> fixup cpu_info array conversion) already removed clearing of
>> c->cpu_index. in identify_cpu
>> also it is not consisent to smpboot_32.c. (it will assign id to
>> cpu_index right after
>>
>> *c = boot_cpu_data;
>> )
>
> well, it might in the worst-case be a superfluous change, but not cause
> any problems in 2.6.24, right?
>
>> by revert commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9, we could
>> use c->cpu_index in identify_cpu.
>
> but that's 2.6.25 stuff, right? Travis?
>
Looking at this more closely, yes my change is not needed and should be
removed. I'm not sure what caused my cpu # to be all zeros when I was
testing, but it now works ok without my change.
Thanks,
Mike
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: not needed patch
2007-12-20 16:28 ` Mike Travis
@ 2007-12-20 16:33 ` Ingo Molnar
2007-12-20 16:53 ` Mike Travis
0 siblings, 1 reply; 7+ messages in thread
From: Ingo Molnar @ 2007-12-20 16:33 UTC (permalink / raw)
To: Mike Travis; +Cc: Yinghai Lu, Andrew Morton, LKML
* Mike Travis <travis@sgi.com> wrote:
> >> by revert commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9, we could
> >> use c->cpu_index in identify_cpu.
> >
> > but that's 2.6.25 stuff, right? Travis?
> >
>
> Looking at this more closely, yes my change is not needed and should
> be removed. I'm not sure what caused my cpu # to be all zeros when I
> was testing, but it now works ok without my change.
how about this question:
> > well, it might in the worst-case be a superfluous change, but not
> > cause any problems in 2.6.24, right?
Ingo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: not needed patch
2007-12-20 16:33 ` Ingo Molnar
@ 2007-12-20 16:53 ` Mike Travis
0 siblings, 0 replies; 7+ messages in thread
From: Mike Travis @ 2007-12-20 16:53 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Yinghai Lu, Andrew Morton, LKML
Ingo Molnar wrote:
> * Mike Travis <travis@sgi.com> wrote:
>
>>>> by revert commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9, we could
>>>> use c->cpu_index in identify_cpu.
>>> but that's 2.6.25 stuff, right? Travis?
>>>
>> Looking at this more closely, yes my change is not needed and should
>> be removed. I'm not sure what caused my cpu # to be all zeros when I
>> was testing, but it now works ok without my change.
>
> how about this question:
>
>>> well, it might in the worst-case be a superfluous change, but not
>>> cause any problems in 2.6.24, right?
>
> Ingo
I don't think it hurts anything except as noted, it wouldn't be available
to the subfunctions (like identify_cpu) that might need the cpu_index
(which also is noted that none currently do.)
-Mike
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: not needed patch
2007-12-20 14:29 ` Ingo Molnar
2007-12-20 14:56 ` Mike Travis
2007-12-20 16:28 ` Mike Travis
@ 2007-12-20 19:54 ` Yinghai Lu
2 siblings, 0 replies; 7+ messages in thread
From: Yinghai Lu @ 2007-12-20 19:54 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Andrew Morton, LKML, Mike Travis
On Thursday 20 December 2007 06:29:06 am Ingo Molnar wrote:
>
> * Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
>
> > Ingo.
> >
> > commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9 is not needed. another
> > patch (by you !! commit 699d934d5f958d7944d195c03c334f28cc0b3669 x86:
> > fixup cpu_info array conversion) already removed clearing of
> > c->cpu_index. in identify_cpu
> > also it is not consisent to smpboot_32.c. (it will assign id to
> > cpu_index right after
> >
> > *c = boot_cpu_data;
> > )
>
> well, it might in the worst-case be a superfluous change, but not cause
> any problems in 2.6.24, right?
now it is ok with 2.6.24.
>
> > by revert commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9, we could
> > use c->cpu_index in identify_cpu.
>
> but that's 2.6.25 stuff, right? Travis?
or at least before bewfore merging smpboot_32.c and smpboot_64.c
YH
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2007-12-20 19:45 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-12-20 4:57 not needed patch Yinghai Lu
2007-12-20 14:29 ` Ingo Molnar
2007-12-20 14:56 ` Mike Travis
2007-12-20 16:28 ` Mike Travis
2007-12-20 16:33 ` Ingo Molnar
2007-12-20 16:53 ` Mike Travis
2007-12-20 19:54 ` Yinghai Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).