From: Al Viro <viro@ftp.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Theodore Tso <tytso@mit.edu>, Ingo Molnar <mingo@elte.hu>,
Andi Kleen <andi@firstfloor.org>,
Christoph Lameter <clameter@sgi.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: Major regression on hackbench with SLUB (more numbers)
Date: Sat, 22 Dec 2007 23:29:22 +0000 [thread overview]
Message-ID: <20071222232922.GO8181@ftp.linux.org.uk> (raw)
In-Reply-To: <20071222215009.GN8181@ftp.linux.org.uk>
On Sat, Dec 22, 2007 at 09:50:09PM +0000, Al Viro wrote:
> On Sat, Dec 22, 2007 at 01:00:09PM -0800, Linus Torvalds wrote:
>
> > > Another problem with using /sys/slab is that it is downright *ugly*.
> > > Why is it for example, that /sys/slab/dentry is a symlink to
> > > ../slab/:a-0000160?
> >
> > That's the only really ugly thing there. Otherwise, it's pretty nice, but
> > having a million files makes for problems when trying to send somebody
> > else the full info.
>
> *raised brows*
>
> I would say that there's that really ugly thing with embedding kobject
> into a struct with the lifetime rules of its own and then having that
> struct kfree()d while kobject might still have references, but hey,
> maybe it's just me and my lack of appreciation of the glory that is
> sysfs.
>
> Al, too tired of ranting about sysfs being a major architecture
> mistake and a recurring source of turds like that one...
BTW, the fact that presence of that kobject is conditional makes life even
uglier - we have to either kfree() or drop a reference to kobject leaving
actual kfree() to its ->release(). While we are at it, when do we remove
the symlinks? That got to add even more fun for the lifetime rules...
Sigh... How does one set a script that would mail a warning upon git pull
that introduces any instances of keyword from given set? I hadn't noticed
that slub was using sysfs when it went into the tree back in May ;-/
next prev parent reply other threads:[~2007-12-22 23:29 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-07 17:50 Major regression on hackbench with SLUB Steven Rostedt
2007-12-07 17:55 ` Ingo Molnar
2007-12-07 17:59 ` Linus Torvalds
2007-12-07 18:36 ` Linus Torvalds
2007-12-07 18:58 ` Steven Rostedt
2007-12-08 22:16 ` Steven Rostedt
2007-12-10 7:38 ` Björn Steinbrink
2007-12-10 14:00 ` Steven Rostedt
2007-12-09 0:28 ` Steven Rostedt
2007-12-13 22:11 ` Christoph Lameter
2007-12-11 14:33 ` Major regression on hackbench with SLUB (more numbers) Ingo Molnar
2007-12-13 22:22 ` Christoph Lameter
2007-12-14 4:24 ` Christoph Lameter
2007-12-14 6:15 ` Steven Rostedt
2007-12-21 12:09 ` Ingo Molnar
2007-12-21 12:26 ` Ingo Molnar
2007-12-21 16:26 ` Christoph Lameter
2007-12-21 16:33 ` Ingo Molnar
2007-12-21 21:56 ` Christoph Lameter
2007-12-21 16:18 ` Christoph Lameter
2007-12-21 16:44 ` Linus Torvalds
2007-12-21 22:11 ` Christoph Lameter
2007-12-21 22:16 ` Peter Zijlstra
2007-12-21 22:17 ` Peter Zijlstra
2007-12-21 22:27 ` Christoph Lameter
2007-12-21 22:54 ` Ingo Molnar
2007-12-21 23:20 ` David Miller
2007-12-22 9:45 ` Ingo Molnar
2007-12-24 19:24 ` Christoph Lameter
2007-12-21 23:27 ` Andrew Morton
2007-12-21 23:51 ` Christoph Lameter
2007-12-22 0:28 ` Andi Kleen
2007-12-22 0:33 ` Chuck Ebbert
2007-12-22 2:19 ` Matt Mackall
2007-12-22 2:44 ` Andi Kleen
2007-12-22 10:03 ` Ingo Molnar
2007-12-22 12:37 ` Andi Kleen
2007-12-22 12:51 ` Pekka Enberg
2007-12-22 12:54 ` Andi Kleen
2007-12-22 13:27 ` Pekka Enberg
2007-12-22 13:01 ` Alexey Dobriyan
2007-12-22 18:01 ` Linus Torvalds
2007-12-22 19:09 ` Ingo Molnar
2007-12-22 19:29 ` Ingo Molnar
2007-12-22 22:52 ` Jason L Tibbitts III
2007-12-24 3:59 ` Alessandro Suardi
2007-12-22 19:25 ` Theodore Tso
2007-12-22 21:00 ` Linus Torvalds
2007-12-22 21:50 ` Al Viro
2007-12-22 23:29 ` Al Viro [this message]
2007-12-22 22:10 ` Willy Tarreau
2007-12-23 0:59 ` Steven Rostedt
2007-12-23 5:12 ` Willy Tarreau
2007-12-23 14:15 ` Andi Kleen
2007-12-24 3:45 ` Theodore Tso
2007-12-24 19:21 ` Christoph Lameter
2007-12-24 23:37 ` Theodore Tso
2007-12-25 3:34 ` Andi Kleen
2008-01-01 12:47 ` Theodore Tso
2008-01-01 15:19 ` Andi Kleen
2008-01-01 16:23 ` [patch] slub: provide /proc/slabinfo Ingo Molnar
2008-01-05 0:27 ` Arjan van de Ven
2008-01-05 0:49 ` Linus Torvalds
2007-12-26 21:31 ` Major regression on hackbench with SLUB (more numbers) Christoph Lameter
2007-12-26 22:16 ` Al Viro
2007-12-27 5:51 ` Christoph Lameter
2007-12-27 20:28 ` SLUB sysfs support Christoph Lameter
2007-12-27 22:59 ` Al Viro
2007-12-27 23:22 ` Christoph Lameter
2007-12-27 23:53 ` Christoph Lameter
2007-12-27 23:58 ` Al Viro
2007-12-28 0:02 ` Christoph Lameter
2007-12-28 0:45 ` Al Viro
2007-12-28 2:19 ` Christoph Lameter
2007-12-28 3:26 ` Al Viro
2008-01-02 20:25 ` Christoph Lameter
2007-12-27 23:54 ` Al Viro
2007-12-28 9:00 ` Major regression on hackbench with SLUB (more numbers) Ingo Molnar
2007-12-28 14:52 ` Steven Rostedt
2007-12-22 19:46 ` slabtop replacement was " Andi Kleen
2007-12-22 23:28 ` Karol Swietlicki
2007-12-29 18:08 ` Karol Swietlicki
2007-12-21 22:49 ` Linus Torvalds
2007-12-21 17:44 ` Pekka Enberg
2007-12-21 22:22 ` Christoph Lameter
2007-12-21 22:37 ` Christoph Lameter
2007-12-21 22:51 ` Linus Torvalds
2007-12-21 23:17 ` Ingo Molnar
2007-12-21 23:40 ` Pekka Enberg
2007-12-21 23:54 ` Christoph Lameter
2007-12-22 0:02 ` Chuck Ebbert
2007-12-21 22:52 ` Steven Rostedt
2007-12-21 22:56 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071222232922.GO8181@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=clameter@sgi.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).