linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Zan Lynx <zlynx@acm.org>, Thomas Gleixner <tglx@linutronix.de>,
	Len Brown <lenb@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: echo mem > /sys/power/state
Date: Fri, 18 Jan 2008 09:36:10 +0100	[thread overview]
Message-ID: <20080118083610.GA19792@elte.hu> (raw)
In-Reply-To: <200801172238.17176.rjw@sisk.pl>


* Rafael J. Wysocki <rjw@sisk.pl> wrote:

> > Probably it would be more efficient to have the people who wrote the 
> > code also test it.
> 
> Well, that would certainly help.
> 
> I do test all of my patches and generally all of the patches I sign 
> off, but surely that's not enough.

please add a .config option dependent on CONFIG_DEBUG_KERNEL=y [and 
default-disabled] that auto-tests suspend/resume functionality 60 
seconds after hitting user-space (the suspend/resume cycle kept small 
via a small RTC timeout) and s2ram correctness will be tested _a lot_ 
more.

(it doesnt matter if graphics does not resume fine - at least for my 
tests)

kprobes had similar problems and it now has a few simple smoke-tests - 
which i just saw trigger on a patch that i did not notice would break 
kprobes. I think this should be done for all functionality that is not 
regularly triggered by a normal distro bootup (and which is easy to 
overlook in testing).

	Ingo

  parent reply	other threads:[~2008-01-18  8:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-17  6:24 echo mem > /sys/power/state Andrew Morton
2008-01-17 17:36 ` Zan Lynx
2008-01-17 19:13   ` Andrew Morton
2008-01-17 21:38     ` Rafael J. Wysocki
2008-01-17 21:45       ` Nigel Cunningham
2008-01-17 22:27         ` Rafael J. Wysocki
2008-01-18  8:36       ` Ingo Molnar [this message]
2008-01-18  8:47         ` Andrew Morton
2008-01-18  9:04           ` Harvey Harrison
2008-01-18 12:18           ` Ingo Molnar
2008-01-18 14:26             ` Rafael J. Wysocki
2008-01-20 23:39             ` Pavel Machek
2008-01-20 23:42               ` Ingo Molnar
2008-01-21  0:31                 ` Pavel Machek
2008-01-21  2:13                   ` Johannes Weiner
2008-01-21 22:37                     ` Pavel Machek
2008-01-22 14:42                       ` Ingo Molnar
2008-01-23 21:27                         ` Pavel Machek
2008-01-17 21:48     ` Jiri Slaby
2008-01-18  8:51       ` Ingo Molnar
2008-01-17 18:22 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080118083610.GA19792@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=tglx@linutronix.de \
    --cc=zlynx@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).