From: Rusty Russell <rusty@rustcorp.com.au>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
lkml <linux-kernel@vger.kernel.org>,
dipankar@in.ibm.com, akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH] rcu: fix section mismatch
Date: Mon, 21 Jan 2008 11:38:38 +1100 [thread overview]
Message-ID: <200801211138.38591.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20080119212549.GD29070@uranus.ravnborg.org>
On Sunday 20 January 2008 08:25:49 Sam Ravnborg wrote:
> On Sat, Jan 19, 2008 at 11:56:43AM -0800, Randy Dunlap wrote:
> > rcu_online_cpu() should be __cpuinit instead of __devinit.
>
> So if we have:
> CONFIG_HOTPLUG=n
> CONFIG_HOTPLUG_CPU=y
>
> then this is a oops candidate.
At first glance, this can't happen because all CONFIG_HOTPLUG_CPU depends on
CONFIG_HOTPLUG or selects it, for all archs.
But CONFIG_PM_SLEEP_SMP selects CONFIG_HOTPLUG_CPU, without requiring
CONFIG_HOTPLUG: turning on SUSPEND or HIBERNATION does this.
Perhaps it's time to revisit reverse-depends for select?
Cheers,
Rusty.
next prev parent reply other threads:[~2008-01-21 3:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-19 19:56 [PATCH] rcu: fix section mismatch Randy Dunlap
2008-01-19 21:25 ` Sam Ravnborg
2008-01-21 0:38 ` Rusty Russell [this message]
2008-01-21 19:08 ` Sam Ravnborg
2008-01-21 23:34 ` Randy Dunlap
2008-01-22 5:52 ` Sam Ravnborg
2008-01-22 16:20 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801211138.38591.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).