[PATCH] unifdef linux/vt.h

[PATCH] unifdef linux/vt.h

[Olaf Hering]

remove the newly added __KERNEL__ block from linux/vt.h

Signed-off-by: Olaf Hering <olaf@aepfle.de>

---
 include/linux/Kbuild |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/include/linux/Kbuild
+++ b/include/linux/Kbuild
@@ -157,7 +157,6 @@ header-y += veth.h
 header-y += video_decoder.h
 header-y += video_encoder.h
 header-y += videotext.h
-header-y += vt.h
 header-y += x25.h
 
 unifdef-y += acct.h
@@ -348,6 +347,7 @@ unifdef-y += videodev.h
 unifdef-y += virtio_config.h
 unifdef-y += virtio_blk.h
 unifdef-y += virtio_net.h
+unifdef-y += vt.h
 unifdef-y += wait.h
 unifdef-y += wanrouter.h
 unifdef-y += watchdog.h

[PATCH] hide kernel only code in linux/jbd.h

[Olaf Hering]

Move a few kernel only stuff into __KERNEL__

Signed-off-by: Olaf Hering <olaf@aepfle.de>

---
 include/linux/jbd.h |    2 --
 1 file changed, 2 deletions(-)

--- a/include/linux/jbd.h
+++ b/include/linux/jbd.h
@@ -33,7 +33,6 @@
 #include <linux/lockdep.h>
 
 #include <asm/semaphore.h>
-#endif
 
 #define journal_oom_retry 1
 
@@ -84,7 +83,6 @@ static inline void jbd_free(void *ptr, s
 
 #define JFS_MIN_JOURNAL_BLOCKS 1024
 
-#ifdef __KERNEL__
 
 /**
  * typedef handle_t - The handle_t type represents a single atomic update being performed by some process.

Re: [PATCH] unifdef linux/vt.h

[Christoph Hellwig]

On Fri, Jan 25, 2008 at 07:02:15PM +0100, Olaf Hering wrote:
> 
> remove the newly added __KERNEL__ block from linux/vt.h
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

We shouldn't add more unifdef-y headers.  Please move the newly-added
kernel-only section to a different file instead and beat up the person
who introduced it with a big cluestick.

Re: [PATCH] unifdef linux/vt.h

[Olaf Hering]

On Sat, Jan 26, Christoph Hellwig wrote:

> On Fri, Jan 25, 2008 at 07:02:15PM +0100, Olaf Hering wrote:
> > 
> > remove the newly added __KERNEL__ block from linux/vt.h
> > 
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> 
> We shouldn't add more unifdef-y headers.  Please move the newly-added
> kernel-only section to a different file instead and beat up the person
> who introduced it with a big cluestick.

Suggest a place, please.

Also, I think every header should go throug unifdef.

Re: [PATCH] unifdef linux/vt.h

[Olaf Hering]

On Fri, Jan 25, Olaf Hering wrote:

> remove the newly added __KERNEL__ block from linux/vt.h

Can you pick this up? The patch cant get any better.

> --- a/include/linux/Kbuild
> +++ b/include/linux/Kbuild
> @@ -157,7 +157,6 @@ header-y += veth.h
>  header-y += video_decoder.h
>  header-y += video_encoder.h
>  header-y += videotext.h
> -header-y += vt.h
>  header-y += x25.h
>  
>  unifdef-y += acct.h
> @@ -348,6 +347,7 @@ unifdef-y += videodev.h
>  unifdef-y += virtio_config.h
>  unifdef-y += virtio_blk.h
>  unifdef-y += virtio_net.h
> +unifdef-y += vt.h
>  unifdef-y += wait.h
>  unifdef-y += wanrouter.h
>  unifdef-y += watchdog.h

Re: [PATCH] unifdef linux/vt.h

[Andrew Morton]

On Fri, 8 Feb 2008 18:38:10 +0100
Olaf Hering <olaf@aepfle.de> wrote:

> On Fri, Jan 25, Olaf Hering wrote:
> 
> > remove the newly added __KERNEL__ block from linux/vt.h
> 
> Can you pick this up? The patch cant get any better.

spose so.  Coud you send a tested version against current mainline please?

Re: [PATCH] unifdef linux/vt.h

[Olaf Hering]

On Fri, Feb 08, Andrew Morton wrote:

> On Fri, 8 Feb 2008 18:38:10 +0100
> Olaf Hering <olaf@aepfle.de> wrote:
> 
> > On Fri, Jan 25, Olaf Hering wrote:
> > 
> > > remove the newly added __KERNEL__ block from linux/vt.h
> > 
> > Can you pick this up? The patch cant get any better.
> 
> spose so.  Coud you send a tested version against current mainline please?

Its already fixed.

 commit 7998a731664ac4988b349e70669bac11e3b3a3ac
 Author: Robert P. J. Day <rpjday@crashcourse.ca>
 Date:   Mon Dec 31 14:58:38 2007 +0100

    A few corrections to include/linux/Kbuild
    
    auxvec.h, i2c-dev.h and vt.h *should* be unifdef'ed i2o-dev.h does not need
    unifdef'ing
    
    Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
    Cc: David Woodhouse <dwmw2@infradead.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Sam Ravnborg <sam@ravnborg.org>