[PATCH] checkpatch: add filename in the summary

* [PATCH] checkpatch: add filename in the summary
@ 2008-01-14 22:23 Paolo Ciarrocchi
  2008-01-15 18:30 ` Cyrill Gorcunov
  2008-01-22 13:20 ` Paolo Ciarrocchi
  0 siblings, 2 replies; 6+ messages in thread
From: Paolo Ciarrocchi @ 2008-01-14 22:23 UTC (permalink / raw)
  To: apw, Linux Kernel

Add a filename option (default to 0)
in order to get the following summary output:
./scripts/checkpatch.pl --filename --file ./arch/sparc/kernel/apc.c 
...
...
...
./arch/sparc/kernel/apc.c --> total: 18 errors, 3 warnings, 186 lines checked
---

Andy, 
I wonder why checkpatch doesn't show all the command line options. 
At the moment, it only prints:
options: -q           => quiet
	--no-tree    => run without a kernel tree
        --terse      => one line per report
        --emacs      => emacs compile window format
        --file       => check a source file
        --strict     => enable more subjective tests
        --root       => path to the kernel tree root

but I see a lot more options:
	q|quiet
	tree
	signoff
	patch
	test-type
	emacs
	terse
	file
	subjective
	strict
	root=s
	summary
	mailback


 scripts/checkpatch.pl |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 579f50f..1762b73 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -24,6 +24,7 @@ my $file = 0;
 my $check = 0;
 my $summary = 1;
 my $mailback = 0;
+my $patchfilename= 0;
 my $root;
 GetOptions(
 	'q|quiet+'	=> \$quiet,
@@ -39,6 +40,7 @@ GetOptions(
 	'root=s'	=> \$root,
 	'summary!'	=> \$summary,
 	'mailback!'	=> \$mailback,
+	'filename'	=> \$patchfilename,
 ) or exit;
 
 my $exit = 0;
@@ -1579,12 +1581,18 @@ sub process {
 	}
 
 	print report_dump();
-	if ($summary) {
+	if ($summary == 1 && $patchfilename == 0) {
 		print "total: $cnt_error errors, $cnt_warn warnings, " .
 			(($check)? "$cnt_chk checks, " : "") .
 			"$cnt_lines lines checked\n";
 		print "\n" if ($quiet == 0);
 	}
+	if ($summary == 1 && $patchfilename == 1) {
+		print "$filename --> total: $cnt_error errors, $cnt_warn warnings, " .
+			(($check)? "$cnt_chk checks, " : "") .
+			"$cnt_lines lines checked\n";
+		print "\n" if ($quiet == 0);
+	}
 
 	if ($clean == 1 && $quiet == 0) {
 		print "Your patch has no obvious style problems and is ready for submission.\n"
-- 
1.5.4.rc3


^ permalink raw reply related	[flat|nested] 6+ messages in thread