* [PATCH] latencytop: Change Kconfig dependency.
@ 2008-02-01 13:06 Heiko Carstens
2008-02-01 13:11 ` Ingo Molnar
2008-02-01 13:28 ` Sam Ravnborg
0 siblings, 2 replies; 6+ messages in thread
From: Heiko Carstens @ 2008-02-01 13:06 UTC (permalink / raw)
To: Ingo Molnar, Arjan van de Ven
Cc: Martin Schwidefsky, Holger Wolf, linux-kernel
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Change latencytop Kconfig entry so it doesn't list the archictectures
that support it. Instead introduce HAVE_LATENCY_SUPPORT which any
architecture can set. Should reduce patch conflicts.
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Holger Wolf <wolf@linux.vnet.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
If ok, should this go in via the x86 tree?
arch/x86/Kconfig | 3 +++
lib/Kconfig.debug | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
Index: linux-2.6/arch/x86/Kconfig
===================================================================
--- linux-2.6.orig/arch/x86/Kconfig
+++ linux-2.6/arch/x86/Kconfig
@@ -44,6 +44,9 @@ config LOCKDEP_SUPPORT
config STACKTRACE_SUPPORT
def_bool y
+config HAVE_LATENCYTOP_SUPPORT
+ def_bool y
+
config SEMAPHORE_SLEEPERS
def_bool y
Index: linux-2.6/lib/Kconfig.debug
===================================================================
--- linux-2.6.orig/lib/Kconfig.debug
+++ linux-2.6/lib/Kconfig.debug
@@ -581,7 +581,7 @@ config LATENCYTOP
select STACKTRACE
select SCHEDSTATS
select SCHED_DEBUG
- depends on X86 || X86_64
+ depends on HAVE_LATENCYTOP_SUPPORT
help
Enable this option if you want to use the LatencyTOP tool
to find out which userspace is blocking on what kernel operations.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] latencytop: Change Kconfig dependency.
2008-02-01 13:06 [PATCH] latencytop: Change Kconfig dependency Heiko Carstens
@ 2008-02-01 13:11 ` Ingo Molnar
2008-02-01 13:28 ` Sam Ravnborg
1 sibling, 0 replies; 6+ messages in thread
From: Ingo Molnar @ 2008-02-01 13:11 UTC (permalink / raw)
To: Heiko Carstens
Cc: Arjan van de Ven, Martin Schwidefsky, Holger Wolf, linux-kernel
* Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> Change latencytop Kconfig entry so it doesn't list the archictectures
> that support it. Instead introduce HAVE_LATENCY_SUPPORT which any
> architecture can set. Should reduce patch conflicts.
thanks, applied.
Ingo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] latencytop: Change Kconfig dependency.
2008-02-01 13:06 [PATCH] latencytop: Change Kconfig dependency Heiko Carstens
2008-02-01 13:11 ` Ingo Molnar
@ 2008-02-01 13:28 ` Sam Ravnborg
2008-02-01 13:32 ` Ingo Molnar
2008-02-01 16:22 ` Heiko Carstens
1 sibling, 2 replies; 6+ messages in thread
From: Sam Ravnborg @ 2008-02-01 13:28 UTC (permalink / raw)
To: Heiko Carstens
Cc: Ingo Molnar, Arjan van de Ven, Martin Schwidefsky, Holger Wolf,
linux-kernel
On Fri, Feb 01, 2008 at 02:06:36PM +0100, Heiko Carstens wrote:
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> Change latencytop Kconfig entry so it doesn't list the archictectures
> that support it. Instead introduce HAVE_LATENCY_SUPPORT which any
> architecture can set. Should reduce patch conflicts.
>
> Cc: Arjan van de Ven <arjan@linux.intel.com>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Cc: Holger Wolf <wolf@linux.vnet.ibm.com>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
>
> If ok, should this go in via the x86 tree?
>
> arch/x86/Kconfig | 3 +++
> lib/Kconfig.debug | 2 +-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> Index: linux-2.6/arch/x86/Kconfig
> ===================================================================
> --- linux-2.6.orig/arch/x86/Kconfig
> +++ linux-2.6/arch/x86/Kconfig
> @@ -44,6 +44,9 @@ config LOCKDEP_SUPPORT
> config STACKTRACE_SUPPORT
> def_bool y
>
> +config HAVE_LATENCYTOP_SUPPORT
> + def_bool y
> +
No.
Please do:
config X86
+ select HAVE_LATENCYTOP_SUPPORT
Yes - this is a valid use of select.
See Documentation/kbuild/kconfig-language.txt
Sam
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] latencytop: Change Kconfig dependency.
2008-02-01 13:28 ` Sam Ravnborg
@ 2008-02-01 13:32 ` Ingo Molnar
2008-02-01 13:39 ` Sam Ravnborg
2008-02-01 16:22 ` Heiko Carstens
1 sibling, 1 reply; 6+ messages in thread
From: Ingo Molnar @ 2008-02-01 13:32 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Heiko Carstens, Arjan van de Ven, Martin Schwidefsky,
Holger Wolf, linux-kernel
* Sam Ravnborg <sam@ravnborg.org> wrote:
> > config STACKTRACE_SUPPORT
> > def_bool y
> >
> > +config HAVE_LATENCYTOP_SUPPORT
> > + def_bool y
> > +
> No.
> Please do:
> config X86
> + select HAVE_LATENCYTOP_SUPPORT
>
> Yes - this is a valid use of select.
i see - and there's lots of other examples of this and other similar
things in other architectures as well. Could we do that as a separate
cleanup patch instead, to keep the Kconfig file consistently structured.
Ingo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] latencytop: Change Kconfig dependency.
2008-02-01 13:32 ` Ingo Molnar
@ 2008-02-01 13:39 ` Sam Ravnborg
0 siblings, 0 replies; 6+ messages in thread
From: Sam Ravnborg @ 2008-02-01 13:39 UTC (permalink / raw)
To: Ingo Molnar
Cc: Heiko Carstens, Arjan van de Ven, Martin Schwidefsky,
Holger Wolf, linux-kernel
On Fri, Feb 01, 2008 at 02:32:28PM +0100, Ingo Molnar wrote:
>
> * Sam Ravnborg <sam@ravnborg.org> wrote:
>
> > > config STACKTRACE_SUPPORT
> > > def_bool y
> > >
> > > +config HAVE_LATENCYTOP_SUPPORT
> > > + def_bool y
> > > +
> > No.
> > Please do:
> > config X86
> > + select HAVE_LATENCYTOP_SUPPORT
> >
> > Yes - this is a valid use of select.
>
> i see - and there's lots of other examples of this and other similar
> things in other architectures as well. Could we do that as a separate
> cleanup patch instead, to keep the Kconfig file consistently structured.
I would prefer new stuff to use the recommended method.
But I have no strong feelign for it and at the moment I am fed up
in Section mismatch warnings :-(
Sam
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] latencytop: Change Kconfig dependency.
2008-02-01 13:28 ` Sam Ravnborg
2008-02-01 13:32 ` Ingo Molnar
@ 2008-02-01 16:22 ` Heiko Carstens
1 sibling, 0 replies; 6+ messages in thread
From: Heiko Carstens @ 2008-02-01 16:22 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Ingo Molnar, Arjan van de Ven, Martin Schwidefsky, Holger Wolf,
linux-kernel
> > +config HAVE_LATENCYTOP_SUPPORT
> > + def_bool y
> > +
> No.
> Please do:
> config X86
> + select HAVE_LATENCYTOP_SUPPORT
>
> Yes - this is a valid use of select.
>
> See Documentation/kbuild/kconfig-language.txt
Ok, I wasn't aware of that. For now I'll leave it as is
as Ingo requested.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-02-01 16:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-01 13:06 [PATCH] latencytop: Change Kconfig dependency Heiko Carstens
2008-02-01 13:11 ` Ingo Molnar
2008-02-01 13:28 ` Sam Ravnborg
2008-02-01 13:32 ` Ingo Molnar
2008-02-01 13:39 ` Sam Ravnborg
2008-02-01 16:22 ` Heiko Carstens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).