linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 4/6] IDE: Coding Style fixes to drivers/ide/pci/it8213.c
@ 2008-02-24 18:18 Paolo Ciarrocchi
  2008-02-25 17:59 ` Sergei Shtylyov
  0 siblings, 1 reply; 3+ messages in thread
From: Paolo Ciarrocchi @ 2008-02-24 18:18 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz; +Cc: Linux Kernel, linux-ide

File is now error free, only a few
WARNING: line over 80 characters
are left.

Compile tested.

Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
---
 drivers/ide/pci/it8213.c |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/ide/pci/it8213.c b/drivers/ide/pci/it8213.c
index a5ba7e8..5b5b0cc 100644
--- a/drivers/ide/pci/it8213.c
+++ b/drivers/ide/pci/it8213.c
@@ -35,7 +35,7 @@ static void it8213_set_pio_mode(ide_drive_t *drive, const u8 pio)
 	static DEFINE_SPINLOCK(tune_lock);
 	int control = 0;
 
-	static const u8 timings[][2]= {
+	static const u8 timings[][2] = {
 					{ 0, 0 },
 					{ 0, 0 },
 					{ 1, 0 },
@@ -105,11 +105,10 @@ static void it8213_set_dma_mode(ide_drive_t *drive, const u8 speed)
 
 		if (!(reg48 & u_flag))
 			pci_write_config_byte(dev, 0x48, reg48 | u_flag);
-		if (speed >= XFER_UDMA_5) {
+		if (speed >= XFER_UDMA_5)
 			pci_write_config_byte(dev, 0x55, (u8) reg55|w_flag);
-		} else {
+		else
 			pci_write_config_byte(dev, 0x55, (u8) reg55 & ~w_flag);
-		}
 
 		if ((reg4a & a_speed) != u_speed)
 			pci_write_config_word(dev, 0x4a, (reg4a & ~a_speed) | u_speed);
@@ -170,7 +169,7 @@ static void __devinit init_hwif_it8213(ide_hwif_t *hwif)
 	{						\
 		.name		= name_str,		\
 		.init_hwif	= init_hwif_it8213,	\
-		.enablebits	= {{0x41,0x80,0x80}}, \
+		.enablebits	= { {0x41, 0x80, 0x80} }, \
 		.host_flags	= IDE_HFLAG_SINGLE,	\
 		.pio_mask	= ATA_PIO4,		\
 		.swdma_mask	= ATA_SWDMA2_ONLY,	\
-- 
1.5.4.2.316.gf7a7


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 4/6] IDE: Coding Style fixes to drivers/ide/pci/it8213.c
  2008-02-24 18:18 [PATCH 4/6] IDE: Coding Style fixes to drivers/ide/pci/it8213.c Paolo Ciarrocchi
@ 2008-02-25 17:59 ` Sergei Shtylyov
  2008-02-26 21:25   ` Bartlomiej Zolnierkiewicz
  0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2008-02-25 17:59 UTC (permalink / raw)
  To: Paolo Ciarrocchi; +Cc: Bartlomiej Zolnierkiewicz, Linux Kernel, linux-ide

Paolo Ciarrocchi wrote:

> File is now error free, only a few
> WARNING: line over 80 characters
> are left.

> Compile tested.

> Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

MBR, Sergei

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 4/6] IDE: Coding Style fixes to drivers/ide/pci/it8213.c
  2008-02-25 17:59 ` Sergei Shtylyov
@ 2008-02-26 21:25   ` Bartlomiej Zolnierkiewicz
  0 siblings, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2008-02-26 21:25 UTC (permalink / raw)
  To: Sergei Shtylyov; +Cc: Paolo Ciarrocchi, Linux Kernel, linux-ide

On Monday 25 February 2008, Sergei Shtylyov wrote:
> Paolo Ciarrocchi wrote:
> 
> > File is now error free, only a few
> > WARNING: line over 80 characters
> > are left.
> 
> > Compile tested.
> 
> > Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
> 
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

applied

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-02-26 22:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-24 18:18 [PATCH 4/6] IDE: Coding Style fixes to drivers/ide/pci/it8213.c Paolo Ciarrocchi
2008-02-25 17:59 ` Sergei Shtylyov
2008-02-26 21:25   ` Bartlomiej Zolnierkiewicz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).