* [PATCH] [SDIO] add vendor and product pair for SQN1130
@ 2008-03-07 8:08 Andy Shevchenko
2008-03-07 10:45 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2008-03-07 8:08 UTC (permalink / raw)
To: linux-kernel; +Cc: drzeus-list, Andy Shevchenko
Add the vendor and product ids for Sequans SQN1130 WiMAX chipset.
---
include/linux/mmc/sdio_ids.h | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
index ea1bf5b..d1b9883 100644
--- a/include/linux/mmc/sdio_ids.h
+++ b/include/linux/mmc/sdio_ids.h
@@ -26,4 +26,7 @@
#define SDIO_VENDOR_ID_MARVELL 0x02df
#define SDIO_DEVICE_ID_MARVELL_LIBERTAS 0x9103
+#define SDIO_VENDOR_ID_SEQUANS 0x039d
+#define SDIO_DEVICE_ID_SEQUANS_SQN1130 0x046a
+
#endif
--
1.5.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [SDIO] add vendor and product pair for SQN1130
2008-03-07 8:08 [PATCH] [SDIO] add vendor and product pair for SQN1130 Andy Shevchenko
@ 2008-03-07 10:45 ` Andrew Morton
2008-03-07 11:40 ` Pierre Ossman
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2008-03-07 10:45 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-kernel, drzeus-list
On Fri, 7 Mar 2008 10:08:30 +0200 Andy Shevchenko <andy@smile.org.ua> wrote:
> Add the vendor and product ids for Sequans SQN1130 WiMAX chipset.
> ---
> include/linux/mmc/sdio_ids.h | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
> index ea1bf5b..d1b9883 100644
> --- a/include/linux/mmc/sdio_ids.h
> +++ b/include/linux/mmc/sdio_ids.h
> @@ -26,4 +26,7 @@
> #define SDIO_VENDOR_ID_MARVELL 0x02df
> #define SDIO_DEVICE_ID_MARVELL_LIBERTAS 0x9103
>
> +#define SDIO_VENDOR_ID_SEQUANS 0x039d
> +#define SDIO_DEVICE_ID_SEQUANS_SQN1130 0x046a
> +
There's no point in adding these unless there's actually some code there
which _uses_ them?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [SDIO] add vendor and product pair for SQN1130
2008-03-07 10:45 ` Andrew Morton
@ 2008-03-07 11:40 ` Pierre Ossman
0 siblings, 0 replies; 3+ messages in thread
From: Pierre Ossman @ 2008-03-07 11:40 UTC (permalink / raw)
To: Andrew Morton; +Cc: Andy Shevchenko, linux-kernel
On Fri, 7 Mar 2008 02:45:26 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:
> On Fri, 7 Mar 2008 10:08:30 +0200 Andy Shevchenko <andy@smile.org.ua> wrote:
>
> > Add the vendor and product ids for Sequans SQN1130 WiMAX chipset.
> > ---
> > include/linux/mmc/sdio_ids.h | 3 +++
> > 1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
> > index ea1bf5b..d1b9883 100644
> > --- a/include/linux/mmc/sdio_ids.h
> > +++ b/include/linux/mmc/sdio_ids.h
> > @@ -26,4 +26,7 @@
> > #define SDIO_VENDOR_ID_MARVELL 0x02df
> > #define SDIO_DEVICE_ID_MARVELL_LIBERTAS 0x9103
> >
> > +#define SDIO_VENDOR_ID_SEQUANS 0x039d
> > +#define SDIO_DEVICE_ID_SEQUANS_SQN1130 0x046a
> > +
>
> There's no point in adding these unless there's actually some code there
> which _uses_ them?
Agreed. This is just noise.
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-03-07 11:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-07 8:08 [PATCH] [SDIO] add vendor and product pair for SQN1130 Andy Shevchenko
2008-03-07 10:45 ` Andrew Morton
2008-03-07 11:40 ` Pierre Ossman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).