From: Andres Salomon <dilinger@queued.net>
To: Jens Rottmann <JRottmann@LiPPERT-AT.de>
Cc: jordan.crouse@amd.com, linux-kernel@vger.kernel.org,
linux-geode@bombadil.infradead.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-fbdev-devel@lists.sourceforge.net,
torvalds@linux-foundation.org
Subject: Re: lxfb driver regression
Date: Mon, 12 May 2008 18:51:48 -0400 [thread overview]
Message-ID: <20080512185148.104fc4c3@ephemeral> (raw)
In-Reply-To: <48230694.5010505@LiPPERT-AT.de>
On Thu, 08 May 2008 15:56:36 +0200
Jens Rottmann <JRottmann@LiPPERT-AT.de> wrote:
> Hi Andres,
>
[...]
>
> I have also attached a cut down version of my patch. It still adds
> all the PLL settings for < 25 MHz dotclocks, but it no longer
> supplements the > 25 MHz clocks with intermediate steps. I'm only
> guessing here, I don't see what big difference this would make, but
> still ... could you please give it a try if you have time?
>
Sorry for the delay, I got around to testing this today. It works
much better on an XO, so I've ack'd it.
Since updating to -rc2, I'm unable to reproduce the strange mode
setting differences; the original patch, reverting the original
patch, and also applying the new patch now all show:
[ 1.005011] Console: switching to colour frame buffer device 150x56
> Thanks a lot for your help.
>
> Regards,
> Jens Rottmann
>
> =============X8=================X8==============================
> lxfb: extend PLL table to support dotclocks below 25 MHz
>
> Extends the PLL frequency table of the AMD Geode-LX frame buffer
> driver to make use of the DIV4 bit, thus adding support for
> dotclocks between 6 and 24 MHz. These are needed for small LCDs
> (e.g. 320x240).
>
> Signed-off-by: Jens Rottmann <JRottmann@LiPPERT-AT.de>
Acked-by: Andres Salomon <dilinger@debian.org>
> ---
>
> --- linux-2.6.25/drivers/video/geode/lxfb_ops.c
> +++ lxfb_clocks_added/drivers/video/geode/lxfb_ops.c
> @@ -34,35 +34,63 @@ static const struct {
> unsigned int pllval;
> unsigned int freq;
> } pll_table[] = {
> - { 0x000031AC, 24923 },
> - { 0x0000215D, 25175 },
> - { 0x00001087, 27000 },
> - { 0x0000216C, 28322 },
> - { 0x0000218D, 28560 },
> - { 0x000010C9, 31200 },
> - { 0x00003147, 31500 },
> - { 0x000010A7, 33032 },
> - { 0x00002159, 35112 },
> - { 0x00004249, 35500 },
> - { 0x00000057, 36000 },
> - { 0x0000219A, 37889 },
> - { 0x00002158, 39168 },
> - { 0x00000045, 40000 },
> - { 0x00000089, 43163 },
> - { 0x000010E7, 44900 },
> - { 0x00002136, 45720 },
> - { 0x00003207, 49500 },
> - { 0x00002187, 50000 },
> - { 0x00004286, 56250 },
> - { 0x000010E5, 60065 },
> - { 0x00004214, 65000 },
> - { 0x00001105, 68179 },
> - { 0x000031E4, 74250 },
> - { 0x00003183, 75000 },
> - { 0x00004284, 78750 },
> - { 0x00001104, 81600 },
> - { 0x00006363, 94500 },
> - { 0x00005303, 97520 },
> + { 0x000131AC, 6231 },
> + { 0x0001215D, 6294 },
> + { 0x00011087, 6750 },
> + { 0x0001216C, 7081 },
> + { 0x0001218D, 7140 },
> + { 0x000110C9, 7800 },
> + { 0x00013147, 7875 },
> + { 0x000110A7, 8258 },
> + { 0x00012159, 8778 },
> + { 0x00014249, 8875 },
> + { 0x00010057, 9000 },
> + { 0x0001219A, 9472 },
> + { 0x00012158, 9792 },
> + { 0x00010045, 10000 },
> + { 0x00010089, 10791 },
> + { 0x000110E7, 11225 },
> + { 0x00012136, 11430 },
> + { 0x00013207, 12375 },
> + { 0x00012187, 12500 },
> + { 0x00014286, 14063 },
> + { 0x000110E5, 15016 },
> + { 0x00014214, 16250 },
> + { 0x00011105, 17045 },
> + { 0x000131E4, 18563 },
> + { 0x00013183, 18750 },
> + { 0x00014284, 19688 },
> + { 0x00011104, 20400 },
> + { 0x00016363, 23625 },
> + { 0x000031AC, 24923 },
> + { 0x0000215D, 25175 },
> + { 0x00001087, 27000 },
> + { 0x0000216C, 28322 },
> + { 0x0000218D, 28560 },
> + { 0x000010C9, 31200 },
> + { 0x00003147, 31500 },
> + { 0x000010A7, 33032 },
> + { 0x00002159, 35112 },
> + { 0x00004249, 35500 },
> + { 0x00000057, 36000 },
> + { 0x0000219A, 37889 },
> + { 0x00002158, 39168 },
> + { 0x00000045, 40000 },
> + { 0x00000089, 43163 },
> + { 0x000010E7, 44900 },
> + { 0x00002136, 45720 },
> + { 0x00003207, 49500 },
> + { 0x00002187, 50000 },
> + { 0x00004286, 56250 },
> + { 0x000010E5, 60065 },
> + { 0x00004214, 65000 },
> + { 0x00001105, 68179 },
> + { 0x000031E4, 74250 },
> + { 0x00003183, 75000 },
> + { 0x00004284, 78750 },
> + { 0x00001104, 81600 },
> + { 0x00006363, 94500 },
> + { 0x00005303, 97520 },
> { 0x00002183, 100187 },
> { 0x00002122, 101420 },
> { 0x00001081, 108000 },
> @@ -137,7 +165,7 @@ static void lx_set_clock(struct fb_info
> unsigned int diff, min, best = 0;
> unsigned int freq, i;
>
> - freq = (unsigned int) (0x3b9aca00 / info->var.pixclock);
> + freq = (unsigned int) (1000000000 / info->var.pixclock);
>
> min = abs(pll_table[0].freq - freq);
>
> @@ -149,7 +177,7 @@ static void lx_set_clock(struct fb_info
> }
> }
>
> - lx_set_dotpll(pll_table[best].pllval & 0x7FFF);
> + lx_set_dotpll(pll_table[best].pllval & 0x00017FFF);
> }
>
> static void lx_graphics_disable(struct fb_info *info)
>
next prev parent reply other threads:[~2008-05-12 22:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-08 1:08 lxfb driver regression Andres Salomon
2008-05-08 1:11 ` Andrew Morton
2008-05-08 13:56 ` Jens Rottmann
2008-05-08 14:48 ` Andres Salomon
2008-05-09 10:33 ` Jens Rottmann
2008-05-08 15:06 ` Jordan Crouse
2008-05-12 22:51 ` Andres Salomon [this message]
2008-05-13 10:29 ` Jens Rottmann
2008-05-13 15:48 ` Linus Torvalds
2008-05-13 16:35 ` Andrew Morton
2008-05-13 17:50 ` Andres Salomon
2008-05-13 17:55 ` Andres Salomon
2008-05-13 20:05 ` Jordan Crouse
2008-05-14 12:44 ` Jens Rottmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080512185148.104fc4c3@ephemeral \
--to=dilinger@queued.net \
--cc=JRottmann@LiPPERT-AT.de \
--cc=akpm@linux-foundation.org \
--cc=jordan.crouse@amd.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-geode@bombadil.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).