From: Andres Salomon <dilinger@queued.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Jens Rottmann <JRottmann@LiPPERT-AT.de>,
jordan.crouse@amd.com, linux-kernel@vger.kernel.org,
linux-geode@bombadil.infradead.org,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: lxfb driver regression
Date: Tue, 13 May 2008 13:50:15 -0400 [thread overview]
Message-ID: <20080513135015.4452fb8f@ephemeral> (raw)
In-Reply-To: <20080513093554.64466981.akpm@linux-foundation.org>
On Tue, 13 May 2008 09:35:54 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:
> On Tue, 13 May 2008 08:48:02 -0700 (PDT) Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>
> >
> >
> > On Mon, 12 May 2008, Andres Salomon wrote:
> > >
> > > Sorry for the delay, I got around to testing this today. It works
> > > much better on an XO, so I've ack'd it.
> >
> > If people expect me to apply that patch, I hope they'll re-send
> > (with acks etc). Otherwise I just expect I'll get it through the
> > normal fbdev queues (which is often Andrew, but shouldn't be).
> >
>
> It got confusing. Turns out that I had a speculative revert patch,
> followed by a new patch with an identical changelog to the first one.
>
> I folded them together and below is what I presently have against
> mainline, but I have no changelog describing what it fixes.
>
> Can someone send some text please?
>
How's this? Jordan and Jens, please correct me if I'm off.
[PATCH] lxfb: fix regression on OLPC caused by PLL table updates
The following patch caused a regression with OLPC panels:
commit 3888d4639e78802c4ec1086127124e890461b9e4
lxfb: extend PLL table to support dotclocks below 25 MHz
Extends the PLL frequency table of the AMD Geode-LX frame buffer driver to
make use of the DIV4 bit, thus adding support for dotclocks between 6 and 25
MHz. These are needed for small LCDs (e.g. 320x240). Also inserts some
intermediate steps between pre-existing frequencies.
The problem was the insertion of intermediate steps into the frequency
table; they would cause the wrong frequency to be matched. This patch
drops those intermediate frequencies while keeping the sub-25MHz
frequencies.
Signed-off-by: Andres Salomon <dilinger@debian.org>
> ---
> a/drivers/video/geode/lxfb_ops.c~fix-lxfb-extend-pll-table-to-support-dotclocks-below-25-mhz
> +++ a/drivers/video/geode/lxfb_ops.c @@ -63,54 +63,32 @@ static const
> struct { { 0x00014284, 19688 },
> { 0x00011104, 20400 },
> { 0x00016363, 23625 },
> - { 0x00015303, 24380 },
> { 0x000031AC, 24923 },
> { 0x0000215D, 25175 },
> { 0x00001087, 27000 },
> { 0x0000216C, 28322 },
> { 0x0000218D, 28560 },
> - { 0x00010041, 29913 },
> { 0x000010C9, 31200 },
> { 0x00003147, 31500 },
> - { 0x000141A1, 32400 },
> { 0x000010A7, 33032 },
> - { 0x00012182, 33375 },
> - { 0x000141B1, 33750 },
> { 0x00002159, 35112 },
> { 0x00004249, 35500 },
> { 0x00000057, 36000 },
> - { 0x000141E1, 37125 },
> { 0x0000219A, 37889 },
> { 0x00002158, 39168 },
> { 0x00000045, 40000 },
> - { 0x000131A1, 40500 },
> - { 0x00010061, 42301 },
> { 0x00000089, 43163 },
> - { 0x00012151, 43875 },
> { 0x000010E7, 44900 },
> { 0x00002136, 45720 },
> - { 0x000152E1, 47250 },
> - { 0x00010071, 48000 },
> { 0x00003207, 49500 },
> { 0x00002187, 50000 },
> - { 0x00014291, 50625 },
> - { 0x00011101, 51188 },
> - { 0x00017481, 54563 },
> { 0x00004286, 56250 },
> - { 0x00014170, 57375 },
> - { 0x00016210, 58500 },
> { 0x000010E5, 60065 },
> - { 0x00013140, 62796 },
> { 0x00004214, 65000 },
> - { 0x00016250, 65250 },
> { 0x00001105, 68179 },
> - { 0x000141C0, 69600 },
> - { 0x00015220, 70160 },
> - { 0x00010050, 72000 },
> { 0x000031E4, 74250 },
> { 0x00003183, 75000 },
> { 0x00004284, 78750 },
> - { 0x00012130, 80052 },
> { 0x00001104, 81600 },
> { 0x00006363, 94500 },
> { 0x00005303, 97520 },
> _
>
next prev parent reply other threads:[~2008-05-13 17:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-08 1:08 lxfb driver regression Andres Salomon
2008-05-08 1:11 ` Andrew Morton
2008-05-08 13:56 ` Jens Rottmann
2008-05-08 14:48 ` Andres Salomon
2008-05-09 10:33 ` Jens Rottmann
2008-05-08 15:06 ` Jordan Crouse
2008-05-12 22:51 ` Andres Salomon
2008-05-13 10:29 ` Jens Rottmann
2008-05-13 15:48 ` Linus Torvalds
2008-05-13 16:35 ` Andrew Morton
2008-05-13 17:50 ` Andres Salomon [this message]
2008-05-13 17:55 ` Andres Salomon
2008-05-13 20:05 ` Jordan Crouse
2008-05-14 12:44 ` Jens Rottmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080513135015.4452fb8f@ephemeral \
--to=dilinger@queued.net \
--cc=JRottmann@LiPPERT-AT.de \
--cc=akpm@linux-foundation.org \
--cc=jordan.crouse@amd.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-geode@bombadil.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).