Build error: ARM badge4_defconfig

Build error: ARM badge4_defconfig

[Russell King]

For full details, see:

http://armlinux.simtec.co.uk/kautobuild/2.6.26-rc2-git2/badge4_defconfig.html

which is a regression at 2.6.25-git15 time. (2.6.25-git14 built fine,
seemingly because there wasn't a tuner-core.c in that kernel.)

  LD      .tmp_vmlinux1
drivers/built-in.o: In function `tuner_i2c_xfer_send_recv':
drivers/media/common/tuners/tuner-i2c.h:61: undefined reference to `i2c_transfer'
drivers/built-in.o: In function `tuner_i2c_xfer_send':
drivers/media/common/tuners/tuner-i2c.h:39: undefined reference to `i2c_transfer'
...

Divining options from the configuration log:

  I2C support (I2C) [M/n/y/?] m

So, i2c is modular here.

  Video For Linux (VIDEO_DEV) [Y/n/m/?] y

Video is built in, and since tuner-core.c is being built in as well, we
can assume MEDIA_TUNER=y.

drivers/media/common/tuners/Kconfig contains:

config MEDIA_TUNER
        tristate
        default DVB_CORE || VIDEO_DEV
        depends on DVB_CORE || VIDEO_DEV

which means it ends up being 'y' if either DVB_CORE or VIDEO_DEV is y
(which one is as shown above.)  There's a missing dependency here -
it clearly depends on i2c, so that should also be in the "depends" line.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of: