From: Ben Dooks <ben-linux@fluff.org>
To: Dmitry <dbaryshkov@gmail.com>
Cc: Ben Dooks <ben-linux@fluff.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.arm.linux.org.uk, sameo@openedhand.com
Subject: Re: [patch 2/4] MFD: Coding style fixes
Date: Wed, 9 Jul 2008 12:12:56 +0100 [thread overview]
Message-ID: <20080709111256.GM8489@trinity.fluff.org> (raw)
In-Reply-To: <bc64b4640807090411y774949f4q3c0881e93afa50bf@mail.gmail.com>
On Wed, Jul 09, 2008 at 03:11:21PM +0400, Dmitry wrote:
> 2008/7/9 Ben Dooks <ben-linux@fluff.org>:
> > Fix some coding style fixes in the mfd core driver.
> >
> > Signed-off-by: Ben Dooks <ben-linux@fluff.org>
>
> I don't have a strong feeling about this. As it's pretty much only
> whitespace changes,
> my feelings are closer to NAK. Leaving decision to Samuel or Ian.
The coding style is all over the place, this makes it far more readable.
> >
> > Index: linux-2.6.26-rc9-next20080709/drivers/mfd/mfd-core.c
> > ===================================================================
> > --- linux-2.6.26-rc9-next20080709.orig/drivers/mfd/mfd-core.c 2008-07-09 10:43:54.000000000 +0100
> > +++ linux-2.6.26-rc9-next20080709/drivers/mfd/mfd-core.c 2008-07-09 10:44:45.000000000 +0100
> > @@ -16,9 +16,9 @@
> > #include <linux/mfd/core.h>
> >
> > static int mfd_add_device(struct platform_device *parent,
> > - const struct mfd_cell *cell,
> > - struct resource *mem_base,
> > - int irq_base)
> > + const struct mfd_cell *cell,
> > + struct resource *mem_base,
> > + int irq_base)
> > {
> > struct resource res[cell->num_resources];
> > struct platform_device *pdev;
> > @@ -75,11 +75,10 @@ fail_alloc:
> > return ret;
> > }
> >
> > -int mfd_add_devices(
> > - struct platform_device *parent,
> > - const struct mfd_cell *cells, int n_devs,
> > - struct resource *mem_base,
> > - int irq_base)
> > +int mfd_add_devices(struct platform_device *parent,
> > + const struct mfd_cell *cells, int n_devs,
> > + struct resource *mem_base,
> > + int irq_base)
> > {
> > int i;
> > int ret = 0;
> > Index: linux-2.6.26-rc9-next20080709/include/linux/mfd/core.h
> > ===================================================================
> > --- linux-2.6.26-rc9-next20080709.orig/include/linux/mfd/core.h 2008-07-09 10:43:54.000000000 +0100
> > +++ linux-2.6.26-rc9-next20080709/include/linux/mfd/core.h 2008-07-09 10:44:45.000000000 +0100
> > @@ -1,5 +1,3 @@
> > -#ifndef MFD_CORE_H
> > -#define MFD_CORE_H
> > /*
> > * drivers/mfd/mfd-core.h
> > *
> > @@ -13,6 +11,9 @@
> > *
> > */
> >
> > +#ifndef MFD_CORE_H
> > +#define MFD_CORE_H
> > +
> > #include <linux/platform_device.h>
> >
> > /*
> > @@ -38,17 +39,15 @@ struct mfd_cell {
> > const struct resource *resources;
> > };
> >
> > -static inline struct mfd_cell *
> > -mfd_get_cell(struct platform_device *pdev)
> > +static inline struct mfd_cell *mfd_get_cell(struct platform_device *pdev)
> > {
> > return (struct mfd_cell *)pdev->dev.platform_data;
> > }
> >
> > -extern int mfd_add_devices(
> > - struct platform_device *parent,
> > - const struct mfd_cell *cells, int n_devs,
> > - struct resource *mem_base,
> > - int irq_base);
> > +extern int mfd_add_devices(struct platform_device *parent,
> > + const struct mfd_cell *cells, int n_devs,
> > + struct resource *mem_base,
> > + int irq_base);
> >
> > extern void mfd_remove_devices(struct platform_device *parent);
> >
> >
> > --
> >
>
>
>
> --
> With best wishes
> Dmitry
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
next prev parent reply other threads:[~2008-07-09 11:13 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 10:49 [patch 0/4] mfd updates and proposed changes Ben Dooks
2008-07-09 10:49 ` [patch 1/4] MFD: Use to_platform_device instead of container_of Ben Dooks
2008-07-09 11:10 ` Dmitry
2008-07-10 14:47 ` Samuel Ortiz
2008-07-29 0:06 ` Samuel Ortiz
2008-07-09 10:49 ` [patch 2/4] MFD: Coding style fixes Ben Dooks
2008-07-09 11:11 ` Dmitry
2008-07-09 11:12 ` Ben Dooks [this message]
2008-07-10 14:48 ` Samuel Ortiz
2008-07-09 11:46 ` ian
2008-07-29 0:07 ` Samuel Ortiz
2008-07-09 10:49 ` [patch 3/4] MFD: Remove unnecessary fields if mfd_cell structure Ben Dooks
2008-07-09 11:09 ` Dmitry
2008-07-09 11:12 ` Ben Dooks
2008-07-09 11:16 ` Dmitry
2008-07-09 11:38 ` Ben Dooks
2008-07-09 11:44 ` Dmitry
2008-07-09 10:49 ` [patch 4/4] MFD: Change mfd platform device usage to wrapper platform_device Ben Dooks
2008-07-09 11:15 ` Dmitry
2008-07-09 11:24 ` Ben Dooks
2008-07-09 11:31 ` Dmitry
2008-07-09 11:50 ` Ben Dooks
2008-07-09 11:56 ` Dmitry
2008-07-09 12:07 ` Ben Dooks
2008-07-09 12:31 ` Dmitry
2008-07-09 13:28 ` ian
2008-07-09 13:34 ` pHilipp Zabel
2008-07-09 13:37 ` ian
2008-07-11 21:37 ` Samuel Ortiz
2008-07-09 12:13 ` ian
2008-07-09 12:29 ` pHilipp Zabel
2008-07-09 11:45 ` ian
2008-07-09 11:52 ` Dmitry
2008-07-09 21:03 ` Russell King - ARM Linux
2008-07-09 21:13 ` Dmitry Baryshkov
2008-07-09 21:13 ` ian
2008-07-11 21:41 ` Samuel Ortiz
2008-07-09 20:56 ` Russell King - ARM Linux
2008-07-09 21:04 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080709111256.GM8489@trinity.fluff.org \
--to=ben-linux@fluff.org \
--cc=dbaryshkov@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).