From: "pHilipp Zabel" <philipp.zabel@gmail.com>
To: ian <spyro@f2s.com>
Cc: "Ben Dooks" <ben-linux@fluff.org>, Dmitry <dbaryshkov@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [patch 4/4] MFD: Change mfd platform device usage to wrapper platform_device
Date: Wed, 9 Jul 2008 15:34:29 +0200 [thread overview]
Message-ID: <74d0deb30807090634h6feb1f2eu53f8b13d810b8b3d@mail.gmail.com> (raw)
In-Reply-To: <1215610118.3295.92.camel@wirenth>
On Wed, Jul 9, 2008 at 3:28 PM, ian <spyro@f2s.com> wrote:
> On Wed, 2008-07-09 at 13:07 +0100, Ben Dooks wrote:
>> > They should be here for exactly the same reason. They are used by
>> the drivers
>> > that will be submitted later. E.g. OHCI driver needs such
>> > suspend/resume handling.
>>
>> No, you don't understand. I'll make a rather explicit point about the
>> very clever way the device tree works since the devices are registered
>> with their parent device set.
>
> Actually I misthought here too.
>
> The problem comes when the subdevices arent *quite* truely independant
> of their core, and thus need to ask the core to turn off power /
> clokcs / etc. for them
I agree "power" and "etc." are issues. Clocks should be handled by the
clock API just fine.
> they cant just do it themselves because the subdevices may be used on
> more than one core that does this hanling in different ways (eg. T7L and
> TC6393XB handle the 32KHz clock completely differently.
That shouln't matter with generic clocks. If they
clk_get(&mfd_cell->pdev.dev, "my_clk_input"), that should be
dispatched to the correct MFD clock regardless of the actual chip.
> on tc6393xb,
> theres a clock gate on the MFD core chip and on t7l66xb the clock has to
> be handled right back at the platform layer, in board specific code
> because the core has no gate, and the clock is fed to it from an
> external pin.
Still, that could be done inside the MFD driver's custom clock
enable/disable methods.
> Thats one example - there are others, not all clocks.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2008-07-09 13:34 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 10:49 [patch 0/4] mfd updates and proposed changes Ben Dooks
2008-07-09 10:49 ` [patch 1/4] MFD: Use to_platform_device instead of container_of Ben Dooks
2008-07-09 11:10 ` Dmitry
2008-07-10 14:47 ` Samuel Ortiz
2008-07-29 0:06 ` Samuel Ortiz
2008-07-09 10:49 ` [patch 2/4] MFD: Coding style fixes Ben Dooks
2008-07-09 11:11 ` Dmitry
2008-07-09 11:12 ` Ben Dooks
2008-07-10 14:48 ` Samuel Ortiz
2008-07-09 11:46 ` ian
2008-07-29 0:07 ` Samuel Ortiz
2008-07-09 10:49 ` [patch 3/4] MFD: Remove unnecessary fields if mfd_cell structure Ben Dooks
2008-07-09 11:09 ` Dmitry
2008-07-09 11:12 ` Ben Dooks
2008-07-09 11:16 ` Dmitry
2008-07-09 11:38 ` Ben Dooks
2008-07-09 11:44 ` Dmitry
2008-07-09 10:49 ` [patch 4/4] MFD: Change mfd platform device usage to wrapper platform_device Ben Dooks
2008-07-09 11:15 ` Dmitry
2008-07-09 11:24 ` Ben Dooks
2008-07-09 11:31 ` Dmitry
2008-07-09 11:50 ` Ben Dooks
2008-07-09 11:56 ` Dmitry
2008-07-09 12:07 ` Ben Dooks
2008-07-09 12:31 ` Dmitry
2008-07-09 13:28 ` ian
2008-07-09 13:34 ` pHilipp Zabel [this message]
2008-07-09 13:37 ` ian
2008-07-11 21:37 ` Samuel Ortiz
2008-07-09 12:13 ` ian
2008-07-09 12:29 ` pHilipp Zabel
2008-07-09 11:45 ` ian
2008-07-09 11:52 ` Dmitry
2008-07-09 21:03 ` Russell King - ARM Linux
2008-07-09 21:13 ` Dmitry Baryshkov
2008-07-09 21:13 ` ian
2008-07-11 21:41 ` Samuel Ortiz
2008-07-09 20:56 ` Russell King - ARM Linux
2008-07-09 21:04 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74d0deb30807090634h6feb1f2eu53f8b13d810b8b3d@mail.gmail.com \
--to=philipp.zabel@gmail.com \
--cc=ben-linux@fluff.org \
--cc=dbaryshkov@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=spyro@f2s.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).