linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* MMC: s3cmci: attach get_cd host ops
@ 2008-08-12  8:24 Ben Dooks
  2008-08-17 18:00 ` Pierre Ossman
  0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2008-08-12  8:24 UTC (permalink / raw)
  To: drzeus-mmc, linux-kernel; +Cc: Ben Dooks

[-- Attachment #1: simtec/simtec-mmc-fix-card-detect.patch --]
[-- Type: text/plain, Size: 1492 bytes --]

Attach the routine to get_cd to allow the MMC core to find out whether
there is a card present or not without the tedious process of trying to
send commands to the card or not.

Signed-off-by: Ben Dooks <ben-linux@fluff.org>

Index: linux-2.6.27-rc2-quilt3/drivers/mmc/host/s3cmci.c
===================================================================
--- linux-2.6.27-rc2-quilt3.orig/drivers/mmc/host/s3cmci.c	2008-08-11 23:33:09.000000000 +0100
+++ linux-2.6.27-rc2-quilt3/drivers/mmc/host/s3cmci.c	2008-08-11 23:39:33.000000000 +0100
@@ -1004,8 +1004,9 @@ static void s3cmci_send_request(struct m
 	enable_irq(host->irq);
 }
 
-static int s3cmci_card_present(struct s3cmci_host *host)
+static int s3cmci_card_present(struct mmc_host *mmc)
 {
+	struct s3cmci_host *host = mmc_priv(mmc);
 	struct s3c24xx_mci_pdata *pdata = host->pdata;
 	int ret;
 
@@ -1024,7 +1025,7 @@ static void s3cmci_request(struct mmc_ho
 	host->cmd_is_stop = 0;
 	host->mrq = mrq;
 
-	if (s3cmci_card_present(host) == 0) {
+	if (s3cmci_card_present(mmc) == 0) {
 		dbg(host, dbg_err, "%s: no medium present\n", __func__);
 		host->mrq->cmd->error = -ENOMEDIUM;
 		mmc_request_done(mmc, mrq);
@@ -1139,6 +1140,7 @@ static struct mmc_host_ops s3cmci_ops = 
 	.request	= s3cmci_request,
 	.set_ios	= s3cmci_set_ios,
 	.get_ro		= s3cmci_get_ro,
+	.get_cd		= s3cmci_card_present,
 };
 
 static struct s3c24xx_mci_pdata s3cmci_def_pdata = {

-- 
Ben (ben@fluff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: MMC: s3cmci: attach get_cd host ops
  2008-08-12  8:24 MMC: s3cmci: attach get_cd host ops Ben Dooks
@ 2008-08-17 18:00 ` Pierre Ossman
  0 siblings, 0 replies; 2+ messages in thread
From: Pierre Ossman @ 2008-08-17 18:00 UTC (permalink / raw)
  To: Ben Dooks; +Cc: linux-kernel, Ben Dooks

On Tue, 12 Aug 2008 09:24:50 +0100
Ben Dooks <ben-linux@fluff.org> wrote:

> Attach the routine to get_cd to allow the MMC core to find out whether
> there is a card present or not without the tedious process of trying to
> send commands to the card or not.
> 
> Signed-off-by: Ben Dooks <ben-linux@fluff.org>
> 

Applied.

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-08-17 18:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-08-12  8:24 MMC: s3cmci: attach get_cd host ops Ben Dooks
2008-08-17 18:00 ` Pierre Ossman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).